From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D3161C433B4 for ; Tue, 11 May 2021 08:15:25 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5A5B861494 for ; Tue, 11 May 2021 08:15:25 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5A5B861494 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:54688 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lgNY4-0003EJ-A5 for qemu-devel@archiver.kernel.org; Tue, 11 May 2021 04:15:24 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:34052) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lgNUY-0005yH-TM for qemu-devel@nongnu.org; Tue, 11 May 2021 04:11:46 -0400 Received: from mail-ej1-x62c.google.com ([2a00:1450:4864:20::62c]:40604) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lgNUW-0007wD-H2 for qemu-devel@nongnu.org; Tue, 11 May 2021 04:11:46 -0400 Received: by mail-ej1-x62c.google.com with SMTP id n2so28441156ejy.7 for ; Tue, 11 May 2021 01:11:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=EeUlf0JRq1sYHE3OCYgKn7toCRqjL1i2ly2KHpcSbws=; b=GmgAkX1E0H6n2I02w1IMQo/ZZcxRSHWhURFTy/dSqzAM6qQ4c8fqcrhKPg60xf6PVx 6TfrfoRVzvlzEhkWvebN5Z0Qb0beeX4LOIXA6WT70Qnlile+9t3QYoBVdT0OFWufczy9 5XvOmfBQIChafJh1yNWGtSisQMjUmBOf5Ju9eIh5mXWDCH10pW0aduilU1ZtRC1rXK0E xRAt6tEvpnc8atE9DdXaNQqhB+qHR0vc0zW4mgfRCDv7Ffj6gXw7svWbvcJVwIX8XFvR jmVU1Qot2Ar0z8ZbaDdopg95CqeHO8YcwktbEirMt0IX20G1GSkf1gP7rYVTxHGDM9Vk 19GQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=EeUlf0JRq1sYHE3OCYgKn7toCRqjL1i2ly2KHpcSbws=; b=StZGIIP0u8u6vRiPlXQ9a+8WabIJfHmubEjDLPgeJD10IpF99ALGQdBWHTc04Lh35e hSeemJlnXzKgCGw3pYVs/Is3AImlXRrCUDN+QN0a7y1qEuJZg/mOetn5z1vFVBtlAzSI hdrvcd1GpO5s/8giLrNfy1ZC89axj2KcLopSi7GKjWokyeaNzSNsKOW3CY8m0V9igdIC dBUwlJRPf3dClWJELEARNkgrAs7KAAQeEhyQj6XWICmTRpj0+32PCxbjRJbZRJ1GDaa7 oPYBlxJdg/YBZK8C8RamcJl6QSuJOSEeFXA5KhFeBBN9bKwXe8O45CstY7T135odvxli dKyw== X-Gm-Message-State: AOAM530AmhXRl0xIfMgKm6nGlBpQePTHlbXtvN0UmGS25srk1UFfPo2E OeSf9eTFXnBZDzr8RQSf4g31/WS03m0VX4Z9Aa+a0Q== X-Google-Smtp-Source: ABdhPJxNi2AdtEMBFQQFb6WfAyTtDZ540Hz3qdxwuBSVJ7hxcekOKAgqKXYPHEodmtyVALFVGxwfdTlAl80/MjP6lEc= X-Received: by 2002:a17:906:254c:: with SMTP id j12mr12922ejb.4.1620720702929; Tue, 11 May 2021 01:11:42 -0700 (PDT) MIME-Version: 1.0 References: <20210430202610.1136687-1-richard.henderson@linaro.org> <20210430202610.1136687-5-richard.henderson@linaro.org> In-Reply-To: <20210430202610.1136687-5-richard.henderson@linaro.org> From: Peter Maydell Date: Tue, 11 May 2021 09:10:30 +0100 Message-ID: Subject: Re: [PATCH v6 04/82] target/arm: Implement SVE2 integer unary operations (predicated) To: Richard Henderson Content-Type: text/plain; charset="UTF-8" Received-SPF: pass client-ip=2a00:1450:4864:20::62c; envelope-from=peter.maydell@linaro.org; helo=mail-ej1-x62c.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-arm , QEMU Developers Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Fri, 30 Apr 2021 at 21:30, Richard Henderson wrote: > > Signed-off-by: Richard Henderson > --- > v2: Fix sqabs, sqneg (laurent desnogues) > --- > target/arm/helper-sve.h | 13 +++++++++++ > target/arm/sve.decode | 7 ++++++ > target/arm/sve_helper.c | 29 +++++++++++++++++++---- > target/arm/translate-sve.c | 47 ++++++++++++++++++++++++++++++++++++++ > 4 files changed, 92 insertions(+), 4 deletions(-) > diff --git a/target/arm/sve_helper.c b/target/arm/sve_helper.c > index 42fe315485..bbab84e81d 100644 > --- a/target/arm/sve_helper.c > +++ b/target/arm/sve_helper.c > @@ -535,8 +535,8 @@ static inline uint64_t do_sadalp_d(uint64_t n, uint64_t m) > return m + n1 + n2; > } > > -DO_ZPZZ(sve2_sadalp_zpzz_h, int16_t, H1_2, do_sadalp_h) > -DO_ZPZZ(sve2_sadalp_zpzz_s, int32_t, H1_4, do_sadalp_s) > +DO_ZPZZ(sve2_sadalp_zpzz_h, uint16_t, H1_2, do_sadalp_h) > +DO_ZPZZ(sve2_sadalp_zpzz_s, uint32_t, H1_4, do_sadalp_s) > DO_ZPZZ_D(sve2_sadalp_zpzz_d, uint64_t, do_sadalp_d) > > static inline uint16_t do_uadalp_h(uint16_t n, uint16_t m) > @@ -557,8 +557,8 @@ static inline uint64_t do_uadalp_d(uint64_t n, uint64_t m) > return m + n1 + n2; > } > > -DO_ZPZZ(sve2_uadalp_zpzz_h, int16_t, H1_2, do_uadalp_h) > -DO_ZPZZ(sve2_uadalp_zpzz_s, int32_t, H1_4, do_uadalp_s) > +DO_ZPZZ(sve2_uadalp_zpzz_h, uint16_t, H1_2, do_uadalp_h) > +DO_ZPZZ(sve2_uadalp_zpzz_s, uint32_t, H1_4, do_uadalp_s) > DO_ZPZZ_D(sve2_uadalp_zpzz_d, uint64_t, do_uadalp_d) > > #undef DO_ZPZZ These two hunks seem like they should have been in the previous patch. (Why do we want to use uint* for the sadalp version?) Other than that: Reviewed-by: Peter Maydell thanks -- PMM