From mboxrd@z Thu Jan 1 00:00:00 1970 From: George Dunlap Subject: Re: [PATCH V3 1/1] libxl: set stub domain size based on VRAM size Date: Tue, 14 Jul 2015 09:51:39 +0100 Message-ID: References: <1436650242-1067-1-git-send-email-eshelton@pobox.com> <1436650242-1067-2-git-send-email-eshelton@pobox.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta3.messagelabs.com ([195.245.230.39]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1ZEvwE-0005uD-BX for xen-devel@lists.xenproject.org; Tue, 14 Jul 2015 08:51:42 +0000 Received: by oiab3 with SMTP id b3so2127917oia.1 for ; Tue, 14 Jul 2015 01:51:39 -0700 (PDT) In-Reply-To: <1436650242-1067-2-git-send-email-eshelton@pobox.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Eric Shelton Cc: Wei Liu , Ian Campbell , Stefano Stabellini , Ian Jackson , Samuel Thibault , xen-devel List-Id: xen-devel@lists.xenproject.org On Sat, Jul 11, 2015 at 10:30 PM, Eric Shelton wrote: > Allocate additional memory to the stub domain for qemu-traditional if > more than 4 MB is assigned to the video adapter to avoid out of memory > condition for QEMU. > > Signed-off-by: Eric Shelton This seems like a good fix for now, thanks. But (just speaking to people in general) it does make it even harder to predict exactly how much host memory a VM is going to end up needing to start, which is something a lot of people complain about. I'm beginning to think that one feature we should try to look at is a way for the admin to specify, "Max host memory used", from which shadow/p2m/device memory/stubdomain can all be "allocated". -George > --- > tools/libxl/libxl_dm.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/tools/libxl/libxl_dm.c b/tools/libxl/libxl_dm.c > index 317a8eb..9a5a937 100644 > --- a/tools/libxl/libxl_dm.c > +++ b/tools/libxl/libxl_dm.c > @@ -1087,6 +1087,7 @@ void libxl__spawn_stub_dm(libxl__egc *egc, libxl__stub_dm_spawn_state *sdss) > > dm_config->b_info.max_vcpus = 1; > - dm_config->b_info.max_memkb = 32 * 1024; > + dm_config->b_info.max_memkb = 28 * 1024 + > + guest_config->b_info.video_memkb; > dm_config->b_info.target_memkb = dm_config->b_info.max_memkb; > > dm_config->b_info.u.pv.features = ""; > -- > 2.1.0 > > > _______________________________________________ > Xen-devel mailing list > Xen-devel@lists.xen.org > http://lists.xen.org/xen-devel