From: Simon Glass <sjg@chromium.org>
To: Yannic Moog <y.moog@phytec.de>
Cc: Alper Nebi Yasak <alpernebiyasak@gmail.com>,
Tom Rini <trini@konsulko.com>, Fabio Estevam <festevam@gmail.com>,
Tim Harvey <tharvey@gateworks.com>,
Benjamin Hahn <b.hahn@phytec.de>,
Teresa Remmet <t.remmet@phytec.de>,
Yashwanth Varakala <y.varakala@phytec.de>,
upstream@lists.phytec.de, u-boot@lists.denx.de
Subject: Re: [PATCH RFC 0/6] Fix handling of optional blobs in binman
Date: Mon, 10 Feb 2025 06:08:28 -0700 [thread overview]
Message-ID: <CAFLszTh7JYQYzAdW6-+EcaNj6tGy32QVQU3=n+dszFRmT6yFow@mail.gmail.com> (raw)
In-Reply-To: <20250129-binman_faked_optional-v1-0-a4534bc67cbb@phytec.de>
Hi Yannic,
On Wed, 29 Jan 2025 at 03:30, Yannic Moog <y.moog@phytec.de> wrote:
>
> This series solves a contradiction regarding ext blobs packaged in
> binman. When they are marked as optional, by default they are faked, two
> messages are emitted. One says the image is not functional the other
> says the image is still functional. Both concern the same binman
> entry/blob. To solve this, don't emit a warning when an image is faked
> AND optional.
> Make binman tests consistent with this behaviour.
> Add regex to test cases checking that the non-functional
> message is indeed not emitted. Update the documentation to inform users
> of this interaction.
>
> Binman is set up to have fake external blobs in case they are missing.
> This is regardless on whether they are optional or not.
> The implementation does not allow different types of entries to override
> the faking decision; at least there wouldn't be much sense in doing so.
>
> Here is an example build output of a phycore-imx8mp:
>
> BINMAN .binman_stamp
> Image 'image' is missing optional external blobs but is still functional: tee-os
>
> /binman/section/fit/images/tee/tee-os (tee.bin):
> See the documentation for your board. You may need to build Open Portable
> Trusted Execution Environment (OP-TEE) and build with TEE=/path/to/tee.bin
>
> Image 'image' has faked optional external blobs and is still functional: tee.bin
>
> OFCHK .config
>
> The first patch makes binman test with --fake_ext_blobs by default to be
> consistent with the default make target when building U-Boot. This
> exposes an error as one test is failing where it should not (loadables).
> Then, fix some tests that must not fake ext blobs and thus failed due to
> the change.
> Further, fix the behaviour of binman itself as explained above. Fixing
> this bug also makes the loadables test pass again.
> Finally, add test coverage for this new case and extend the
> documentation.
>
> ---
> Yannic Moog (6):
> tools: binman: ftest.py: fake ext blobs per default
> tools: binman: ftest: pass allow_fake_blob to _DoReadFileDtb
> tools: binman: ftest: fix tests that require non-faked ext blobs
> binman: fix faked optional entry handling
> binman: test: assert optional blobs don't cause non-functionality
> binman: doc: update Optional entries
>
> tools/binman/binman.rst | 9 ++++++++-
> tools/binman/control.py | 19 ++++++++++++++++---
> tools/binman/ftest.py | 43 ++++++++++++++++++++++++++++++++-----------
> 3 files changed, 56 insertions(+), 15 deletions(-)
> ---
> base-commit: a2b489b170f8382f746202c36616eaf2bc38fe86
> change-id: 20250122-binman_faked_optional-5025f7046e25
Thank you for looking at this.
Regards,
SImon
prev parent reply other threads:[~2025-02-10 13:08 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-29 10:29 [PATCH RFC 0/6] Fix handling of optional blobs in binman Yannic Moog
2025-01-29 10:29 ` [PATCH RFC 1/6] tools: binman: ftest.py: fake ext blobs per default Yannic Moog
2025-02-10 13:06 ` Simon Glass
2025-02-13 7:15 ` Yannic Moog
2025-02-13 14:01 ` Simon Glass
2025-02-14 7:18 ` Yannic Moog
2025-02-14 13:48 ` Simon Glass
2025-02-17 7:07 ` Yannic Moog
2025-01-29 10:29 ` [PATCH RFC 2/6] tools: binman: ftest: pass allow_fake_blob to _DoReadFileDtb Yannic Moog
2025-02-10 13:09 ` Simon Glass
2025-01-29 10:29 ` [PATCH RFC 3/6] tools: binman: ftest: fix tests that require non-faked ext blobs Yannic Moog
2025-02-10 13:09 ` Simon Glass
2025-02-13 7:15 ` Yannic Moog
2025-01-29 10:29 ` [PATCH RFC 4/6] binman: fix faked optional entry handling Yannic Moog
2025-02-10 13:09 ` Simon Glass
2025-01-29 10:29 ` [PATCH RFC 5/6] binman: test: assert optional blobs don't cause non-functionality Yannic Moog
2025-02-10 13:07 ` Simon Glass
2025-01-29 10:29 ` [PATCH RFC 6/6] binman: doc: update Optional entries Yannic Moog
2025-02-10 13:08 ` Simon Glass
2025-02-13 7:21 ` Yannic Moog
2025-02-13 14:01 ` Simon Glass
2025-02-14 7:05 ` Yannic Moog
2025-02-14 13:48 ` Simon Glass
2025-02-17 7:21 ` Yannic Moog
2025-02-17 13:13 ` Simon Glass
2025-02-18 13:15 ` Yannic Moog
2025-02-19 0:01 ` Simon Glass
2025-02-10 13:08 ` Simon Glass [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAFLszTh7JYQYzAdW6-+EcaNj6tGy32QVQU3=n+dszFRmT6yFow@mail.gmail.com' \
--to=sjg@chromium.org \
--cc=alpernebiyasak@gmail.com \
--cc=b.hahn@phytec.de \
--cc=festevam@gmail.com \
--cc=t.remmet@phytec.de \
--cc=tharvey@gateworks.com \
--cc=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
--cc=upstream@lists.phytec.de \
--cc=y.moog@phytec.de \
--cc=y.varakala@phytec.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.