From: George McCollister <george.mccollister@gmail.com>
To: Vladimir Oltean <olteanv@gmail.com>
Cc: netdev <netdev@vger.kernel.org>, Andrew Lunn <andrew@lunn.ch>,
Vivien Didelot <vivien.didelot@gmail.com>,
Florian Fainelli <f.fainelli@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH net-next] net: dsa: xrs700x: forward HSR supervision frames
Date: Tue, 15 Jun 2021 20:31:01 -0500 [thread overview]
Message-ID: <CAFSKS=OEM7bn2G6qXYQ16=9NUUpa-DhN=Nabc8P_E+7spUqKkQ@mail.gmail.com> (raw)
In-Reply-To: <20210615232242.3j4z5irr7abfhtwz@skbuf>
On Tue, Jun 15, 2021 at 6:22 PM Vladimir Oltean <olteanv@gmail.com> wrote:
>
> On Tue, Jun 15, 2021 at 12:55:26PM -0500, George McCollister wrote:
> > Forward supervision frames between redunant HSR ports. This was broken
> > in the last commit.
> >
> > Fixes: 1a42624aecba ("net: dsa: xrs700x: allow HSR/PRP supervision dupes
> > for node_table")
>
> It would be good if you could resend with the Fixes: line not wrapped
> around. There are several scripts around which won't parse that.
WIll do. I was wondering which way was correct and figured scripts
should be smart enough to parse it especially since all it should
really need is Fixes: $HASH. Oh well.
>
> > Signed-off-by: George McCollister <george.mccollister@gmail.com>
> > ---
>
> Otherwise the change looks reasonably clean, and it agrees with what IEC
> 62439-3:2018 does seem to imply in "5.3.4 DANH forwarding rules" that
> HSR_Supervision frames should be forwarded and without discarding
> duplicates. For PRP, of course the DANP does not forward packets between
> the redundant ports, so it does not forward PRP_Supervision packets
> either.
Yeah the tricky part with HSR supervision frames is you must forward
if the other port has received the duplicate frame but not if the
frame has been sent out the port you're about to send from already. At
first I set the mirror bit in addition to the allow bit and activity
was on completely solid as supervision frames looped around.
>
> Reviewed-by: Vladimir Oltean <olteanv@gmail.com>
Thanks
prev parent reply other threads:[~2021-06-16 1:31 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-15 17:55 [PATCH net-next] net: dsa: xrs700x: forward HSR supervision frames George McCollister
2021-06-15 23:22 ` Vladimir Oltean
2021-06-16 1:31 ` George McCollister [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAFSKS=OEM7bn2G6qXYQ16=9NUUpa-DhN=Nabc8P_E+7spUqKkQ@mail.gmail.com' \
--to=george.mccollister@gmail.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=vivien.didelot@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.