Re: [Buildroot] [PATCH v2] package/sqlite: fix build issue since bump to 3.49.0

From: Scott Fan <fancp2007@gmail.com>
To: Waldemar Brodkorb <wbx@openadk.org>
Cc: Julien Olivain <ju.o@free.fr>,
	buildroot@buildroot.org, Bernd Kuhls <bernd@kuhls.net>,
	 Thomas Petazzoni <thomas.petazzoni@bootlin.com>
Subject: Re: [Buildroot] [PATCH v2] package/sqlite: fix build issue since bump to 3.49.0
Date: Fri, 14 Feb 2025 15:49:00 +0800	[thread overview]
Message-ID: <CAFkzVZa7ns0bBWcjVPLv7BkWLnxmJXKAcTK5-np-m8cUwXa1cQ@mail.gmail.com> (raw)
In-Reply-To: <Z668GPE9/vZROlga@waldemar-brodkorb.de>

Hi Waldemar,

I have sent a new patch (v2), see the link below:
https://patchwork.ozlabs.org/project/buildroot/patch/20250214074235.917242-1-fancp2007@gmail.com/

With this patch, I tested the following defconfig, it's ok.
$ cat defconfig
BR2_aarch64=y
BR2_TOOLCHAIN_BUILDROOT_CXX=y
BR2_PACKAGE_ASTERISK=y

Could you take a moment to test this patch for your work? thanks.

Scott Fan

On Fri, Feb 14, 2025 at 11:44 AM Waldemar Brodkorb <wbx@openadk.org> wrote:
>
> Hi Scott,
> Scott Fan wrote,
>
> > Hi Waldemar,
> >
> > Thank you for your feedback.
> >
> > I have sent a new patch to fix it, see the link below:
> > https://patchwork.ozlabs.org/project/buildroot/patch/20250214021416.392363-1-fancp2007@gmail.com/
> >
> > Could you take a moment to test this patch for your work? thanks.
>
> Thanks for the fast patch. But it now fails when compiling shell.c:
> /home/wbx/buildroot/output/host/bin/aarch64-buildroot-linux-gnu-gcc -o sqlite3 \
>         shell.c sqlite3.c \
>         -I. -DSQLITE_ENABLE_MATH_FUNCTIONS -DSQLITE_OMIT_JSON -DSQLITE_THREADSAFE=1 -DHAVE_READLINE=1 -DSQLITE_HAVE_ZLIB=1 -DSQLITE_OMIT_READLINE_COMPLETION \
>         -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -D_FILE_OFFSET_BITS=64  -O2 -g0 -D_FORTIFY_SOURCE=1 -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -D_FILE_OFFSET_BITS=64 -I/home/wbx/buildroot/output/host/aarch64-buildroot-linux-gnu/sysroot/usr/include  \
>          -Wl,-rpath,/usr/lib  -lm  -lz   -ledit -lncurses
> shell.c:151:11: fatal error: readline/readline.h: No such file or directory
>   151 | # include <readline/readline.h>
>       |           ^~~~~~~~~~~~~~~~~~~~~
> compilation terminated.
>
> The configure command puts out:
>    NOTE: the local libedit but uses <readline/readline.h> so we
>     will compile with -DHAVE_READLINE=1 but will link with
>     libedit.
>
> thanks for working on it.
>
> best regards
>  Waldemar
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot