Re: [Buildroot] [PATCH] package/sqlite: fix build issue since bump to 3.49.0

From: Scott Fan <fancp2007@gmail.com>
To: Roy Kollen Svendsen <roykollensvendsen@gmail.com>
Cc: Fiona Klute <fiona.klute@gmx.de>, Bernd Kuhls <bernd@kuhls.net>,
	 Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
	buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH] package/sqlite: fix build issue since bump to 3.49.0
Date: Thu, 13 Feb 2025 16:19:26 +0800	[thread overview]
Message-ID: <CAFkzVZaAP3iZRZf0e072CQgHiTiTrdL-ndTV9JWBsfYpy2dhYA@mail.gmail.com> (raw)
In-Reply-To: <CA+R_depGhKXfGn2BUxGd+HkiWgY4ip2ZAm5ObwWJA4B6Bh4GpA@mail.gmail.com>

Hi,

I had tested the patch v2 with the defconfig:
$ cat defconfig
BR2_aarch64=y
BR2_TOOLCHAIN_BUILDROOT_CXX=y
BR2_PACKAGE_NFS_UTILS=y

Everything is OK. The "sqlite" and "host-sqlite" targets that the
nfs_utils package depends on are both compiled and passed.

Scott Fan

On Thu, Feb 13, 2025 at 2:39 PM Roy Kollen Svendsen
<roykollensvendsen@gmail.com> wrote:
>
> Hi,
>
> Fixes:
> 2025-02-13T06:48:18 >>> sqlite 3.49.0 Configuring
> ...
> 2025-02-13T06:48:19 Error: Unknown option --target
>
> Tested-By: Roy Kollen Svendsen <roykollensvendsen@gmail.com>
>
>
> tor. 13. feb. 2025 kl. 04:59 skrev Scott Fan <fancp2007@gmail.com>:
>>
>> Hi
>>
>> On Wed, Feb 12, 2025 at 11:47 PM Fiona Klute via buildroot
>> <buildroot@buildroot.org> wrote:
>> >
>> > Hi Scott, Baruch!
>> >
>> > Am 12.02.25 um 15:24 schrieb Baruch Siach via buildroot:
>> > > Hi Scott,
>> > >
>> > > On Wed, Feb 12 2025, Scott Fan wrote:
>> > >> As of release 3.49.0, the author has replaced the configure script used in
>> > >> the precompiled amalgamation tarball with Autosetup instead of Autotools.
>> > >>
>> > >> Fixes:
>> > >>    https://autobuild.buildroot.org/?reason=sqlite-3.49.0
>> > >>
>> > >> Signed-off-by: Scott Fan <fancp2007@gmail.com>
>> >
>> > Together with the "host-generic-package" Baruch pointed out this fixed
>> > my build, thanks! One thing looks odd though, see below.
>>
>> I will add the missing configurations for the "host-generic-package".
>>
>> >
>> > Best regards,
>> > Fiona
>> >
>> > >> ---
>> > >>   package/sqlite/sqlite.mk | 59 ++++++++++++++++++++++++----------------
>> > >>   1 file changed, 36 insertions(+), 23 deletions(-)
>> > >>
>> > >> diff --git a/package/sqlite/sqlite.mk b/package/sqlite/sqlite.mk
>> > >> index a23f6e1d66..30385f9821 100644
>> > >> --- a/package/sqlite/sqlite.mk
>> > >> +++ b/package/sqlite/sqlite.mk
>> > >> @@ -21,14 +21,6 @@ ifeq ($(BR2_PACKAGE_SQLITE_ENABLE_COLUMN_METADATA),y)
>> > >>   SQLITE_CFLAGS += -DSQLITE_ENABLE_COLUMN_METADATA
>> > >>   endif
>> > >>
>> > >> -ifeq ($(BR2_PACKAGE_SQLITE_ENABLE_FTS3),y)
>> > >> -SQLITE_CFLAGS += -DSQLITE_ENABLE_FTS3
>> > >> -endif
>> > >> -
>> > >> -ifeq ($(BR2_PACKAGE_SQLITE_ENABLE_JSON1),y)
>> > >> -SQLITE_CFLAGS += -DSQLITE_ENABLE_JSON1
>> > >> -endif
>> > >> -
>> > >>   ifeq ($(BR2_PACKAGE_SQLITE_ENABLE_UNLOCK_NOTIFY),y)
>> > >>   SQLITE_CFLAGS += -DSQLITE_ENABLE_UNLOCK_NOTIFY
>> > >>   endif
>> > >> @@ -50,30 +42,51 @@ else
>> > >>   SQLITE_CFLAGS += $(subst -Ofast,-O3,$(TARGET_CFLAGS))
>> > >>   endif
>> > >>
>> > >> -SQLITE_CONF_ENV = CFLAGS="$(SQLITE_CFLAGS)"
>> > >> -
>> > >> -ifeq ($(BR2_STATIC_LIBS),y)
>> > >> -SQLITE_CONF_OPTS += --enable-dynamic-extensions=no
>> > >> -else
>> > >> -SQLITE_CONF_OPTS += --disable-static-shell
>> > >> -endif
>> > >> -
>> > >>   ifeq ($(BR2_TOOLCHAIN_HAS_THREADS),y)
>> > >> -SQLITE_CONF_OPTS += --enable-threadsafe
>> > >> +SQLITE_CFLAGS += -DSQLITE_THREADSAFE=1
>> > >>   else
>> > >>   SQLITE_CONF_OPTS += --disable-threadsafe
>> > >> -SQLITE_CFLAGS += -DSQLITE_THREADSAFE=0
>> > >>   endif
>> >
>> > Why does --disable-threadsafe remain, while --enable-threadsafe is
>> > removed in the other branch, and -DSQLITE_THREADSAFE=0 removed while
>> > -DSQLITE_THREADSAFE=1 is added in the other branch? That seems
>> > inconsistent. My setup has BR2_TOOLCHAIN_HAS_THREADS=y, so I can only
>> > confirm the branch with threads works.
>>
>> When using the ./configure --help command in the release 3.49.0 to
>> view the usage, you can only see the --disable-threadsafe option, but
>> not the --enable-threadsafe option. Autosetup will automatically
>> detect whether threads are supported and set SQLITE_THREADSAFE to 1 or
>> 0. If threads are supported, SQLITE_THREADSAFE=1 is automatically set
>> by default, but you can force SQLITE_THREADSAFE=0 with the
>> --disable-threadsafe option.
>>
>> In my opinion, Autosetup has already done what it should do. I will
>> delete the lines related to thread safety options in the sqlite.mk
>> file.
>>
>>
>> >
>> > >>   ifeq ($(BR2_PACKAGE_NCURSES)$(BR2_PACKAGE_READLINE),yy)
>> > >>   SQLITE_DEPENDENCIES += ncurses readline
>> > >> -SQLITE_CONF_OPTS += --disable-editline --enable-readline
>> > >>   else ifeq ($(BR2_PACKAGE_LIBEDIT),y)
>> > >>   SQLITE_DEPENDENCIES += libedit
>> > >> -SQLITE_CONF_OPTS += --enable-editline --disable-readline
>> > >> +SQLITE_CONF_OPTS += --disable-readline --editline
>> > >>   else
>> > >> -SQLITE_CONF_OPTS += --disable-editline --disable-readline
>> > >> +SQLITE_CONF_OPTS += --disable-readline
>> > >>   endif
>> > >>
>> > >> -$(eval $(autotools-package))
>> > >> -$(eval $(host-autotools-package))
>> > >> +ifeq ($(BR2_PACKAGE_SQLITE_ENABLE_FTS3),y)
>> > >> +SQLITE_CONF_OPTS += --fts3
>> > >> +endif
>> > >> +
>> > >> +ifeq ($(BR2_PACKAGE_SQLITE_ENABLE_JSON1),)
>> > >> +SQLITE_CONF_OPTS += --disable-json
>> > >> +endif
>> > >> +
>> > >> +SQLITE_CONF_ENV = CFLAGS="$(SQLITE_CFLAGS)"
>> > >> +
>> > >> +define SQLITE_CONFIGURE_CMDS
>> > >> +    (cd $(@D); $(TARGET_CONFIGURE_OPTS) $(SQLITE_CONF_ENV) ./configure \
>> > >> +            --prefix=/usr \
>> > >> +            --host="$(GNU_TARGET_NAME)" \
>> > >> +            --build="$(GNU_HOST_NAME)" \
>> > >> +            --sysroot="$(STAGING_DIR)" \
>> > >> +            $(SQLITE_CONF_OPTS) \
>> > >> +    )
>> > >> +endef
>> > >> +
>> > >> +define SQLITE_BUILD_CMDS
>> > >> +    $(TARGET_MAKE_ENV) $(MAKE) -C $(@D)
>> > >> +endef
>> > >> +
>> > >> +define SQLITE_INSTALL_STAGING_CMDS
>> > >> +    $(TARGET_MAKE_ENV) $(MAKE) DESTDIR="$(STAGING_DIR)" -C $(@D) install
>> > >> +endef
>> > >> +
>> > >> +define SQLITE_INSTALL_TARGET_CMDS
>> > >> +    $(TARGET_MAKE_ENV) $(MAKE) DESTDIR="$(TARGET_DIR)" -C $(@D) install
>> > >> +endef
>> > >> +
>> > >> +$(eval $(generic-package))
>> > >
>> > > We also need host-generic-package to replace the host-autotools-package
>> > > removed above.
>> > >
>> > > baruch
>> > >
>> >
>> > _______________________________________________
>> > buildroot mailing list
>> > buildroot@buildroot.org
>> > https://lists.buildroot.org/mailman/listinfo/buildroot
>> _______________________________________________
>> buildroot mailing list
>> buildroot@buildroot.org
>> https://lists.buildroot.org/mailman/listinfo/buildroot
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot