From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4009AC433ED for ; Wed, 14 Apr 2021 08:06:52 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1D6A3611F0 for ; Wed, 14 Apr 2021 08:06:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1349905AbhDNIHL (ORCPT ); Wed, 14 Apr 2021 04:07:11 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34506 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1349898AbhDNIHJ (ORCPT ); Wed, 14 Apr 2021 04:07:09 -0400 Received: from mail-pj1-x1033.google.com (mail-pj1-x1033.google.com [IPv6:2607:f8b0:4864:20::1033]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0CF85C061574 for ; Wed, 14 Apr 2021 01:06:49 -0700 (PDT) Received: by mail-pj1-x1033.google.com with SMTP id b8-20020a17090a5508b029014d0fbe9b64so12066334pji.5 for ; Wed, 14 Apr 2021 01:06:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=q9984cqzokao90tfGIrsxyiVIENON1Jfg91EKnCdof8=; b=fW80R42TJsY77DRXQCzB9SKLcnXcPGFlu4lBTxcOlTPXkbLueFvuA39mPoRWpgxGZF S+MadSGXRh3tyq8byLtrkINS+a+tgsH/0sKoMiriG08wQrsSYXAbSTuA44AsiZo2eTDz Br0zZj/hKm98rMUtUxyKbXKWVkAZs2TO8sqPzTbPAAQweb1J4V7Ru0N+JZJzWQswIriJ c0PEB7f1qsOVjGQnAob6UMrvph7Av6/H3wvhbGJ6JOqVFMVS+eN8/A3Ls08fVv7+eGPR eCEjlpmZnaFrBvb0FE0xNx3ybIoJX81tLvuEEQKXjiUf4kS6dau3jWUQFtgjBGemH8CB 1whw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=q9984cqzokao90tfGIrsxyiVIENON1Jfg91EKnCdof8=; b=KrX4i6uvHrsmoJkQOtvYYwK4aXPnM336gN6TER/+0S0usDsTpX1ESC49jA0b+r8yz+ 05L/A1WWwmgwHGhW2hHUQTM9OPiWR75+gPzh3ku8c2bJJxfne676+RDdhlyH/NgnJNCe IxOX9NGP79GmC20brFwP2O9sY6oO4mTlOwrFtlSmlopdQbIeDwOohb4WpFzYESQOWLVf TGqTBTokY0in86Ds8jtLXqhOO7cMcwhjVZJxfpeGzvCiLHUiSRvHqIJ2mkND08GZjm6A NU+MWlu5OmD4SsjzpLENav5q5kZ/8grJ27PMZSX3Nkcwaf3VLct0Q55Ke4ODDsHylLLP e0fA== X-Gm-Message-State: AOAM532E9sC52LUafWHPmyaqBcyyQ/OqjEPh0G1RRzobKJQEXgQtZ22f g4cs2YrrDF0ghQN03dbrQfCKt9h/ydZ1vvPFlutpXg== X-Google-Smtp-Source: ABdhPJzEWdIhOr7juz3mZ7xnpTDpVDqoUyigBSUjrTKxFSeTivxg/jTYsNfrdGnGl+vl1J1spSTLtTsmuk227wJ+yOk= X-Received: by 2002:a17:90a:4a8f:: with SMTP id f15mr2306382pjh.19.1618387608629; Wed, 14 Apr 2021 01:06:48 -0700 (PDT) MIME-Version: 1.0 References: <20210412154648.3719153-1-narmstrong@baylibre.com> <20210412154648.3719153-3-narmstrong@baylibre.com> <3266977b-9d19-c81d-6fd7-b6fa0714b1ef@baylibre.com> In-Reply-To: <3266977b-9d19-c81d-6fd7-b6fa0714b1ef@baylibre.com> From: Robert Foss Date: Wed, 14 Apr 2021 10:06:37 +0200 Message-ID: Subject: Re: [PATCH v3 2/3] drm: bridge: add it66121 driver To: Neil Armstrong Cc: Andrzej Hajda , Laurent Pinchart , paul@crapouillou.net, Jonas Karlman , Jernej Skrabec , dri-devel , linux-kernel , Phong LE Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 14 Apr 2021 at 08:13, Neil Armstrong wrot= e: > > Hi Rob, > > Le 13/04/2021 =C3=A0 22:21, Robert Foss a =C3=A9crit : > > Hey Neil & Phong, > > > > Thanks for submitting this series! > > > >> + > >> +static const struct drm_bridge_funcs it66121_bridge_funcs =3D { > >> + .attach =3D it66121_bridge_attach, > >> + .enable =3D it66121_bridge_enable, > >> + .disable =3D it66121_bridge_disable, > >> + .mode_set =3D it66121_bridge_mode_set, > >> + .mode_valid =3D it66121_bridge_mode_valid, > >> + .detect =3D it66121_bridge_detect, > >> + .get_edid =3D it66121_bridge_get_edid, > >> + .atomic_get_output_bus_fmts =3D it66121_bridge_atomic_get_outp= ut_bus_fmts, > >> + .atomic_get_input_bus_fmts =3D it66121_bridge_atomic_get_input= _bus_fmts, > >> +}; > > > > I would like to see an implementation of HPD, since it is supported by > > the hardware[1] (and required by the documentation). IRQ status bit 0 > > seems to be the responsible for notifying us about hot plug detection > > events. > > It's implemented in the IRQ handler with the IT66121_INT_STATUS1_HPD_STAT= US event. > I didn't even get that far :) Either way, the HPD support should be exposed in drm_bridge_funcs (.hpd_enable, .hpd_disable (and possibly .hpd_notify)) and drm_bridge.ops (DRM_BRIDGE_OP_HPD). From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 61FDBC433B4 for ; Wed, 14 Apr 2021 08:06:50 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 23B63611F0 for ; Wed, 14 Apr 2021 08:06:50 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 23B63611F0 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 9A9746E14C; Wed, 14 Apr 2021 08:06:49 +0000 (UTC) Received: from mail-pj1-x1031.google.com (mail-pj1-x1031.google.com [IPv6:2607:f8b0:4864:20::1031]) by gabe.freedesktop.org (Postfix) with ESMTPS id 08FCF6E14C for ; Wed, 14 Apr 2021 08:06:49 +0000 (UTC) Received: by mail-pj1-x1031.google.com with SMTP id f2-20020a17090a4a82b02900c67bf8dc69so12089085pjh.1 for ; Wed, 14 Apr 2021 01:06:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=q9984cqzokao90tfGIrsxyiVIENON1Jfg91EKnCdof8=; b=fW80R42TJsY77DRXQCzB9SKLcnXcPGFlu4lBTxcOlTPXkbLueFvuA39mPoRWpgxGZF S+MadSGXRh3tyq8byLtrkINS+a+tgsH/0sKoMiriG08wQrsSYXAbSTuA44AsiZo2eTDz Br0zZj/hKm98rMUtUxyKbXKWVkAZs2TO8sqPzTbPAAQweb1J4V7Ru0N+JZJzWQswIriJ c0PEB7f1qsOVjGQnAob6UMrvph7Av6/H3wvhbGJ6JOqVFMVS+eN8/A3Ls08fVv7+eGPR eCEjlpmZnaFrBvb0FE0xNx3ybIoJX81tLvuEEQKXjiUf4kS6dau3jWUQFtgjBGemH8CB 1whw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=q9984cqzokao90tfGIrsxyiVIENON1Jfg91EKnCdof8=; b=onoJYySqWqqbh5eX6oIDaxJe8r8blRgCmZS1sCe4LIHMRrdV3nIGbfHKYGzqZXEZ44 V204zGtjU7jC3buhSvHXJFDQ9RBi8ZtJofcBWqdzkCCh+7imDgJYPhmPZgYm/2yThA9U RuwTuBge7gc5A/5ezlgSoogeJmRVuenpRMkErIFd7utn3mlZaPRRGeouxjg6efcsec5l Pg71jhP5iE+xSpeRd+DJDZKY/k+VOG6UOYEWSR7Zs+38Uw3KvaTpgFef8epF2XCNNefj d2YY4NOkVi2G71zxV0tRzDt+6Dgk6QVQt+MVJVrbDCrEl7qNWrBP8qvfweBqHMmviPI8 Um5Q== X-Gm-Message-State: AOAM533+lRQZciLRpWXTOXEHerZW39iRJzFphTZ6uC9+HIAwi9bpLqFn ifu6J7GQHVcng4ynlmWs8d+o2PkIXS64ruK+bPWjiAGa7fcyaQ== X-Google-Smtp-Source: ABdhPJzEWdIhOr7juz3mZ7xnpTDpVDqoUyigBSUjrTKxFSeTivxg/jTYsNfrdGnGl+vl1J1spSTLtTsmuk227wJ+yOk= X-Received: by 2002:a17:90a:4a8f:: with SMTP id f15mr2306382pjh.19.1618387608629; Wed, 14 Apr 2021 01:06:48 -0700 (PDT) MIME-Version: 1.0 References: <20210412154648.3719153-1-narmstrong@baylibre.com> <20210412154648.3719153-3-narmstrong@baylibre.com> <3266977b-9d19-c81d-6fd7-b6fa0714b1ef@baylibre.com> In-Reply-To: <3266977b-9d19-c81d-6fd7-b6fa0714b1ef@baylibre.com> From: Robert Foss Date: Wed, 14 Apr 2021 10:06:37 +0200 Message-ID: Subject: Re: [PATCH v3 2/3] drm: bridge: add it66121 driver To: Neil Armstrong X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Phong LE , Jernej Skrabec , Jonas Karlman , linux-kernel , dri-devel , paul@crapouillou.net, Andrzej Hajda , Laurent Pinchart Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" T24gV2VkLCAxNCBBcHIgMjAyMSBhdCAwODoxMywgTmVpbCBBcm1zdHJvbmcgPG5hcm1zdHJvbmdA YmF5bGlicmUuY29tPiB3cm90ZToKPgo+IEhpIFJvYiwKPgo+IExlIDEzLzA0LzIwMjEgw6AgMjI6 MjEsIFJvYmVydCBGb3NzIGEgw6ljcml0IDoKPiA+IEhleSBOZWlsICYgUGhvbmcsCj4gPgo+ID4g VGhhbmtzIGZvciBzdWJtaXR0aW5nIHRoaXMgc2VyaWVzIQo+ID4KPiA+PiArCj4gPj4gK3N0YXRp YyBjb25zdCBzdHJ1Y3QgZHJtX2JyaWRnZV9mdW5jcyBpdDY2MTIxX2JyaWRnZV9mdW5jcyA9IHsK PiA+PiArICAgICAgIC5hdHRhY2ggPSBpdDY2MTIxX2JyaWRnZV9hdHRhY2gsCj4gPj4gKyAgICAg ICAuZW5hYmxlID0gaXQ2NjEyMV9icmlkZ2VfZW5hYmxlLAo+ID4+ICsgICAgICAgLmRpc2FibGUg PSBpdDY2MTIxX2JyaWRnZV9kaXNhYmxlLAo+ID4+ICsgICAgICAgLm1vZGVfc2V0ID0gaXQ2NjEy MV9icmlkZ2VfbW9kZV9zZXQsCj4gPj4gKyAgICAgICAubW9kZV92YWxpZCA9IGl0NjYxMjFfYnJp ZGdlX21vZGVfdmFsaWQsCj4gPj4gKyAgICAgICAuZGV0ZWN0ID0gaXQ2NjEyMV9icmlkZ2VfZGV0 ZWN0LAo+ID4+ICsgICAgICAgLmdldF9lZGlkID0gaXQ2NjEyMV9icmlkZ2VfZ2V0X2VkaWQsCj4g Pj4gKyAgICAgICAuYXRvbWljX2dldF9vdXRwdXRfYnVzX2ZtdHMgPSBpdDY2MTIxX2JyaWRnZV9h dG9taWNfZ2V0X291dHB1dF9idXNfZm10cywKPiA+PiArICAgICAgIC5hdG9taWNfZ2V0X2lucHV0 X2J1c19mbXRzID0gaXQ2NjEyMV9icmlkZ2VfYXRvbWljX2dldF9pbnB1dF9idXNfZm10cywKPiA+ PiArfTsKPiA+Cj4gPiBJIHdvdWxkIGxpa2UgdG8gc2VlIGFuIGltcGxlbWVudGF0aW9uIG9mIEhQ RCwgc2luY2UgaXQgaXMgc3VwcG9ydGVkIGJ5Cj4gPiB0aGUgaGFyZHdhcmVbMV0gKGFuZCByZXF1 aXJlZCBieSB0aGUgZG9jdW1lbnRhdGlvbikuIElSUSBzdGF0dXMgYml0IDAKPiA+IHNlZW1zIHRv IGJlIHRoZSByZXNwb25zaWJsZSBmb3Igbm90aWZ5aW5nIHVzIGFib3V0IGhvdCBwbHVnIGRldGVj dGlvbgo+ID4gZXZlbnRzLgo+Cj4gSXQncyBpbXBsZW1lbnRlZCBpbiB0aGUgSVJRIGhhbmRsZXIg d2l0aCB0aGUgSVQ2NjEyMV9JTlRfU1RBVFVTMV9IUERfU1RBVFVTIGV2ZW50Lgo+CgpJIGRpZG4n dCBldmVuIGdldCB0aGF0IGZhciA6KQoKRWl0aGVyIHdheSwgdGhlIEhQRCBzdXBwb3J0IHNob3Vs ZCBiZSBleHBvc2VkIGluIGRybV9icmlkZ2VfZnVuY3MKKC5ocGRfZW5hYmxlLCAuaHBkX2Rpc2Fi bGUgKGFuZCBwb3NzaWJseSAuaHBkX25vdGlmeSkpIGFuZApkcm1fYnJpZGdlLm9wcyAoRFJNX0JS SURHRV9PUF9IUEQpLgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fXwpkcmktZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5v cmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2 ZWwK