From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754305AbbIHKWV (ORCPT ); Tue, 8 Sep 2015 06:22:21 -0400 Received: from mail-wi0-f195.google.com ([209.85.212.195]:34376 "EHLO mail-wi0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753254AbbIHKWQ (ORCPT ); Tue, 8 Sep 2015 06:22:16 -0400 MIME-Version: 1.0 In-Reply-To: <55EE9EE2.3060804@mellanox.com> References: <1441658303-18081-1-git-send-email-pandit.parav@gmail.com> <1441658303-18081-7-git-send-email-pandit.parav@gmail.com> <55EE9EE2.3060804@mellanox.com> Date: Tue, 8 Sep 2015 15:52:15 +0530 Message-ID: Subject: Re: [PATCH 6/7] devcg: Added support to use RDMA device cgroup. From: Parav Pandit To: Haggai Eran Cc: cgroups@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-rdma@vger.kernel.org, tj@kernel.org, lizefan@huawei.com, Johannes Weiner , Doug Ledford , Jonathan Corbet , james.l.morris@oracle.com, serge@hallyn.com, Or Gerlitz , Matan Barak , raindel@mellanox.com, akpm@linux-foundation.org, linux-security-module@vger.kernel.org Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Sep 8, 2015 at 2:10 PM, Haggai Eran wrote: > On 07/09/2015 23:38, Parav Pandit wrote: >> +static void init_ucontext_lists(struct ib_ucontext *ucontext) >> +{ >> + INIT_LIST_HEAD(&ucontext->pd_list); >> + INIT_LIST_HEAD(&ucontext->mr_list); >> + INIT_LIST_HEAD(&ucontext->mw_list); >> + INIT_LIST_HEAD(&ucontext->cq_list); >> + INIT_LIST_HEAD(&ucontext->qp_list); >> + INIT_LIST_HEAD(&ucontext->srq_list); >> + INIT_LIST_HEAD(&ucontext->ah_list); >> + INIT_LIST_HEAD(&ucontext->xrcd_list); >> + INIT_LIST_HEAD(&ucontext->rule_list); >> +} > > I don't see how this change is related to the patch. Its not but code which I added makes this function to grow longer, so to keep it to same readability level, I did the cleanup. May be I can send separate patch for cleanup?