From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752791AbbIHHCu (ORCPT ); Tue, 8 Sep 2015 03:02:50 -0400 Received: from mail-wi0-f179.google.com ([209.85.212.179]:37331 "EHLO mail-wi0-f179.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751344AbbIHHCr (ORCPT ); Tue, 8 Sep 2015 03:02:47 -0400 MIME-Version: 1.0 In-Reply-To: <55EE72B7.1060304@mellanox.com> References: <1441658303-18081-1-git-send-email-pandit.parav@gmail.com> <1441658303-18081-4-git-send-email-pandit.parav@gmail.com> <55EE72B7.1060304@mellanox.com> Date: Tue, 8 Sep 2015 12:32:46 +0530 Message-ID: Subject: Re: [PATCH 3/7] devcg: Added infrastructure for rdma device cgroup. From: Parav Pandit To: Haggai Eran Cc: cgroups@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-rdma@vger.kernel.org, tj@kernel.org, lizefan@huawei.com, Johannes Weiner , Doug Ledford , Jonathan Corbet , james.l.morris@oracle.com, serge@hallyn.com, Or Gerlitz , Matan Barak , raindel@mellanox.com, akpm@linux-foundation.org, linux-security-module@vger.kernel.org Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Sep 8, 2015 at 11:01 AM, Haggai Eran wrote: > On 07/09/2015 23:38, Parav Pandit wrote: >> diff --git a/include/linux/device_cgroup.h b/include/linux/device_cgroup.h >> index 8b64221..cdbdd60 100644 >> --- a/include/linux/device_cgroup.h >> +++ b/include/linux/device_cgroup.h >> @@ -1,6 +1,57 @@ >> +#ifndef _DEVICE_CGROUP >> +#define _DEVICE_CGROUP >> + >> #include >> +#include >> +#include > > You cannot add this include line before adding the device_rdma_cgroup.h > (added in patch 5). You should reorder the patches so that after each > patch the kernel builds correctly. > o.k. got it. I will send V1 with this suggested changes. > I also noticed in patch 2 you add device_rdma_cgroup.o to the Makefile > before it was added to the kernel. > o.k. > Regards, > Haggai From mboxrd@z Thu Jan 1 00:00:00 1970 From: Parav Pandit Subject: Re: [PATCH 3/7] devcg: Added infrastructure for rdma device cgroup. Date: Tue, 8 Sep 2015 12:32:46 +0530 Message-ID: References: <1441658303-18081-1-git-send-email-pandit.parav@gmail.com> <1441658303-18081-4-git-send-email-pandit.parav@gmail.com> <55EE72B7.1060304@mellanox.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Return-path: In-Reply-To: <55EE72B7.1060304-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org> Sender: cgroups-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Haggai Eran Cc: cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-doc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, lizefan-hv44wF8Li93QT0dZR+AlfA@public.gmane.org, Johannes Weiner , Doug Ledford , Jonathan Corbet , james.l.morris-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org, serge-A9i7LUbDfNHQT0dZR+AlfA@public.gmane.org, Or Gerlitz , Matan Barak , raindel-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org, akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org, linux-security-module-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: linux-rdma@vger.kernel.org On Tue, Sep 8, 2015 at 11:01 AM, Haggai Eran wrote: > On 07/09/2015 23:38, Parav Pandit wrote: >> diff --git a/include/linux/device_cgroup.h b/include/linux/device_cgroup.h >> index 8b64221..cdbdd60 100644 >> --- a/include/linux/device_cgroup.h >> +++ b/include/linux/device_cgroup.h >> @@ -1,6 +1,57 @@ >> +#ifndef _DEVICE_CGROUP >> +#define _DEVICE_CGROUP >> + >> #include >> +#include >> +#include > > You cannot add this include line before adding the device_rdma_cgroup.h > (added in patch 5). You should reorder the patches so that after each > patch the kernel builds correctly. > o.k. got it. I will send V1 with this suggested changes. > I also noticed in patch 2 you add device_rdma_cgroup.o to the Makefile > before it was added to the kernel. > o.k. > Regards, > Haggai