From mboxrd@z Thu Jan  1 00:00:00 1970
From: Chong Li <lichong659@gmail.com>
Subject: Re: [PATCH v4 for Xen 4.6 2/4] libxc: enable per-VCPU
 parameter settings for RTDS scheduler
Date: Fri, 7 Aug 2015 11:35:37 -0500
Message-ID: <CAGHO-iomPzew+-WS9Ny3ze3Lx+OqHGS1Y6EfjcEY9M_Yb3ANuw@mail.gmail.com>
References: <1436590356-3706-1-git-send-email-chong.li@wustl.edu>
	<1436590356-3706-3-git-send-email-chong.li@wustl.edu>
	<1438013466.5036.219.camel@citrix.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <1438013466.5036.219.camel@citrix.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Dario Faggioli <dario.faggioli@citrix.com>
Cc: Chong Li <chong.li@wustl.edu>, Wei Liu <wei.liu2@citrix.com>, Sisu Xi <xisisu@gmail.com>, George Dunlap <george.dunlap@eu.citrix.com>, xen-devel <xen-devel@lists.xen.org>, Meng Xu <mengxu@cis.upenn.edu>, Dagaen Golomb <dgolomb@seas.upenn.edu>
List-Id: xen-devel@lists.xenproject.org

On Mon, Jul 27, 2015 at 11:11 AM, Dario Faggioli
<dario.faggioli@citrix.com> wrote:
> On Fri, 2015-07-10 at 23:52 -0500, Chong Li wrote:
>
>> diff --git a/tools/libxc/include/xenctrl.h b/tools/libxc/include/xenctrl.h
>> index d1d2ab3..58f1a7a 100644
>> --- a/tools/libxc/include/xenctrl.h
>> +++ b/tools/libxc/include/xenctrl.h
>> @@ -915,6 +915,15 @@ int xc_sched_rtds_domain_get(xc_interface *xch,
>>                              uint32_t domid,
>>                              struct xen_domctl_sched_rtds *sdom);
>>
> So, here in the header, you're not changing the prototype of
> xc_sched_rtds_domain_{get,set} to use the typedef.
>
> However...
>
>> +int xc_sched_rtds_vcpu_set(xc_interface *xch,
>> +                            uint32_t domid,
>> +                            xen_domctl_schedparam_vcpu_t *vcpus,
>> +                            uint16_t num_vcpus);
>>
> ... you hare using the typedef for the newly introduced functions
> xc_sched_rtds_vcpu_{get,set}(), and...
>
>> --- a/tools/libxc/xc_rt.c
>> +++ b/tools/libxc/xc_rt.c
>> @@ -27,7 +27,7 @@
>>
>>  int xc_sched_rtds_domain_set(xc_interface *xch,
>>                             uint32_t domid,
>> -                           struct xen_domctl_sched_rtds *sdom)
>> +                           xen_domctl_sched_rtds_t *sdom)
>>
> ...you are actually changing the _implementation_ of
> xc_sched_rtds_domain_{get,set}().
>
> That's all rather inconsistent.

You're right. I'll change it.

>
> Regards,
> Dario
> --
> <<This happens because I choose it to happen!>> (Raistlin Majere)
> -----------------------------------------------------------------
> Dario Faggioli, Ph.D, http://about.me/dario.faggioli
> Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK)



-- 
Chong Li
Department of Computer Science and Engineering
Washington University in St.louis