From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755549AbbLGEJ5 (ORCPT ); Sun, 6 Dec 2015 23:09:57 -0500 Received: from mail-vk0-f43.google.com ([209.85.213.43]:36089 "EHLO mail-vk0-f43.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754774AbbLGEJ4 (ORCPT ); Sun, 6 Dec 2015 23:09:56 -0500 MIME-Version: 1.0 In-Reply-To: <1449460394-31601-1-git-send-email-bayi.cheng@mediatek.com> References: <1449460394-31601-1-git-send-email-bayi.cheng@mediatek.com> From: Daniel Kurtz Date: Mon, 7 Dec 2015 12:09:35 +0800 X-Google-Sender-Auth: AmrCSH9xc9TtnwH5vJ7O3OPdcwE Message-ID: Subject: Re: [PATCH] arm64: dts: mt8173: Add nor flash node To: Bayi Cheng Cc: Matthias Brugger , Brian Norris , "open list:OPEN FIRMWARE AND..." , "linux-arm-kernel@lists.infradead.org" , linux-mediatek@lists.infradead.org, "linux-kernel@vger.kernel.org" , linux-mtd@lists.infradead.org, srv_heupstream Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Bayi, On Mon, Dec 7, 2015 at 11:53 AM, Bayi Cheng wrote: > Add Mediatek nor flash node > > Signed-off-by: Bayi Cheng > Acked-by: Brian Norris > --- > Previous version of this patch is > http://lists.infradead.org/pipermail/linux-arm-kernel/2015-November/386005.html > Drop flash node from mt8173.dtsi accroding review comment Is there a flash on mt8173-evb that can be accessed by the nor_flash ? If so, can you include flash@0 node in the mt8173-evb.dts. -Dan > > --- > arch/arm64/boot/dts/mediatek/mt8173.dtsi | 11 +++++++++++ > 1 file changed, 11 insertions(+) > > diff --git a/arch/arm64/boot/dts/mediatek/mt8173.dtsi b/arch/arm64/boot/dts/mediatek/mt8173.dtsi > index 4dd5f93..af08e97 100644 > --- a/arch/arm64/boot/dts/mediatek/mt8173.dtsi > +++ b/arch/arm64/boot/dts/mediatek/mt8173.dtsi > @@ -387,6 +387,17 @@ > status = "disabled"; > }; > > + nor_flash: spi@1100d000 { > + compatible = "mediatek,mt8173-nor"; > + reg = <0 0x1100d000 0 0xe0>; > + clocks = <&pericfg CLK_PERI_SPI>, > + <&topckgen CLK_TOP_SPINFI_IFR_SEL>; > + clock-names = "spi", "sf"; > + #address-cells = <1>; > + #size-cells = <0>; > + status = "disabled"; > + }; > + > i2c3: i2c@11010000 { > compatible = "mediatek,mt8173-i2c"; > reg = <0 0x11010000 0 0x70>, > -- > 1.8.1.1.dirty > From mboxrd@z Thu Jan 1 00:00:00 1970 From: djkurtz@chromium.org (Daniel Kurtz) Date: Mon, 7 Dec 2015 12:09:35 +0800 Subject: [PATCH] arm64: dts: mt8173: Add nor flash node In-Reply-To: <1449460394-31601-1-git-send-email-bayi.cheng@mediatek.com> References: <1449460394-31601-1-git-send-email-bayi.cheng@mediatek.com> Message-ID: To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Bayi, On Mon, Dec 7, 2015 at 11:53 AM, Bayi Cheng wrote: > Add Mediatek nor flash node > > Signed-off-by: Bayi Cheng > Acked-by: Brian Norris > --- > Previous version of this patch is > http://lists.infradead.org/pipermail/linux-arm-kernel/2015-November/386005.html > Drop flash node from mt8173.dtsi accroding review comment Is there a flash on mt8173-evb that can be accessed by the nor_flash ? If so, can you include flash at 0 node in the mt8173-evb.dts. -Dan > > --- > arch/arm64/boot/dts/mediatek/mt8173.dtsi | 11 +++++++++++ > 1 file changed, 11 insertions(+) > > diff --git a/arch/arm64/boot/dts/mediatek/mt8173.dtsi b/arch/arm64/boot/dts/mediatek/mt8173.dtsi > index 4dd5f93..af08e97 100644 > --- a/arch/arm64/boot/dts/mediatek/mt8173.dtsi > +++ b/arch/arm64/boot/dts/mediatek/mt8173.dtsi > @@ -387,6 +387,17 @@ > status = "disabled"; > }; > > + nor_flash: spi at 1100d000 { > + compatible = "mediatek,mt8173-nor"; > + reg = <0 0x1100d000 0 0xe0>; > + clocks = <&pericfg CLK_PERI_SPI>, > + <&topckgen CLK_TOP_SPINFI_IFR_SEL>; > + clock-names = "spi", "sf"; > + #address-cells = <1>; > + #size-cells = <0>; > + status = "disabled"; > + }; > + > i2c3: i2c at 11010000 { > compatible = "mediatek,mt8173-i2c"; > reg = <0 0x11010000 0 0x70>, > -- > 1.8.1.1.dirty >