From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752308AbbIHBqp (ORCPT ); Mon, 7 Sep 2015 21:46:45 -0400 Received: from mail-yk0-f178.google.com ([209.85.160.178]:33606 "EHLO mail-yk0-f178.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751287AbbIHBqn (ORCPT ); Mon, 7 Sep 2015 21:46:43 -0400 MIME-Version: 1.0 In-Reply-To: <1441631969-3272-1-git-send-email-javi.merino@arm.com> References: <1440595604-27197-1-git-send-email-javi.merino@arm.com> <1441631969-3272-1-git-send-email-javi.merino@arm.com> From: Daniel Kurtz Date: Tue, 8 Sep 2015 09:46:23 +0800 X-Google-Sender-Auth: jYAQ0_qD4BKRejjf4l9FnztMczs Message-ID: Subject: Re: [PATCH v5 0/5] Let the power allocator thermal governor run on any thermal zone To: Javi Merino Cc: linux-pm@vger.kernel.org, Dmitry Torokhov , Chung-yih Wang , "linux-kernel@vger.kernel.org" , Punit Agrawal , Eduardo Valentin Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Javi, On Mon, Sep 7, 2015 at 9:19 PM, Javi Merino wrote: > Relax the thermal governor requirements of sustainable_power and at > least two trip points so that it can be bound to any thermal zone. > Its behavior won't be optimal, it would be the best possible with the > data provided. I tested this whole series on my MT8173 board with a battery thermal zone with no trip points, so, for this whole series (not sure if both are needed, so take your pick): Reviewed-by: Daniel Kurtz Tested-by: Daniel Kurtz I am a bit confused by MAINTAINERS for drivers/thermal. Will these patches be picked up by Eduardo or Zhang? Thanks! -Dan > Changes since v4: > - Fix crash when a thermal zone with no trip points has no > get_trip_point_temp(). Reported by Daniel Kurtz. > - s/estimate_controller_constants()/estimate_pid_constants()/g > > Changes since v3: > - Don't hardcode a value for sustainable power and re-estimate > the PID controllers every time if no sustainable power is given > as suggested by Eduardo Valentin. > - power_actor_get_min_power() moved to a patch of its own. > > Changes since v2: > - Typos suggested by Daniel Kurtz > > Changes since v1: > - Let the power allocator governor operate if the thermal zone > doesn't have tzp as suggested by Chung-yih Wang > > Javi Merino (5): > thermal: Add a function to get the minimum power > thermal: power_allocator: relax the requirement of a sustainable_power > in tzp > thermal: power_allocator: relax the requirement of two passive trip > points > thermal: power_allocator: don't require tzp to be present for the > thermal zone > thermal: power_allocator: exit early if there are no cooling devices > > Documentation/thermal/power_allocator.txt | 2 +- > drivers/thermal/power_allocator.c | 243 ++++++++++++++++++++++-------- > drivers/thermal/thermal_core.c | 28 ++++ > include/linux/thermal.h | 6 + > 4 files changed, 214 insertions(+), 65 deletions(-) > > -- > 1.9.1 >