From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753094AbbFSCOl (ORCPT ); Thu, 18 Jun 2015 22:14:41 -0400 Received: from mail-pd0-f176.google.com ([209.85.192.176]:34911 "EHLO mail-pd0-f176.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751926AbbFSCOd (ORCPT ); Thu, 18 Jun 2015 22:14:33 -0400 MIME-Version: 1.0 Reply-To: cw00.choi@samsung.com In-Reply-To: <1434638631-16451-2-git-send-email-ckeepax@opensource.wolfsonmicro.com> References: <1434638631-16451-1-git-send-email-ckeepax@opensource.wolfsonmicro.com> <1434638631-16451-2-git-send-email-ckeepax@opensource.wolfsonmicro.com> Date: Fri, 19 Jun 2015 11:14:33 +0900 Message-ID: Subject: Re: [PATCH v2 1/5] extcon: arizona: Update to use the new device properties API From: Chanwoo Choi To: Charles Keepax Cc: Lee Jones , "myungjoo.ham@samsung.com" , Samuel Ortiz , devicetree , linux-kernel , patches@opensource.wolfsonmicro.com Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Charles, Looks good to me about this patch. But I add one comment. On Thu, Jun 18, 2015 at 11:43 PM, Charles Keepax wrote: > The device properties API will load data from both device tree and ACPI, > update the binding to use this API instead of the OF API. > > Signed-off-by: Charles Keepax > --- > drivers/extcon/extcon-arizona.c | 7 ++++--- > 1 files changed, 4 insertions(+), 3 deletions(-) > > diff --git a/drivers/extcon/extcon-arizona.c b/drivers/extcon/extcon-arizona.c > index 9262b45..1153929 100644 > --- a/drivers/extcon/extcon-arizona.c > +++ b/drivers/extcon/extcon-arizona.c > @@ -24,6 +24,7 @@ > #include > #include > #include > +#include > #include > #include > > @@ -1110,12 +1111,12 @@ static void arizona_micd_set_level(struct arizona *arizona, int index, > regmap_update_bits(arizona->regmap, reg, mask, level); > } > > -static int arizona_extcon_of_get_pdata(struct arizona *arizona) > +static int arizona_extcon_device_get_pdata(struct arizona *arizona) > { > struct arizona_pdata *pdata = &arizona->pdata; > unsigned int val = ARIZONA_ACCDET_MODE_HPL; > > - of_property_read_u32(arizona->dev->of_node, "wlf,hpdet-channel", &val); > + device_property_read_u32(arizona->dev, "wlf,hpdet-channel", &val); > switch (val) { > case ARIZONA_ACCDET_MODE_HPL: > case ARIZONA_ACCDET_MODE_HPR: > @@ -1149,7 +1150,7 @@ static int arizona_extcon_probe(struct platform_device *pdev) > > if (IS_ENABLED(CONFIG_OF)) { If you remain the upper if statement, I think "device_property_read_u32" function cannot get the data from ACPI. I think that you can remove upper if statement of "CONFIG_OF". > if (!dev_get_platdata(arizona->dev)) > - arizona_extcon_of_get_pdata(arizona); > + arizona_extcon_device_get_pdata(arizona); > } > > info->micvdd = devm_regulator_get(&pdev->dev, "MICVDD"); Thanks, Chanwoo Choi From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chanwoo Choi Subject: Re: [PATCH v2 1/5] extcon: arizona: Update to use the new device properties API Date: Fri, 19 Jun 2015 11:14:33 +0900 Message-ID: References: <1434638631-16451-1-git-send-email-ckeepax@opensource.wolfsonmicro.com> <1434638631-16451-2-git-send-email-ckeepax@opensource.wolfsonmicro.com> Reply-To: cw00.choi-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Return-path: In-Reply-To: <1434638631-16451-2-git-send-email-ckeepax-yzvPICuk2AATkU/dhu1WVueM+bqZidxxQQ4Iyu8u01E@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Charles Keepax Cc: Lee Jones , "myungjoo.ham-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org" , Samuel Ortiz , devicetree , linux-kernel , patches-yzvPICuk2AATkU/dhu1WVueM+bqZidxxQQ4Iyu8u01E@public.gmane.org List-Id: devicetree@vger.kernel.org Hi Charles, Looks good to me about this patch. But I add one comment. On Thu, Jun 18, 2015 at 11:43 PM, Charles Keepax wrote: > The device properties API will load data from both device tree and ACPI, > update the binding to use this API instead of the OF API. > > Signed-off-by: Charles Keepax > --- > drivers/extcon/extcon-arizona.c | 7 ++++--- > 1 files changed, 4 insertions(+), 3 deletions(-) > > diff --git a/drivers/extcon/extcon-arizona.c b/drivers/extcon/extcon-arizona.c > index 9262b45..1153929 100644 > --- a/drivers/extcon/extcon-arizona.c > +++ b/drivers/extcon/extcon-arizona.c > @@ -24,6 +24,7 @@ > #include > #include > #include > +#include > #include > #include > > @@ -1110,12 +1111,12 @@ static void arizona_micd_set_level(struct arizona *arizona, int index, > regmap_update_bits(arizona->regmap, reg, mask, level); > } > > -static int arizona_extcon_of_get_pdata(struct arizona *arizona) > +static int arizona_extcon_device_get_pdata(struct arizona *arizona) > { > struct arizona_pdata *pdata = &arizona->pdata; > unsigned int val = ARIZONA_ACCDET_MODE_HPL; > > - of_property_read_u32(arizona->dev->of_node, "wlf,hpdet-channel", &val); > + device_property_read_u32(arizona->dev, "wlf,hpdet-channel", &val); > switch (val) { > case ARIZONA_ACCDET_MODE_HPL: > case ARIZONA_ACCDET_MODE_HPR: > @@ -1149,7 +1150,7 @@ static int arizona_extcon_probe(struct platform_device *pdev) > > if (IS_ENABLED(CONFIG_OF)) { If you remain the upper if statement, I think "device_property_read_u32" function cannot get the data from ACPI. I think that you can remove upper if statement of "CONFIG_OF". > if (!dev_get_platdata(arizona->dev)) > - arizona_extcon_of_get_pdata(arizona); > + arizona_extcon_device_get_pdata(arizona); > } > > info->micvdd = devm_regulator_get(&pdev->dev, "MICVDD"); Thanks, Chanwoo Choi -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html