From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754576AbbFSIj2 (ORCPT ); Fri, 19 Jun 2015 04:39:28 -0400 Received: from mail-ie0-f179.google.com ([209.85.223.179]:33260 "EHLO mail-ie0-f179.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753863AbbFSIjW (ORCPT ); Fri, 19 Jun 2015 04:39:22 -0400 MIME-Version: 1.0 Reply-To: cw00.choi@samsung.com In-Reply-To: <20150619081433.GR32730@opensource.wolfsonmicro.com> References: <1434638631-16451-1-git-send-email-ckeepax@opensource.wolfsonmicro.com> <1434638631-16451-4-git-send-email-ckeepax@opensource.wolfsonmicro.com> <20150619081433.GR32730@opensource.wolfsonmicro.com> Date: Fri, 19 Jun 2015 17:39:22 +0900 Message-ID: Subject: Re: [PATCH v2 3/5] extcon: arizona: Convert to gpiod From: Chanwoo Choi To: Charles Keepax Cc: Lee Jones , "myungjoo.ham@samsung.com" , Samuel Ortiz , devicetree , linux-kernel , patches@opensource.wolfsonmicro.com Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jun 19, 2015 at 5:14 PM, Charles Keepax wrote: > On Fri, Jun 19, 2015 at 11:36:47AM +0900, Chanwoo Choi wrote: >> Hi Charles, >> >> On Thu, Jun 18, 2015 at 11:43 PM, Charles Keepax >> wrote: >> > Convert to using the newer gpiod interface for the micd_pol_gpio. >> > Although we still carry support for the old gpio interface from pdata. >> > >> > Signed-off-by: Charles Keepax >> > --- >> > + mode = GPIOD_OUT_HIGH; >> > + else >> > + mode = GPIOD_OUT_LOW; >> > + >> > + info->micd_pol_gpio = gpiod_get_optional(arizona->dev, >> > + "wlf,micd-pol", >> > + GPIOD_OUT_LOW); >> >> You can use the devm_gpiod_get_optional() to manage the system >> resource automatically. >> > > We can't actually use the devm call here, we need to pass > arizona->dev as that is where the DT will reside, which is the > device for the MFD. But if the devm is attached to the device for > the MFD then it will not clear up when the extcon driver is > unloaded. As such we have to do the put manually. > > I will look at respinning for the other comments. I don't understand. extcon-arizona.c used already following devm_* functions: - devm_kzalloc() - devm_regulator_get() - devm_extcon_dev_*() - devm_input_allocate_device() - devm_gpio_request_one() Thanks, Chanwoo Choi From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chanwoo Choi Subject: Re: [PATCH v2 3/5] extcon: arizona: Convert to gpiod Date: Fri, 19 Jun 2015 17:39:22 +0900 Message-ID: References: <1434638631-16451-1-git-send-email-ckeepax@opensource.wolfsonmicro.com> <1434638631-16451-4-git-send-email-ckeepax@opensource.wolfsonmicro.com> <20150619081433.GR32730@opensource.wolfsonmicro.com> Reply-To: cw00.choi-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Return-path: In-Reply-To: <20150619081433.GR32730-yzvPICuk2AATkU/dhu1WVueM+bqZidxxQQ4Iyu8u01E@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Charles Keepax Cc: Lee Jones , "myungjoo.ham-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org" , Samuel Ortiz , devicetree , linux-kernel , patches-yzvPICuk2AATkU/dhu1WVueM+bqZidxxQQ4Iyu8u01E@public.gmane.org List-Id: devicetree@vger.kernel.org On Fri, Jun 19, 2015 at 5:14 PM, Charles Keepax wrote: > On Fri, Jun 19, 2015 at 11:36:47AM +0900, Chanwoo Choi wrote: >> Hi Charles, >> >> On Thu, Jun 18, 2015 at 11:43 PM, Charles Keepax >> wrote: >> > Convert to using the newer gpiod interface for the micd_pol_gpio. >> > Although we still carry support for the old gpio interface from pdata. >> > >> > Signed-off-by: Charles Keepax >> > --- >> > + mode = GPIOD_OUT_HIGH; >> > + else >> > + mode = GPIOD_OUT_LOW; >> > + >> > + info->micd_pol_gpio = gpiod_get_optional(arizona->dev, >> > + "wlf,micd-pol", >> > + GPIOD_OUT_LOW); >> >> You can use the devm_gpiod_get_optional() to manage the system >> resource automatically. >> > > We can't actually use the devm call here, we need to pass > arizona->dev as that is where the DT will reside, which is the > device for the MFD. But if the devm is attached to the device for > the MFD then it will not clear up when the extcon driver is > unloaded. As such we have to do the put manually. > > I will look at respinning for the other comments. I don't understand. extcon-arizona.c used already following devm_* functions: - devm_kzalloc() - devm_regulator_get() - devm_extcon_dev_*() - devm_input_allocate_device() - devm_gpio_request_one() Thanks, Chanwoo Choi -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html