From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 86C3DC433B4 for ; Mon, 19 Apr 2021 03:17:36 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6B22F61077 for ; Mon, 19 Apr 2021 03:17:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237417AbhDSDSD (ORCPT ); Sun, 18 Apr 2021 23:18:03 -0400 Received: from mail-lj1-f180.google.com ([209.85.208.180]:35371 "EHLO mail-lj1-f180.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237406AbhDSDSB (ORCPT ); Sun, 18 Apr 2021 23:18:01 -0400 Received: by mail-lj1-f180.google.com with SMTP id a1so37678275ljp.2; Sun, 18 Apr 2021 20:17:31 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:reply-to :from:date:message-id:subject:to:cc; bh=b1Esi1WD3INsXc8Mpz0AJivayvHJYCQXopFXhNta98w=; b=SwP6qdDfULNgiFhCReun5MFiKaUhBiFxL61WvF0I2F3onHcpUglftWCVGcIlTnrA2P ZuyDNJawkATYMnfYearmEjtNtJAcwu03Il1QdSw8zNODvHelC0Z25jvwCZt1CUmPWS8L /QC0IH88XHvW4Qeb7mEgu91vYWTA+bNxzXjI4nyhFNaEQRtqX2RK7Wp9UzpZpt9JfSh3 ho5RC6A4gkzWNHA4PMJhkkvqvxLqC3+ODFtW7r5FzJthEboOYGxIkI38uTDrC1NW4Ifm 1GNntD/FfLaBKGlNTkDpItr0s63k7c6BiIuxTB7gb8MbFjtUtATwmJSyLFiLFFQTN1R7 dT6w== X-Gm-Message-State: AOAM532vmh2Q7XZ1tNrvx3ygJpRMFwYi027kOqO+PYO4qsVEp2pAyZtY oOyDVGYcNX1i6Z+x4xebY7GPVk2HgersdQ== X-Google-Smtp-Source: ABdhPJw/RqNKojJfu3DeiCIkYZ+LkTRMGTrzf+il+R/vQVf6hnz9t5/JKTZm2Cvutf+Is5ahVNPzug== X-Received: by 2002:a2e:804d:: with SMTP id p13mr9994910ljg.267.1618802250357; Sun, 18 Apr 2021 20:17:30 -0700 (PDT) Received: from mail-lf1-f44.google.com (mail-lf1-f44.google.com. [209.85.167.44]) by smtp.gmail.com with ESMTPSA id a25sm1720590ljm.130.2021.04.18.20.17.29 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 18 Apr 2021 20:17:30 -0700 (PDT) Received: by mail-lf1-f44.google.com with SMTP id f17so46630103lfu.7; Sun, 18 Apr 2021 20:17:29 -0700 (PDT) X-Received: by 2002:a05:6512:3e0a:: with SMTP id i10mr10803227lfv.496.1618802249832; Sun, 18 Apr 2021 20:17:29 -0700 (PDT) MIME-Version: 1.0 References: <20210419025246.21722-1-samuel@sholland.org> In-Reply-To: <20210419025246.21722-1-samuel@sholland.org> Reply-To: wens@csie.org From: Chen-Yu Tsai Date: Mon, 19 Apr 2021 11:17:19 +0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 0/2] sunxi: Enforce consistent MMC numbering To: Samuel Holland Cc: Maxime Ripard , Jernej Skrabec , devicetree , linux-arm-kernel , linux-sunxi@lists.linux.dev, linux-kernel Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On Mon, Apr 19, 2021 at 10:52 AM Samuel Holland wrote: > > Dealing with the inconsistent numbering has been a major pain, and > there is a solution with (as far as I can tell) no tangible downsides. > So let's use it. > > Yes, I know the kernel supports UUIDs for root=. But UUIDs do not help > when referencing the whole, unpartitioned device, like is needed for > updating the bootloader and firmware. So for the use case of "write a > bootloader to the SD card, regardless of where the board is currently > booted from", I know of two options: > - Dig around in sysfs to find the mmc number from the MMIO address, > which means I have to know the MMIO addresses for every SoC, or > - Apply patches like these. > > Samuel Holland (2): > ARM: dts: sunxi: h3/h5: Enforce consistent MMC numbering > arm64: dts: allwinner: Enforce consistent MMC numbering > > arch/arm/boot/dts/sunxi-h3-h5.dtsi | 6 ++++++ > arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi | 6 ++++++ > arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi | 6 ++++++ At least with Rockchip this is now done at the board level. IIRC it was a request from other people to not do it at the SoC level. I don't recall exactly who though. ChenYu > 3 files changed, 18 insertions(+) > > -- > 2.26.3 > > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C6C6CC433B4 for ; Mon, 19 Apr 2021 03:19:36 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4095B61077 for ; Mon, 19 Apr 2021 03:19:36 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4095B61077 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=csie.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:Reply-To:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From:In-Reply-To: References:MIME-Version:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=HX96dY7JVyGAlKbDSKWMB9tmbkO+Z5Glfj5M59K2YcY=; b=gaPA6L1J1VNtlw6IfBtO4GQXq 0VA/ljzbE0uUItvasrOQ9D+Spnn4cdb6dzn5SRfqwy+2e/09B6ns20AwA2/K8MfmikWwMmOzpZkUL 6k+i8bk09Y6weduYnKnn4YtCTBu+DF9vgTRMAiNWmvWNy7hgxpv3Ite/oQgmjlKzR6LlKtQZW7R0v jQyVyRYezx9P+sHdxG6+g+8eCKG9OkKjIUqsA5e3wPaYbHanEkK0xnT6VICrj/jj+lM0kVPt7nxeX vYUEpZAcHvrKNyOtkq9tGN9CLbrM1DDWipAsYNUBJJ+kRUSUeZrD1HoUQx0HCJN8zzqcmdmb21HGE IOmOprTbQ==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lYKPt-008zcw-2p; Mon, 19 Apr 2021 03:17:41 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lYKPp-008zcp-RC for linux-arm-kernel@desiato.infradead.org; Mon, 19 Apr 2021 03:17:38 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Type:Cc:To:Subject:Message-ID :Date:From:Reply-To:In-Reply-To:References:MIME-Version:Sender: Content-Transfer-Encoding:Content-ID:Content-Description; bh=b1Esi1WD3INsXc8Mpz0AJivayvHJYCQXopFXhNta98w=; b=rM2LBLt+3uvTQvkIXRxuWOvFfd j4XjwflaOWUNz7gdJ2u6Wej05nMqD7xJU8U+ibHYxB4BwJiPwWlXYhbdIMgZEbGc8KtOqwWpK7eG6 oYDUE/2ykcYUFX5OdU1k1p4AMkLyFKgeumaBEQhO6Rp68rJ+xNdbEj8yWs34bvh7ym6ohDyDeJO2i baDfY3Dwx5WKcj7uIQ6PXYFUxFTINw0pf7exKKp892+ghPrAh8NXIZi8o/Gx3iApBTbTzua6K9mDJ Z9NhL/2W4KpeiWSZ9NWcuVaLUypkqc2x/x/2Q2K0a66cej3eQ6pDHZJzXggHxZIqPyLZbROAPAiVz kTUm13JQ==; Received: from mail-lj1-f180.google.com ([209.85.208.180]) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lYKPj-00Auy9-Vw for linux-arm-kernel@lists.infradead.org; Mon, 19 Apr 2021 03:17:36 +0000 Received: by mail-lj1-f180.google.com with SMTP id c1so29395502ljd.7 for ; Sun, 18 Apr 2021 20:17:31 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:reply-to :from:date:message-id:subject:to:cc; bh=b1Esi1WD3INsXc8Mpz0AJivayvHJYCQXopFXhNta98w=; b=uk5FU7eNRKkfPWXX2trkyF/JLV5qlcLKqz1fmi/FdIU3YKcnCdwvYQa9brt5EALsqG T7dGyaiKH9u2ForEJNJMXPWr8R5prsnOQP+GObNyo94+Jeg9X2bbY65dUUVVaOXAl1by qllRNXgk5pYVNfDN//y0Vw2vS39FsKnQ7GWl/v5ZjBHOYk/z/p96kXLuZZ6YaOnVTMAa EwKn2KS1rwFUM0k0MwIpdhopNA6V0NpzEfbw4mPZMr2jHAKVssi+Ew8kQEP7YID9YdA7 Gt0tKmab5kFAgtoMZoGpw9kx0bpsv0WGxE4RcjdlOH8/k7tAyYBc1rJ+rCJ/L8uNNh1t KEeg== X-Gm-Message-State: AOAM533ZhCaVgL1BgTgy8/0Dnk9Ms+2htEwzNwgcNhE2Bt8Q5EiVfXh7 iXeZS2R169fU2SSO1wgtv5Mm3Ij7hXZ1DA== X-Google-Smtp-Source: ABdhPJw9oyhppgVQ/+zq2Eix89oCBD6Pi27CemNnRIHf8cLTn4wU+UdcgXTvFmVC9bTptu3MVrdZ2g== X-Received: by 2002:a2e:b530:: with SMTP id z16mr10084312ljm.111.1618802250137; Sun, 18 Apr 2021 20:17:30 -0700 (PDT) Received: from mail-lf1-f53.google.com (mail-lf1-f53.google.com. [209.85.167.53]) by smtp.gmail.com with ESMTPSA id e29sm1717036ljp.94.2021.04.18.20.17.29 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 18 Apr 2021 20:17:30 -0700 (PDT) Received: by mail-lf1-f53.google.com with SMTP id y4so13506746lfl.10 for ; Sun, 18 Apr 2021 20:17:29 -0700 (PDT) X-Received: by 2002:a05:6512:3e0a:: with SMTP id i10mr10803227lfv.496.1618802249832; Sun, 18 Apr 2021 20:17:29 -0700 (PDT) MIME-Version: 1.0 References: <20210419025246.21722-1-samuel@sholland.org> In-Reply-To: <20210419025246.21722-1-samuel@sholland.org> From: Chen-Yu Tsai Date: Mon, 19 Apr 2021 11:17:19 +0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 0/2] sunxi: Enforce consistent MMC numbering To: Samuel Holland Cc: Maxime Ripard , Jernej Skrabec , devicetree , linux-arm-kernel , linux-sunxi@lists.linux.dev, linux-kernel X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210418_201732_046277_985A7727 X-CRM114-Status: GOOD ( 18.63 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: wens@csie.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi, On Mon, Apr 19, 2021 at 10:52 AM Samuel Holland wrote: > > Dealing with the inconsistent numbering has been a major pain, and > there is a solution with (as far as I can tell) no tangible downsides. > So let's use it. > > Yes, I know the kernel supports UUIDs for root=. But UUIDs do not help > when referencing the whole, unpartitioned device, like is needed for > updating the bootloader and firmware. So for the use case of "write a > bootloader to the SD card, regardless of where the board is currently > booted from", I know of two options: > - Dig around in sysfs to find the mmc number from the MMIO address, > which means I have to know the MMIO addresses for every SoC, or > - Apply patches like these. > > Samuel Holland (2): > ARM: dts: sunxi: h3/h5: Enforce consistent MMC numbering > arm64: dts: allwinner: Enforce consistent MMC numbering > > arch/arm/boot/dts/sunxi-h3-h5.dtsi | 6 ++++++ > arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi | 6 ++++++ > arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi | 6 ++++++ At least with Rockchip this is now done at the board level. IIRC it was a request from other people to not do it at the SoC level. I don't recall exactly who though. ChenYu > 3 files changed, 18 insertions(+) > > -- > 2.26.3 > > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel