On Thu, Mar 11, 2021 at 7:50 PM Rong Chen <rong.a.chen@intel.com> wrote:
>
>
> The issue is from a=!, and [ "$a $b" = ".size .LPBX0," ] can avoid the
> error.
>
> + [ ! = .size -a ABI = .LPBX0, ]
> ./kernel/gcov/geninfosize.sh: 13: [: =: unexpected operator

But that's not what the patch did.

The patch used quotes around $a, so "$a" should still be fine.

See:

   [torvalds@ryzen ~]$ a="!" [ "$a" = ".size" ]

is fine, but

   [torvalds@ryzen ~]$ a="!" [ $a = ".size" ]
   -bash: [: =: unary operator expected

and the patch I saw, and that the test robot replied to, had that
correct quoting, afaik.

So I still don't see what the test robot is complaining about. Was
there an earlier version of the patch without the quotes that I didn't
see?

Or is the shell on the test robot doing something really really odd,
and it's somehow nds32-specific?

                Linus