From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: Matti Vaittinen <matti.vaittinen@fi.rohmeurope.com>
Cc: Matti Vaittinen <mazziesaccount@gmail.com>,
Linus Walleij <linus.walleij@linaro.org>,
Bartosz Golaszewski <bgolaszewski@baylibre.com>,
Michael Walle <michael@walle.cc>,
"open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
linux-power <linux-power@fi.rohmeurope.com>
Subject: Re: [PATCH v2 2/3] gpio: gpio-regmap: Use devm_add_action()
Date: Fri, 21 May 2021 13:10:39 +0300 [thread overview]
Message-ID: <CAHp75VfgQw09KJ5pMNz7fnia-pzK8sMGKn6NJkmNEWLzo5GffA@mail.gmail.com> (raw)
In-Reply-To: <e3d3e704804668d1403f3630c181010b34409c8f.1621577204.git.matti.vaittinen@fi.rohmeurope.com>
On Fri, May 21, 2021 at 12:54 PM Matti Vaittinen
<matti.vaittinen@fi.rohmeurope.com> wrote:
>
> Slightly simplify the devm_gpio_regmap_register() by using the
> devm_add_action().
Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>
> Signed-off-by: Matti Vaittinen <matti.vaittinen@fi.rohmeurope.com>
> ---
> Changelog:
> - New patch at v2
>
> drivers/gpio/gpio-regmap.c | 20 ++++++--------------
> 1 file changed, 6 insertions(+), 14 deletions(-)
>
> diff --git a/drivers/gpio/gpio-regmap.c b/drivers/gpio/gpio-regmap.c
> index c05370e984b9..4555e59f916e 100644
> --- a/drivers/gpio/gpio-regmap.c
> +++ b/drivers/gpio/gpio-regmap.c
> @@ -341,9 +341,9 @@ void gpio_regmap_unregister(struct gpio_regmap *gpio)
> }
> EXPORT_SYMBOL_GPL(gpio_regmap_unregister);
>
> -static void devm_gpio_regmap_unregister(struct device *dev, void *res)
> +static void devm_gpio_regmap_unregister(void *res)
> {
> - gpio_regmap_unregister(*(struct gpio_regmap **)res);
> + gpio_regmap_unregister(res);
> }
>
> /**
> @@ -360,20 +360,12 @@ static void devm_gpio_regmap_unregister(struct device *dev, void *res)
> struct gpio_regmap *devm_gpio_regmap_register(struct device *dev,
> const struct gpio_regmap_config *config)
> {
> - struct gpio_regmap **ptr, *gpio;
> -
> - ptr = devres_alloc(devm_gpio_regmap_unregister, sizeof(*ptr),
> - GFP_KERNEL);
> - if (!ptr)
> - return ERR_PTR(-ENOMEM);
> + struct gpio_regmap *gpio;
>
> gpio = gpio_regmap_register(config);
> - if (!IS_ERR(gpio)) {
> - *ptr = gpio;
> - devres_add(dev, ptr);
> - } else {
> - devres_free(ptr);
> - }
> +
> + if (!IS_ERR(gpio))
> + devm_add_action(dev, devm_gpio_regmap_unregister, gpio);
>
> return gpio;
> }
> --
> 2.25.4
>
>
> --
> Matti Vaittinen, Linux device drivers
> ROHM Semiconductors, Finland SWDC
> Kiviharjunlenkki 1E
> 90220 OULU
> FINLAND
>
> ~~~ "I don't think so," said Rene Descartes. Just then he vanished ~~~
> Simon says - in Latin please.
> ~~~ "non cogito me" dixit Rene Descarte, deinde evanescavit ~~~
> Thanks to Simon Glass for the translation =]
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2021-05-21 10:11 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-21 6:27 [PATCH v2 0/3] gpio: gpio-regmap: Support few custom operations Matti Vaittinen
2021-05-21 6:27 ` [PATCH v2 1/3] gpio: regmap: Support few IC specific operations Matti Vaittinen
2021-05-21 8:04 ` Michael Walle
2021-05-21 10:09 ` Andy Shevchenko
2021-05-21 10:19 ` Michael Walle
2021-05-21 10:25 ` Vaittinen, Matti
2021-05-21 10:46 ` Michael Walle
2021-05-21 11:36 ` Vaittinen, Matti
2021-05-21 11:19 ` Andy Shevchenko
2021-05-21 11:41 ` Vaittinen, Matti
2021-05-21 10:20 ` Vaittinen, Matti
2021-05-21 6:28 ` [PATCH v2 2/3] gpio: gpio-regmap: Use devm_add_action() Matti Vaittinen
2021-05-21 8:10 ` Michael Walle
2021-05-21 8:38 ` Bjørn Mork
2021-05-21 10:30 ` Vaittinen, Matti
2021-05-21 16:35 ` Bartosz Golaszewski
2021-05-24 5:01 ` Vaittinen, Matti
2021-05-21 10:10 ` Andy Shevchenko [this message]
2021-05-21 6:29 ` [PATCH v2 3/3] gpio: bd71815: Use gpio-regmap Matti Vaittinen
2021-05-21 10:12 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAHp75VfgQw09KJ5pMNz7fnia-pzK8sMGKn6NJkmNEWLzo5GffA@mail.gmail.com \
--to=andy.shevchenko@gmail.com \
--cc=bgolaszewski@baylibre.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-power@fi.rohmeurope.com \
--cc=matti.vaittinen@fi.rohmeurope.com \
--cc=mazziesaccount@gmail.com \
--cc=michael@walle.cc \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.