From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 60732C433FE for ; Fri, 14 Jan 2022 09:46:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240109AbiANJqp (ORCPT ); Fri, 14 Jan 2022 04:46:45 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42180 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229785AbiANJqn (ORCPT ); Fri, 14 Jan 2022 04:46:43 -0500 Received: from mail-ed1-x52a.google.com (mail-ed1-x52a.google.com [IPv6:2a00:1450:4864:20::52a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 82164C061574; Fri, 14 Jan 2022 01:46:42 -0800 (PST) Received: by mail-ed1-x52a.google.com with SMTP id w16so32887652edc.11; Fri, 14 Jan 2022 01:46:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=CJJp16XvB61zfc0mom+YXoBX1NkRJX5jIJ0wUN6p1U0=; b=DhWFS7DBWVC9oy5m12HFDmTQeONzXzS+zL/UkUxZalJkNH/8NTPPTSNlnU06nDAHt0 znpDfJ29q87pyu4RjOtpr+kin+3J/4ntdU8d3+f2PBkIWuiNZ/5hpjSwvGRLeUnN+5wk 4cMvbeU2a9wWayuIjx06Ujbv20e03VL4l1L7up31bxUikQy/+6Ebu6L6VmeR8dXYHgu8 7ab61znWeEXnV4m0bdQV5RM1STerrRJC7AlVEDaVIhZdpnf3HdQmLXFg8MkTaWd068HA I68m62yvV81rt1lT3T0Hb/Uu/M0t3EUUpw2dvXZ8rQoZETrrnXie67It6Ppv9eclH4OG bTjQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=CJJp16XvB61zfc0mom+YXoBX1NkRJX5jIJ0wUN6p1U0=; b=pBbemh4XDePsPWkESc6KzuClvfRQGfNAAuxaBV6WndlVH0/1SHAaIFLAeKETEjV4C7 NfxdRNqqAJryHC+sWrvu60/pz+6pP8ubkebX4yK3rh+jkwzG/uCC2fSFDD+za+hbYjlU NZa79RxjewyGwhXFqlMOu9BRLVphl3oiW8cLRP07QBvKASzTSqr4fb2VXU9KyVNPeDDM 4NG6N05cE3/eePWfJkgppVd3pNXVPIUW7BMa2ptxpRS1nRXssyn8IPFmIGU+RuLTpjg6 /zuvvi+6Ttc4Whekb/v92ze5LV+/QENeL0YCAEQcanAVKjXtT5AyImOvRGhvL65OVRUN rVOQ== X-Gm-Message-State: AOAM5336l1kLB/4tdHmx/eJIY23K/9a8U9zwCxb0Rz/jE1Wfmid4KASA BWKfL4Icym8XoXIcuQDIKQJ1G2UYX+gL4wWMU3FzQKhOPEeBvw== X-Google-Smtp-Source: ABdhPJytF5xROs6L3+siWxigPjNg2rtNknZ0aH9Q1UXnb4ama7jR03TaPtwF3/UCEXq4+xOHXhGxPAf/B+C7h5R+6mE= X-Received: by 2002:a17:906:3ed0:: with SMTP id d16mr6659456ejj.636.1642153601100; Fri, 14 Jan 2022 01:46:41 -0800 (PST) MIME-Version: 1.0 References: <1640331779-18277-1-git-send-email-wellslutw@gmail.com> <1640331779-18277-3-git-send-email-wellslutw@gmail.com> <9e15ccc8ee844f1eab320001bc8bc235@sphcmbx02.sunplus.com.tw> In-Reply-To: <9e15ccc8ee844f1eab320001bc8bc235@sphcmbx02.sunplus.com.tw> From: Andy Shevchenko Date: Fri, 14 Jan 2022 11:46:04 +0200 Message-ID: Subject: Re: [PATCH v5 2/2] pinctrl: Add driver for Sunplus SP7021 To: =?UTF-8?B?V2VsbHMgTHUg5ZGC6Iqz6aiw?= Cc: Wells Lu , Linus Walleij , "open list:GPIO SUBSYSTEM" , Linux Kernel Mailing List , Rob Herring , devicetree , linux-arm Mailing List , "dvorkin@tibbo.com" Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jan 14, 2022 at 4:51 AM Wells Lu =E5=91=82=E8=8A=B3=E9=A8=B0 wrote: ... > > > > > > > + bool "Sunplus SP7021 PinMux and GPIO driver" > > > > > > > > > > > > Why bool and not tristate? > > > > > > > > > > Pinctrl driver is selected by many drivers in SP7021 platform. > > > > > We never build it as a module, but build-in to kernel. > > > > > So we use "bool". > > > > > > > > > > Should we set it to tristate? > > > > > > > > You still haven't answered "why", so I can't tell you. > > > > > > I am puzzled because I think I have answered "why". > > > > Nope. :-) > > > > > Because Pinctrl driver is necessary for all SP7021-based platforms. > > > > "Why?" Why is it necessary (to be built-in)? > > Pinctrl is necessary to be built-in because drivers of boot-device, > like eMMC, SD card, NAND flash, and NOR flash drivers, need it. > > SP7021 supports booting from eMMC, SD card, NAND flash and NOR flash > devices. Their drivers need Pinctrl driver probes in advance. On x86 platforms, for example, booting from eMMC and SD card does not require a pin control driver to be built-in. Why is this requirement for SP platforms? --=20 With Best Regards, Andy Shevchenko From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 54FDBC433F5 for ; Fri, 14 Jan 2022 09:48:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=MPB/PvAdwC47l6Cz5PSGlrRzJBUMdmWdYDSiI5HzxYs=; b=ZLGWQJvGKsSOvd u5K90gid7nEh14BtwUAZUcbE0vypkIa2EGndgjbdpbnJg1pVGwYza1W6IzkxH8eYD9/g/duYd5jx3 EKNRhLm/KFfNAD0h9j6rJD9uDLUBxhoGaIHn6gYoZmClqGgZDWyosmuYjZdK8RqrVNagDz2xnBklD D8CzucZZdKjgKYeMmokrpXbs+ETiaA4RRaVsT2g/dGw2chQhb052kedC24z677pzs6RdJ08uasYsp ekhLVsoY+0p0R2u6onSYbZ5Hs6pk9Gv7fpWpA0YJIXbblaK6hfZ4x83ro/K+g+HvdLirVfmulpBCL 4fbWiOJnLEkR+sCg1TZw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1n8JAV-008aFj-Oa; Fri, 14 Jan 2022 09:46:47 +0000 Received: from mail-ed1-x534.google.com ([2a00:1450:4864:20::534]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1n8JAR-008aDQ-0Z for linux-arm-kernel@lists.infradead.org; Fri, 14 Jan 2022 09:46:45 +0000 Received: by mail-ed1-x534.google.com with SMTP id t24so32890966edi.8 for ; Fri, 14 Jan 2022 01:46:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=CJJp16XvB61zfc0mom+YXoBX1NkRJX5jIJ0wUN6p1U0=; b=DhWFS7DBWVC9oy5m12HFDmTQeONzXzS+zL/UkUxZalJkNH/8NTPPTSNlnU06nDAHt0 znpDfJ29q87pyu4RjOtpr+kin+3J/4ntdU8d3+f2PBkIWuiNZ/5hpjSwvGRLeUnN+5wk 4cMvbeU2a9wWayuIjx06Ujbv20e03VL4l1L7up31bxUikQy/+6Ebu6L6VmeR8dXYHgu8 7ab61znWeEXnV4m0bdQV5RM1STerrRJC7AlVEDaVIhZdpnf3HdQmLXFg8MkTaWd068HA I68m62yvV81rt1lT3T0Hb/Uu/M0t3EUUpw2dvXZ8rQoZETrrnXie67It6Ppv9eclH4OG bTjQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=CJJp16XvB61zfc0mom+YXoBX1NkRJX5jIJ0wUN6p1U0=; b=zlSWZ97Lv/u1q7mVhTZSqC+azl8u80oYukqgsfu7/X/7OKSZTVyfPzHPnfonJ4Vy8B l/QccN6Zx92DT5HVaJaJDzAgTEKVjYt/YNoMxiBnVedkacXu7S9eSpCiAE+o/s+0qe9z Qe4hZlXpjb+lmY6KNrrysHuIB9xLcHQ9GosaDMu/7F2vUsQPGzbPtFVnCpHzBx3WBUJ0 B6aYpNC9E9bvZn1Cr+la7IoS9CsVWZApRdepmIjDOWGKCF0kZ2sEKQ4W+yus5fD4aXRz sgGap2MNKsLwvboL5NP7P4bkaoFK0HiBCg1kf6fiPkdMo5YuQ76w35hgrjT1G9qeH5lp EdIQ== X-Gm-Message-State: AOAM533ErVqbPTPlm4SceObiLemt7A2Lw0iQBycZy5r76Ok96y2HBfXn m6tiI4zBB3BLWutnM5DT4vS0hXEiqhD9qc8Cj04= X-Google-Smtp-Source: ABdhPJytF5xROs6L3+siWxigPjNg2rtNknZ0aH9Q1UXnb4ama7jR03TaPtwF3/UCEXq4+xOHXhGxPAf/B+C7h5R+6mE= X-Received: by 2002:a17:906:3ed0:: with SMTP id d16mr6659456ejj.636.1642153601100; Fri, 14 Jan 2022 01:46:41 -0800 (PST) MIME-Version: 1.0 References: <1640331779-18277-1-git-send-email-wellslutw@gmail.com> <1640331779-18277-3-git-send-email-wellslutw@gmail.com> <9e15ccc8ee844f1eab320001bc8bc235@sphcmbx02.sunplus.com.tw> In-Reply-To: <9e15ccc8ee844f1eab320001bc8bc235@sphcmbx02.sunplus.com.tw> From: Andy Shevchenko Date: Fri, 14 Jan 2022 11:46:04 +0200 Message-ID: Subject: Re: [PATCH v5 2/2] pinctrl: Add driver for Sunplus SP7021 To: =?UTF-8?B?V2VsbHMgTHUg5ZGC6Iqz6aiw?= Cc: Wells Lu , Linus Walleij , "open list:GPIO SUBSYSTEM" , Linux Kernel Mailing List , Rob Herring , devicetree , linux-arm Mailing List , "dvorkin@tibbo.com" X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220114_014643_111028_774BFCF6 X-CRM114-Status: GOOD ( 19.35 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gRnJpLCBKYW4gMTQsIDIwMjIgYXQgNDo1MSBBTSBXZWxscyBMdSDlkYLoirPpqLAgPHdlbGxz Lmx1QHN1bnBsdXMuY29tPiB3cm90ZToKCi4uLgoKPiA+ID4gPiA+ID4gPiArICAgICAgIGJvb2wg IlN1bnBsdXMgU1A3MDIxIFBpbk11eCBhbmQgR1BJTyBkcml2ZXIiCj4gPiA+ID4gPiA+Cj4gPiA+ ID4gPiA+IFdoeSBib29sIGFuZCBub3QgdHJpc3RhdGU/Cj4gPiA+ID4gPgo+ID4gPiA+ID4gUGlu Y3RybCBkcml2ZXIgaXMgc2VsZWN0ZWQgYnkgbWFueSBkcml2ZXJzIGluIFNQNzAyMSBwbGF0Zm9y bS4KPiA+ID4gPiA+IFdlIG5ldmVyIGJ1aWxkIGl0IGFzIGEgbW9kdWxlLCBidXQgYnVpbGQtaW4g dG8ga2VybmVsLgo+ID4gPiA+ID4gU28gd2UgdXNlICJib29sIi4KPiA+ID4gPiA+Cj4gPiA+ID4g PiBTaG91bGQgd2Ugc2V0IGl0IHRvIHRyaXN0YXRlPwo+ID4gPiA+Cj4gPiA+ID4gWW91IHN0aWxs IGhhdmVuJ3QgYW5zd2VyZWQgIndoeSIsIHNvIEkgY2FuJ3QgdGVsbCB5b3UuCj4gPiA+Cj4gPiA+ IEkgYW0gcHV6emxlZCBiZWNhdXNlIEkgdGhpbmsgSSBoYXZlIGFuc3dlcmVkICJ3aHkiLgo+ID4K PiA+IE5vcGUuIDotKQo+ID4KPiA+ID4gQmVjYXVzZSBQaW5jdHJsIGRyaXZlciBpcyBuZWNlc3Nh cnkgZm9yIGFsbCBTUDcwMjEtYmFzZWQgcGxhdGZvcm1zLgo+ID4KPiA+ICJXaHk/IiBXaHkgaXMg aXQgbmVjZXNzYXJ5ICh0byBiZSBidWlsdC1pbik/Cj4KPiBQaW5jdHJsIGlzIG5lY2Vzc2FyeSB0 byBiZSBidWlsdC1pbiBiZWNhdXNlIGRyaXZlcnMgb2YgYm9vdC1kZXZpY2UsCj4gbGlrZSBlTU1D LCBTRCBjYXJkLCBOQU5EIGZsYXNoLCBhbmQgTk9SIGZsYXNoIGRyaXZlcnMsIG5lZWQgaXQuCj4K PiBTUDcwMjEgc3VwcG9ydHMgYm9vdGluZyBmcm9tIGVNTUMsIFNEIGNhcmQsIE5BTkQgZmxhc2gg YW5kIE5PUiBmbGFzaAo+IGRldmljZXMuIFRoZWlyIGRyaXZlcnMgbmVlZCBQaW5jdHJsIGRyaXZl ciBwcm9iZXMgaW4gYWR2YW5jZS4KCk9uIHg4NiBwbGF0Zm9ybXMsIGZvciBleGFtcGxlLCBib290 aW5nIGZyb20gZU1NQyBhbmQgU0QgY2FyZCBkb2VzIG5vdApyZXF1aXJlIGEgcGluIGNvbnRyb2wg ZHJpdmVyIHRvIGJlIGJ1aWx0LWluLiBXaHkgaXMgdGhpcyByZXF1aXJlbWVudApmb3IgU1AgcGxh dGZvcm1zPwoKLS0gCldpdGggQmVzdCBSZWdhcmRzLApBbmR5IFNoZXZjaGVua28KCl9fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmxpbnV4LWFybS1rZXJuZWwg bWFpbGluZyBsaXN0CmxpbnV4LWFybS1rZXJuZWxAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwOi8v bGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LWFybS1rZXJuZWwK