From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:45228)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <marcandre.lureau@gmail.com>) id 1Za27Y-0004kg-BF
	for qemu-devel@nongnu.org; Thu, 10 Sep 2015 09:42:37 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <marcandre.lureau@gmail.com>) id 1Za27S-00041D-Fs
	for qemu-devel@nongnu.org; Thu, 10 Sep 2015 09:42:36 -0400
Received: from mail-ob0-x22e.google.com ([2607:f8b0:4003:c01::22e]:32951)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <marcandre.lureau@gmail.com>) id 1Za27S-00040U-6f
	for qemu-devel@nongnu.org; Thu, 10 Sep 2015 09:42:30 -0400
Received: by obbbh8 with SMTP id bh8so34661971obb.0
	for <qemu-devel@nongnu.org>; Thu, 10 Sep 2015 06:42:29 -0700 (PDT)
MIME-Version: 1.0
In-Reply-To: <1441891346.11233.1.camel@redhat.com>
References: <1441797654-15350-1-git-send-email-kraxel@redhat.com>
	<1441797654-15350-2-git-send-email-kraxel@redhat.com>
	<CAJ+F1C+YRwG0yjat4p+rKmGdj0uu0wHN8rtQPBQyZOU2AADiAA@mail.gmail.com>
	<1441891346.11233.1.camel@redhat.com>
Date: Thu, 10 Sep 2015 15:42:29 +0200
Message-ID: <CAJ+F1CJULVxetPWrJXRwNzdRHCPuUNbuszZhOF1PPO4AX1Bg1A@mail.gmail.com>
From: =?UTF-8?B?TWFyYy1BbmRyw6kgTHVyZWF1?= <marcandre.lureau@gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH 1/9] shaders: initialize vertexes once
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: QEMU <qemu-devel@nongnu.org>

Hi

On Thu, Sep 10, 2015 at 3:22 PM, Gerd Hoffmann <kraxel@redhat.com> wrote:
>> > +    glBindBuffer (GL_ARRAY_BUFFER, 0);
>> > +    glBindVertexArray (0);
>> > +    glDeleteBuffers (1, &buffer);
>> > +
>>
>> extra space before (
>
> Fixed.
>
>> Is the unbinding necessary?
>
> Unbinding?  Do you mam the DeleteBuffers?
>

The glBind..(.., 0)

I think they shouldn't be necessary unless you have some other gl
context sensitive code.

--=20
Marc-Andr=C3=A9 Lureau