From: "Marc-André Lureau" <marcandre.lureau@gmail.com>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: QEMU <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH 0/9] add virgl rendering support.
Date: Fri, 11 Sep 2015 18:10:45 +0200 [thread overview]
Message-ID: <CAJ+F1CK9sAdJ0fwicdaBs=r1JOYt+440vm3+=hgz7=dzz9s53g@mail.gmail.com> (raw)
In-Reply-To: <1441797654-15350-1-git-send-email-kraxel@redhat.com>
Hi
On Wed, Sep 9, 2015 at 1:20 PM, Gerd Hoffmann <kraxel@redhat.com> wrote:
> Hi,
>
> This patch series adds infrastructure for opengl rendering
> (context management, define scanout textures), adds support
> for this to sdl2 and gtk user interfaces and adds virgl/3d
> mode to virtio-gpu by hooking up the virglrenderer library.
>
Before I dig further, let me give some feedback on testing. I used f22
host, and a f22 guest with xserver/modesetting from git master.
- the sdl2 gl backend doesn't display virgl rendering, I have this
"extra" errors (not the one I usually get from virgl)
Mesa: User error: GL_INVALID_OPERATION in
glFramebufferTexture2D(window-system framebuffer)
Mesa: User error: GL_INVALID_OPERATION in glGetnTexImageARB(missing image)
Mesa: User error: GL_INVALID_OPERATION in glTexSubImage2D(invalid texture image)
- gtk egl works ok
- gtkglarea fails to initialize
- regardless of the backend I get these errors in the guest:
Sep 11 11:58:34 localhost.localdomain
/usr/libexec/gdm-x-session[1669]: (WW) modeset(0): flip queue failed:
Invalid argument
Sep 11 11:58:34 localhost.localdomain
/usr/libexec/gdm-x-session[1669]: (WW) modeset(0): Page flip failed:
Invalid argument
Sep 11 11:58:34 localhost.localdomain
/usr/libexec/gdm-x-session[1669]: (EE) modeset(0): present flip failed
- apart from the aspect-ratio issue (cursor doesn't follow it either),
there is a off-by-one cursor update bug (that I know existed before,
and I plan to look at)
Finally, wayland (gnome-shell --wayland gdm session):
- has some refresh issues that X doesn't have
- give black screen why virtio-vga,virgl=false
> please review,
> Gerd
>
> Gerd Hoffmann (9):
> shaders: initialize vertexes once
> sdl2: quick & dirty flicker workaround
> ui/console: add opengl context and scanout support interfaces.
> virtio-gpu: update headers for virgl/3d
> virtio-gpu: add 3d mode and virgl rendering support.
> sdl2/opengl: add opengl context and scanout support
> opengl: add egl-context.[ch] helpers
> gtk/opengl: add opengl context and scanout support (egl)
> gtk/opengl: add opengl context and scanout support (GtkGLArea)
>
> configure | 40 ++
> hw/display/Makefile.objs | 6 +-
> hw/display/virtio-gpu-3d.c | 598 ++++++++++++++++++++++++++++
> hw/display/virtio-gpu.c | 130 +++++-
> include/hw/virtio/virtio-gpu.h | 22 +-
> include/standard-headers/linux/virtio_gpu.h | 112 +++++-
> include/ui/console.h | 36 ++
> include/ui/egl-context.h | 14 +
> include/ui/gtk.h | 39 ++
> include/ui/sdl2.h | 22 +-
> include/ui/shader.h | 4 +-
> trace-events | 8 +
> ui/Makefile.objs | 6 +
> ui/console-gl.c | 7 +-
> ui/console.c | 67 +++-
> ui/egl-context.c | 34 ++
> ui/gtk-egl.c | 129 +++++-
> ui/gtk-gl-area.c | 219 ++++++++++
> ui/gtk.c | 118 ++++--
> ui/sdl2-2d.c | 13 +
> ui/sdl2-gl.c | 133 +++++++
> ui/sdl2.c | 7 +
> ui/shader.c | 32 +-
> 23 files changed, 1741 insertions(+), 55 deletions(-)
> create mode 100644 hw/display/virtio-gpu-3d.c
> create mode 100644 include/ui/egl-context.h
> create mode 100644 ui/egl-context.c
> create mode 100644 ui/gtk-gl-area.c
>
> --
> 1.8.3.1
>
>
--
Marc-André Lureau
prev parent reply other threads:[~2015-09-11 16:10 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-09 11:20 [Qemu-devel] [PATCH 0/9] add virgl rendering support Gerd Hoffmann
2015-09-09 11:20 ` [Qemu-devel] [PATCH 1/9] shaders: initialize vertexes once Gerd Hoffmann
2015-09-10 12:40 ` Marc-André Lureau
2015-09-10 13:22 ` Gerd Hoffmann
2015-09-10 13:42 ` Marc-André Lureau
2015-09-10 14:59 ` Gerd Hoffmann
2015-09-14 16:00 ` Max Reitz
2015-09-14 16:19 ` Max Reitz
2015-09-15 7:10 ` Gerd Hoffmann
2015-09-09 11:20 ` [Qemu-devel] [PATCH 2/9] sdl2: quick & dirty flicker workaround Gerd Hoffmann
2015-09-10 12:40 ` Marc-André Lureau
2015-09-14 16:16 ` Max Reitz
2015-09-09 11:20 ` [Qemu-devel] [PATCH 3/9] ui/console: add opengl context and scanout support interfaces Gerd Hoffmann
2015-09-10 12:40 ` Marc-André Lureau
2015-09-15 8:30 ` Paolo Bonzini
2015-09-09 11:20 ` [Qemu-devel] [PATCH 4/9] virtio-gpu: update headers for virgl/3d Gerd Hoffmann
2015-09-10 12:41 ` Marc-André Lureau
2015-09-09 11:20 ` [Qemu-devel] [PATCH 5/9] virtio-gpu: add 3d mode and virgl rendering support Gerd Hoffmann
2015-09-14 18:14 ` Max Reitz
2015-09-15 7:33 ` Gerd Hoffmann
2015-09-15 8:33 ` Paolo Bonzini
2015-09-09 11:20 ` [Qemu-devel] [PATCH 6/9] sdl2/opengl: add opengl context and scanout support Gerd Hoffmann
2015-09-14 18:49 ` Max Reitz
2015-09-15 7:54 ` Gerd Hoffmann
2015-09-16 13:44 ` Max Reitz
2015-09-09 11:20 ` [Qemu-devel] [PATCH 7/9] opengl: add egl-context.[ch] helpers Gerd Hoffmann
2015-09-11 14:13 ` Marc-André Lureau
2015-09-09 11:20 ` [Qemu-devel] [PATCH 8/9] gtk/opengl: add opengl context and scanout support (egl) Gerd Hoffmann
2015-09-11 14:36 ` Marc-André Lureau
2015-09-09 11:20 ` [Qemu-devel] [PATCH 9/9] gtk/opengl: add opengl context and scanout support (GtkGLArea) Gerd Hoffmann
2015-09-11 14:44 ` Marc-André Lureau
2015-09-14 13:50 ` Gerd Hoffmann
2015-09-11 16:10 ` Marc-André Lureau [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJ+F1CK9sAdJ0fwicdaBs=r1JOYt+440vm3+=hgz7=dzz9s53g@mail.gmail.com' \
--to=marcandre.lureau@gmail.com \
--cc=kraxel@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.