Hello,
On patch:
toaster: Move getGitCloneDirectory to parent class
the implementation of the getGitCloneDirectory is specific to localhost controller - it can't be moved to the parent class because it references local paths for "HEAD" checkouts - see
+ from os.path import dirname as DN
+ local_checkout_path = DN(DN(DN(DN(DN(os.path.abspath(__file__))))))
+ #logger.debug("localhostbecontroller: using HEAD checkout in %s" % local_checkout_path)
building on "HEAD" doesn't make sense on SSH remote builds, so I would leave this part of the code in an overriding method in the LocalhostBEController.
On patch:
toaster: Move 3 classes to toasterui
I do not think that adding the classes to the bb.ui.toasterui is a good idea - this is because the code in the toasterui is a Bitbake-specific UI implementation, and should not be contaminated with code that doesn't do UI event processing duties.
I think a way better place would be in a new module under bb.server as they conceptually implement a mock Bitbake server.
On patch:
toaster: Add template for shell script
I appreciate the ingenuity of using the Django template rendering framework to create the startup script :)
The script can be better formatted though, so it's more readable.
On patch:
toaster: Reimplement SSH BE Controller
triggerBuild() is a long-running method if it going to execute toasterui.main before returning. The system is not designed to support this case - the caller of the triggerBuild() expects a quick return so that the scheduling process can continue. In this sense, the localhost controller runs a different process for the toasterui, and does not run the toasterui in the same context.
This also has a security implication - the code in the bldcontrol application is run in the context of the web server user, but bitbake - including toasterui - is expected to be run in the context of bitbake user. This will lead to all sorts of interesting problems regarding file creation, if the users are not identical (E.g. when toaster runs under a web server).
Please instantiate another process in the bitbake context that runs the toasterui, and does so asynchronously.
I am not sure what happens when the git repo starts with "file://" in the remote use case; I would deem this to be an invalid use case in the remote use case.
On patch:
toaster: Move code from SSH controler to parent
This would break Toaster in subtle ways due to reasons specified above, now applying to the localhost use case as well.
Cheers,
Alex