From: David Marchand <david.marchand@redhat.com>
To: Pavan Nikhilesh Bhagavatula <pbhagavatula@marvell.com>,
Bruce Richardson <bruce.richardson@intel.com>
Cc: Jerin Jacob <jerinjacobk@gmail.com>,
Thomas Monjalon <thomas@monjalon.net>,
Ferruh Yigit <ferruh.yigit@intel.com>, dev <dev@dpdk.org>,
Neil Horman <nhorman@tuxdriver.com>
Subject: Re: [dpdk-dev] [EXT] Re: [PATCH v2 1/2] build: meson make experimental tag as global
Date: Fri, 3 Apr 2020 10:18:02 +0200 [thread overview]
Message-ID: <CAJFAV8wTPCF6_mgV0JTaroGYyrROUzstrJ+hjfVkrvts6TC22g@mail.gmail.com> (raw)
In-Reply-To: <CY4PR1801MB18636103B7732A3087BA1039DEC70@CY4PR1801MB1863.namprd18.prod.outlook.com>
On Fri, Apr 3, 2020 at 10:06 AM Pavan Nikhilesh Bhagavatula
<pbhagavatula@marvell.com> wrote:
>
> ><david.marchand@redhat.com> wrote:
> >> On Thu, Apr 2, 2020 at 8:33 PM Jerin Jacob <jerinjacobk@gmail.com>
> >wrote:
> >> - You can still find traces in meson files.
> >> $ git grep -il allow.experimental.api |grep meson.build$ |grep -vE
> >> '^((app|drivers|lib)/meson.build|examples/)'
> >> app/test/meson.build
> >> drivers/net/e1000/base/meson.build
> >> drivers/net/enic/meson.build
> >> drivers/net/i40e/base/meson.build
> >> drivers/net/i40e/meson.build
> >> drivers/net/ixgbe/base/meson.build
> >> drivers/net/octeontx/base/meson.build
> >> drivers/net/qede/base/meson.build
> >> drivers/net/sfc/base/meson.build
> >> drivers/net/thunderx/base/meson.build
> >> lib/librte_mempool/meson.build
> >
> >Sorry, those drivers passing directly the cflag were special cases.
>
> Yup. Mostly base static libs.
Actually, how about something like this in drivers/meson.build ?
Bruce, do you see something wrong with this ?
on top of Pavan patch:
diff --git a/drivers/meson.build b/drivers/meson.build
index 987e616ae7..4d8f842ab8 100644
--- a/drivers/meson.build
+++ b/drivers/meson.build
@@ -20,7 +20,7 @@ dpdk_driver_classes = ['common',
disabled_drivers = run_command(list_dir_globs, get_option('disable_drivers'),
).stdout().split()
-default_cflags = machine_args
+default_cflags = machine_args + ['-DALLOW_EXPERIMENTAL_API']
if cc.has_argument('-Wno-format-truncation')
default_cflags += '-Wno-format-truncation'
endif
@@ -105,7 +105,6 @@ foreach class:dpdk_driver_classes
dpdk_conf.set(config_flag_fmt.format(fmt_name.to_upper()),1)
lib_name = driver_name_fmt.format(fmt_name)
- cflags += '-DALLOW_EXPERIMENTAL_API'
dpdk_extra_ldflags += pkgconfig_extra_libs
# generate pmdinfo sources by building a temporary
Since the base drivers make use of "cflags", it works afaics.
>
> >This just leaves lib/librte_mempool/meson.build to clean.
>
> I will clean it up in v3. Along with modifying title and updating doc.
>
> Doc to be updated are coding styles and release notes right?
> Let me know if anything else need to be added to the list.
lgtm, thanks.
--
David Marchand
next prev parent reply other threads:[~2020-04-03 8:18 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-02 18:32 [dpdk-dev] [PATCH v2 1/2] build: meson make experimental tag as global Jerin Jacob
2020-04-02 18:32 ` [dpdk-dev] [PATCH v2 2/2] build: makefile " Jerin Jacob
2020-04-03 7:23 ` [dpdk-dev] [PATCH v2 1/2] build: meson " David Marchand
2020-04-03 7:45 ` David Marchand
2020-04-03 8:05 ` [dpdk-dev] [EXT] " Pavan Nikhilesh Bhagavatula
2020-04-03 8:18 ` David Marchand [this message]
2020-04-03 9:10 ` Bruce Richardson
2020-04-03 9:14 ` David Marchand
2020-04-03 9:35 ` Bruce Richardson
2020-04-03 10:56 ` Thomas Monjalon
2020-04-03 11:02 ` Pavan Nikhilesh Bhagavatula
2020-04-03 10:20 ` [dpdk-dev] " Hemant Agrawal (OSS)
2020-04-03 14:19 ` [dpdk-dev] [PATCH v3] build: enable allow experimental API flag globally pbhagavatula
2020-04-06 20:16 ` David Marchand
2020-04-10 9:03 ` [dpdk-dev] [PATCH v4] build: enable allow experimental API flag pbhagavatula
2020-04-10 12:12 ` David Marchand
2020-04-10 15:48 ` David Marchand
2020-04-13 14:55 ` [dpdk-dev] [PATCH v5] build: disable experimental API check internally David Marchand
2020-04-14 14:23 ` David Marchand
2020-04-17 10:21 ` Trahe, Fiona
2020-04-17 13:23 ` David Marchand
2020-04-17 13:44 ` Trahe, Fiona
2020-04-17 13:54 ` Thomas Monjalon
2020-04-17 13:56 ` David Marchand
2020-04-17 15:05 ` Trahe, Fiona
2020-04-17 15:52 ` Trahe, Fiona
2020-04-18 19:43 ` Chautru, Nicolas
2020-04-19 7:35 ` David Marchand
2020-04-19 16:17 ` Chautru, Nicolas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJFAV8wTPCF6_mgV0JTaroGYyrROUzstrJ+hjfVkrvts6TC22g@mail.gmail.com \
--to=david.marchand@redhat.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=jerinjacobk@gmail.com \
--cc=nhorman@tuxdriver.com \
--cc=pbhagavatula@marvell.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.