From: David Marchand <david.marchand@redhat.com>
To: Ruifeng Wang <ruifeng.wang@arm.com>,
Vladimir Medvedkin <vladimir.medvedkin@intel.com>,
Bruce Richardson <bruce.richardson@intel.com>
Cc: dev <dev@dpdk.org>, nd <nd@arm.com>,
Jerin Jacob Kollanukkaran <jerinj@marvell.com>,
David Christensen <drc@linux.vnet.ibm.com>,
Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>
Subject: Re: [dpdk-dev] [PATCH 0/4] lpm lookupx4 fixes
Date: Wed, 13 Jan 2021 15:52:34 +0100 [thread overview]
Message-ID: <CAJFAV8xf14=K-G3HS4vWotDWY3QaKnqRR-iKfnfu5E3Sx5UukQ@mail.gmail.com> (raw)
In-Reply-To: <20210108082127.1061538-1-ruifeng.wang@arm.com>
On Fri, Jan 8, 2021 at 9:22 AM Ruifeng Wang <ruifeng.wang@arm.com> wrote:
>
> This series fixed bug in lpm4 vector lookup implementations.
> When more than 256 tbl8 groups are created, lookupx4 could
> retrieve next hop data from wrong group.
> The bug is there since next_hop field was expanded from
> 8-bit to 24-bit, and inherited by other implementations.
This is a single issue: I would squash those 3 patches as a single
patch (with 3 Fixes: tags).
>
> Also updated test case to improve coverage to detect such
> failure.
>
> Ruifeng Wang (4):
> lpm: fix vector lookup for Arm
> lpm: fix vector lookup for x86
> lpm: fix vector lookup for ppc64
> test/lpm: improve coverage on tbl8
Reviews please?
--
David Marchand
next prev parent reply other threads:[~2021-01-13 14:52 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-08 8:21 [dpdk-dev] [PATCH 0/4] lpm lookupx4 fixes Ruifeng Wang
2021-01-08 8:21 ` [dpdk-dev] [PATCH 1/4] lpm: fix vector lookup for Arm Ruifeng Wang
2021-01-08 8:21 ` [dpdk-dev] [PATCH 2/4] lpm: fix vector lookup for x86 Ruifeng Wang
2021-01-13 18:46 ` Medvedkin, Vladimir
2021-01-08 8:21 ` [dpdk-dev] [PATCH 3/4] lpm: fix vector lookup for ppc64 Ruifeng Wang
2021-01-11 21:29 ` David Christensen
2021-01-08 8:21 ` [dpdk-dev] [PATCH 4/4] test/lpm: improve coverage on tbl8 Ruifeng Wang
2021-01-11 21:29 ` David Christensen
2021-01-13 18:51 ` Medvedkin, Vladimir
2021-01-14 6:38 ` Ruifeng Wang
2021-01-13 14:52 ` David Marchand [this message]
2021-01-14 6:54 ` [dpdk-dev] [PATCH 0/4] lpm lookupx4 fixes Ruifeng Wang
2021-01-13 18:46 ` Medvedkin, Vladimir
2021-01-14 6:59 ` [dpdk-dev] [PATCH v2 " Ruifeng Wang
2021-01-14 6:59 ` [dpdk-dev] [PATCH v2 1/4] lpm: fix vector lookup for Arm Ruifeng Wang
2021-01-14 6:59 ` [dpdk-dev] [PATCH v2 2/4] lpm: fix vector lookup for x86 Ruifeng Wang
2021-01-14 6:59 ` [dpdk-dev] [PATCH v2 3/4] lpm: fix vector lookup for ppc64 Ruifeng Wang
2021-01-14 6:59 ` [dpdk-dev] [PATCH v2 4/4] test/lpm: improve coverage on tbl8 Ruifeng Wang
2021-01-14 11:14 ` Medvedkin, Vladimir
2021-01-14 15:25 ` [dpdk-dev] [PATCH v2 0/4] lpm lookupx4 fixes David Marchand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJFAV8xf14=K-G3HS4vWotDWY3QaKnqRR-iKfnfu5E3Sx5UukQ@mail.gmail.com' \
--to=david.marchand@redhat.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=drc@linux.vnet.ibm.com \
--cc=honnappa.nagarahalli@arm.com \
--cc=jerinj@marvell.com \
--cc=nd@arm.com \
--cc=ruifeng.wang@arm.com \
--cc=vladimir.medvedkin@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.