From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C37B9C433B4 for ; Tue, 20 Apr 2021 13:33:55 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 573DF61027 for ; Tue, 20 Apr 2021 13:33:55 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 573DF61027 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=intel-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id C109E6E826; Tue, 20 Apr 2021 13:33:54 +0000 (UTC) Received: from mail-il1-x135.google.com (mail-il1-x135.google.com [IPv6:2607:f8b0:4864:20::135]) by gabe.freedesktop.org (Postfix) with ESMTPS id 202AF6E826 for ; Tue, 20 Apr 2021 13:33:53 +0000 (UTC) Received: by mail-il1-x135.google.com with SMTP id l9so3596521ilh.10 for ; Tue, 20 Apr 2021 06:33:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Xgfc7mO4E1wXWUmekqC8sEt5bIbUy15Zn+YoHQva8NI=; b=PYyvqtFzdzRakpUOqbunR4I7/Lj/8HDyE7lqd9tAm0PNx6Uh1yOIHCDmuaqBR1ViP4 mmStHq4YHDIb9iNLpswctc4T/0gjz0QMypKb9sh/woNGTQHvzByI8qY89af1f2aYk6+S wieFezmrOmmKh35TaWQ/tU2N5mVDzf8HRzVYk= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Xgfc7mO4E1wXWUmekqC8sEt5bIbUy15Zn+YoHQva8NI=; b=KidSEKPtBmXpUNqnyUDHF46wRgBj4ebXw9rMexj3zG4qISFv+EPwz26Ymoxvr7vUsw LJ0BWPJzdsau6Oqdarj8oK6vg8rZlCW6hBu72I48Jhl/AYGFVRXfR7HgVyH9int1l1zl yGeNyqSQHEk6nFEm8cIWHuCtieChP76iH+bL3AS2K5zWLap9DrLIzTSckWOPH2Ki1mxV xvQiCFg0Yw3s7YJtko79uezaobK4NVSypnTl/X3QbW9HAdAehXIjN3iWIdl28EyyvyQE ZWyAs7zadTaBIqAEpaAw1P3fYNriCPrNEEGCvybWIg389/zKIc809tTrMAMUJfBXkbUH Ap8A== X-Gm-Message-State: AOAM533XIw092/g0aLE4KEb3GkeAgUEqPms/ylZQhow52jApZQoUirx5 UCcvOMoDpSyu008Wy32EboWd0dy4mMW/u/ZdPAfpwQ== X-Google-Smtp-Source: ABdhPJy6RgMFJUk30o3Bp+6VqEWzChzCOkzvaHDVug4JPECZShpDcemglkoDMMwZ/VXKrU9wV09fLSo20xOiZ0XVnHs= X-Received: by 2002:a92:d684:: with SMTP id p4mr22468413iln.150.1618925632435; Tue, 20 Apr 2021 06:33:52 -0700 (PDT) MIME-Version: 1.0 References: <20210414172916.2689361-1-hsinyi@chromium.org> <20210414172916.2689361-5-hsinyi@chromium.org> In-Reply-To: From: Hsin-Yi Wang Date: Tue, 20 Apr 2021 21:33:25 +0800 Message-ID: To: Bartosz Golaszewski Subject: Re: [Intel-gfx] [PATCH v19 4/6] misc: eeprom: at24: check suspend status before disable regulator X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: arm-soc , linux-devicetree , Arnd Bergmann , Greg Kroah-Hartman , Mark Brown , LKML , Wolfram Sang , Rob Herring , "moderated list:ARM/Mediatek SoC..." , linux-i2c , Bibby Hsieh , Matthias Brugger , intel-gfx@lists.freedesktop.org, Qii Wang , Marek Szyprowski Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Fri, Apr 16, 2021 at 10:09 PM Bartosz Golaszewski wrote: > > On Wed, Apr 14, 2021 at 7:29 PM Hsin-Yi Wang wrote: > > > > cd5676db0574 ("misc: eeprom: at24: support pm_runtime control") disables > > regulator in runtime suspend. If runtime suspend is called before > > regulator disable, it will results in regulator unbalanced disabling. > > > > Signed-off-by: Hsin-Yi Wang > > Please add the Fixes tag. > Hi, I resend the patch with the fix tag separately since other patches in this series are not changed. https://patchwork.ozlabs.org/project/linux-i2c/patch/20210420133050.377209-1-hsinyi@chromium.org/ Thanks > > --- > > drivers/misc/eeprom/at24.c | 6 ++++-- > > 1 file changed, 4 insertions(+), 2 deletions(-) > > > > diff --git a/drivers/misc/eeprom/at24.c b/drivers/misc/eeprom/at24.c > > index 926408b41270..7a6f01ace78a 100644 > > --- a/drivers/misc/eeprom/at24.c > > +++ b/drivers/misc/eeprom/at24.c > > @@ -763,7 +763,8 @@ static int at24_probe(struct i2c_client *client) > > at24->nvmem = devm_nvmem_register(dev, &nvmem_config); > > if (IS_ERR(at24->nvmem)) { > > pm_runtime_disable(dev); > > - regulator_disable(at24->vcc_reg); > > + if (!pm_runtime_status_suspended(dev)) > > + regulator_disable(at24->vcc_reg); > > return PTR_ERR(at24->nvmem); > > } > > > > @@ -774,7 +775,8 @@ static int at24_probe(struct i2c_client *client) > > err = at24_read(at24, 0, &test_byte, 1); > > if (err) { > > pm_runtime_disable(dev); > > - regulator_disable(at24->vcc_reg); > > + if (!pm_runtime_status_suspended(dev)) > > + regulator_disable(at24->vcc_reg); > > return -ENODEV; > > } > > > > -- > > 2.31.1.295.g9ea45b61b8-goog > > > > Acked-by: Bartosz Golaszewski _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 87642C433ED for ; Tue, 20 Apr 2021 13:34:29 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id CDACC61077 for ; Tue, 20 Apr 2021 13:34:28 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CDACC61077 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From:In-Reply-To: References:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=JsYzQFY+95TgACKPY6pdexkbGkyE+D/+b5/fOv7MW40=; b=oG+ulQnzNFFGyYiyJdYPmY78l 6sj19KwF2d3PsO7au7z7ji/BHCDIC3Xdfc5tdgHs66D4hszE3/+F88bvCMr0vcTgbcnieOerFWpbL gqiZYriCCyxOX8PTW47Er2QGpKeSLgsb9c0wWPPLHgrg8qdbskJ74dmKwItxV+ULx+c0QiruFBRve gRdpq7VtyUIyujXObZHz+GmL8V+lr8traIl/cAg24nVTaUyDgOR+ZX5RJdMeeFTgeVU7GJKNx2WZV wzgq5wJw7IPnP/AHrX7OldIYN182l2eUYTfNomQUYo7L4CWBFMocvQzOMP/RedpWvmyX1Z6xkGg48 QgOe9RzZw==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lYqW5-00CEal-3W; Tue, 20 Apr 2021 13:34:13 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lYqVs-00CEYa-4a for linux-mediatek@desiato.infradead.org; Tue, 20 Apr 2021 13:34:00 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Type:Cc:To:Subject:Message-ID :Date:From:In-Reply-To:References:MIME-Version:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=Xgfc7mO4E1wXWUmekqC8sEt5bIbUy15Zn+YoHQva8NI=; b=TBk0949S0khkT8s6CcYsMMOHh/ bwJd2EQimJIO/6FPyHwZPFVhCxQ2Q0r0lmBJZogQmFO8KnnE6sK9iYvZ91s2vlqZJ8MxcEQgbFMKX UgLdeZL0KywZ+9QMX5mBjWzMHSS82wAng+woyNJipF5TukwyT8exBcaodftNWVwVqwbjJGkcCRb/w kf2ltOHVbUF6AW3lr/GSjSLlBgxP0Sn5cIDFzZ7nfShRUr8/P1ssdM8cVCt8rZqYFNUefxT/PkM0N TdikOAeeWu7W4jtYWS/mrnnxh/o9u2OKHQImejwIRqgNzlZ3g4J8sXQ6Fo4UBzc2kVAeOFYy8xrtX ArHAvCdg==; Received: from mail-il1-x12d.google.com ([2607:f8b0:4864:20::12d]) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lYqVm-00C9Vo-Nh for linux-mediatek@lists.infradead.org; Tue, 20 Apr 2021 13:33:58 +0000 Received: by mail-il1-x12d.google.com with SMTP id c4so5484457ilq.9 for ; Tue, 20 Apr 2021 06:33:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Xgfc7mO4E1wXWUmekqC8sEt5bIbUy15Zn+YoHQva8NI=; b=PYyvqtFzdzRakpUOqbunR4I7/Lj/8HDyE7lqd9tAm0PNx6Uh1yOIHCDmuaqBR1ViP4 mmStHq4YHDIb9iNLpswctc4T/0gjz0QMypKb9sh/woNGTQHvzByI8qY89af1f2aYk6+S wieFezmrOmmKh35TaWQ/tU2N5mVDzf8HRzVYk= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Xgfc7mO4E1wXWUmekqC8sEt5bIbUy15Zn+YoHQva8NI=; b=WgBhLK+AJS8rVmLIdGfGv42Jra4MSZ03FpWoJDl/i2fAVqM61hPtFJ0k7jOex0LEen sQgS6oxAS3LW9pFESKsImpA+F5OTTZkXCNL9fhB+VgYmswQJGeQrJApRB7KhI8BkKiQN xIsEgDlTSEkj87E6B1VcejxnMA3Jro9fAL4ut1eI+nKyKGGfiQCviE+NSGawZqwPc2nf 3lZTb2O/vGI9V+csvA45hrMdiKTjC8brnEMZy4/oY31Zb7IA8xuZ/sqRpD14/+kz0G8P t4zG9MC8pSKHS40HrY7JP6gJaVLcpp7kzB5a6+LdzIdsZDVkGy4kOWVLEmEvyvpWb2tt Ap9g== X-Gm-Message-State: AOAM531R/UBAWXE7oC1Pr/Grtd6qYgYJxE86kS/RarmeovSwrtyADhp2 CVNZ80EZ91/OK4JeoQZjHQct+PR8mGTIEbhUl8D6wg== X-Google-Smtp-Source: ABdhPJy6RgMFJUk30o3Bp+6VqEWzChzCOkzvaHDVug4JPECZShpDcemglkoDMMwZ/VXKrU9wV09fLSo20xOiZ0XVnHs= X-Received: by 2002:a92:d684:: with SMTP id p4mr22468413iln.150.1618925632435; Tue, 20 Apr 2021 06:33:52 -0700 (PDT) MIME-Version: 1.0 References: <20210414172916.2689361-1-hsinyi@chromium.org> <20210414172916.2689361-5-hsinyi@chromium.org> In-Reply-To: From: Hsin-Yi Wang Date: Tue, 20 Apr 2021 21:33:25 +0800 Message-ID: Subject: Re: [PATCH v19 4/6] misc: eeprom: at24: check suspend status before disable regulator To: Bartosz Golaszewski Cc: Wolfram Sang , Matthias Brugger , Rob Herring , linux-i2c , Qii Wang , linux-devicetree , arm-soc , "moderated list:ARM/Mediatek SoC..." , LKML , Greg Kroah-Hartman , Mark Brown , Marek Szyprowski , Bibby Hsieh , Arnd Bergmann , Jani Nikula , Joonas Lahtinen , intel-gfx@lists.freedesktop.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210420_063354_795307_BF1BCF85 X-CRM114-Status: GOOD ( 21.19 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org On Fri, Apr 16, 2021 at 10:09 PM Bartosz Golaszewski wrote: > > On Wed, Apr 14, 2021 at 7:29 PM Hsin-Yi Wang wrote: > > > > cd5676db0574 ("misc: eeprom: at24: support pm_runtime control") disables > > regulator in runtime suspend. If runtime suspend is called before > > regulator disable, it will results in regulator unbalanced disabling. > > > > Signed-off-by: Hsin-Yi Wang > > Please add the Fixes tag. > Hi, I resend the patch with the fix tag separately since other patches in this series are not changed. https://patchwork.ozlabs.org/project/linux-i2c/patch/20210420133050.377209-1-hsinyi@chromium.org/ Thanks > > --- > > drivers/misc/eeprom/at24.c | 6 ++++-- > > 1 file changed, 4 insertions(+), 2 deletions(-) > > > > diff --git a/drivers/misc/eeprom/at24.c b/drivers/misc/eeprom/at24.c > > index 926408b41270..7a6f01ace78a 100644 > > --- a/drivers/misc/eeprom/at24.c > > +++ b/drivers/misc/eeprom/at24.c > > @@ -763,7 +763,8 @@ static int at24_probe(struct i2c_client *client) > > at24->nvmem = devm_nvmem_register(dev, &nvmem_config); > > if (IS_ERR(at24->nvmem)) { > > pm_runtime_disable(dev); > > - regulator_disable(at24->vcc_reg); > > + if (!pm_runtime_status_suspended(dev)) > > + regulator_disable(at24->vcc_reg); > > return PTR_ERR(at24->nvmem); > > } > > > > @@ -774,7 +775,8 @@ static int at24_probe(struct i2c_client *client) > > err = at24_read(at24, 0, &test_byte, 1); > > if (err) { > > pm_runtime_disable(dev); > > - regulator_disable(at24->vcc_reg); > > + if (!pm_runtime_status_suspended(dev)) > > + regulator_disable(at24->vcc_reg); > > return -ENODEV; > > } > > > > -- > > 2.31.1.295.g9ea45b61b8-goog > > > > Acked-by: Bartosz Golaszewski _______________________________________________ Linux-mediatek mailing list Linux-mediatek@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-mediatek From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EDFEEC43461 for ; Tue, 20 Apr 2021 13:34:32 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id AD50461264 for ; Tue, 20 Apr 2021 13:34:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232592AbhDTNfC (ORCPT ); Tue, 20 Apr 2021 09:35:02 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39202 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232628AbhDTNeY (ORCPT ); Tue, 20 Apr 2021 09:34:24 -0400 Received: from mail-il1-x133.google.com (mail-il1-x133.google.com [IPv6:2607:f8b0:4864:20::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0B6F6C06138A for ; Tue, 20 Apr 2021 06:33:53 -0700 (PDT) Received: by mail-il1-x133.google.com with SMTP id b17so32040572ilh.6 for ; Tue, 20 Apr 2021 06:33:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Xgfc7mO4E1wXWUmekqC8sEt5bIbUy15Zn+YoHQva8NI=; b=PYyvqtFzdzRakpUOqbunR4I7/Lj/8HDyE7lqd9tAm0PNx6Uh1yOIHCDmuaqBR1ViP4 mmStHq4YHDIb9iNLpswctc4T/0gjz0QMypKb9sh/woNGTQHvzByI8qY89af1f2aYk6+S wieFezmrOmmKh35TaWQ/tU2N5mVDzf8HRzVYk= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Xgfc7mO4E1wXWUmekqC8sEt5bIbUy15Zn+YoHQva8NI=; b=BgoFlRp1csws15Ei4534ryGsA9+MS29lkcYdEd5im8nEBYJgg83L6ytrtCy9nSrJlV QZwXbsEGD76qO9esgaWq24rfCJ1ajYLA7bqSbxPUrbKFMeCGtpzQEn+yNLBxZXLjb3fZ uItPdmIPnl6jiLhJN33u+QVC2mqVwksvPWxGp2B9Jadsx6zAB6w+Cn9X3wN+6Pc7HnOu d78WXI3hqbqrvf5ofI0V0iZW+rZmKDrdO1NF0ys0n0rNOY0UuE4PIxJCXh5StIvWvyhn T2N+zpDZRqNViDF+NqpM2yAD6I6nt5gpqsnqO3SOndqQCTgT8o+/Lcu5pLmEbS/K29ny vpWA== X-Gm-Message-State: AOAM530WXu6g/JMmDUV+it13L4N/nbPSUYYFbvHZ1VDwx7+b/DdUzuY2 zT59Usk7bvxsjxl3Mka3g1VemOihYlBv5bOSm2fFVg== X-Google-Smtp-Source: ABdhPJy6RgMFJUk30o3Bp+6VqEWzChzCOkzvaHDVug4JPECZShpDcemglkoDMMwZ/VXKrU9wV09fLSo20xOiZ0XVnHs= X-Received: by 2002:a92:d684:: with SMTP id p4mr22468413iln.150.1618925632435; Tue, 20 Apr 2021 06:33:52 -0700 (PDT) MIME-Version: 1.0 References: <20210414172916.2689361-1-hsinyi@chromium.org> <20210414172916.2689361-5-hsinyi@chromium.org> In-Reply-To: From: Hsin-Yi Wang Date: Tue, 20 Apr 2021 21:33:25 +0800 Message-ID: Subject: Re: [PATCH v19 4/6] misc: eeprom: at24: check suspend status before disable regulator To: Bartosz Golaszewski Cc: Wolfram Sang , Matthias Brugger , Rob Herring , linux-i2c , Qii Wang , linux-devicetree , arm-soc , "moderated list:ARM/Mediatek SoC..." , LKML , Greg Kroah-Hartman , Mark Brown , Marek Szyprowski , Bibby Hsieh , Arnd Bergmann , Jani Nikula , Joonas Lahtinen , intel-gfx@lists.freedesktop.org Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Apr 16, 2021 at 10:09 PM Bartosz Golaszewski wrote: > > On Wed, Apr 14, 2021 at 7:29 PM Hsin-Yi Wang wrote: > > > > cd5676db0574 ("misc: eeprom: at24: support pm_runtime control") disables > > regulator in runtime suspend. If runtime suspend is called before > > regulator disable, it will results in regulator unbalanced disabling. > > > > Signed-off-by: Hsin-Yi Wang > > Please add the Fixes tag. > Hi, I resend the patch with the fix tag separately since other patches in this series are not changed. https://patchwork.ozlabs.org/project/linux-i2c/patch/20210420133050.377209-1-hsinyi@chromium.org/ Thanks > > --- > > drivers/misc/eeprom/at24.c | 6 ++++-- > > 1 file changed, 4 insertions(+), 2 deletions(-) > > > > diff --git a/drivers/misc/eeprom/at24.c b/drivers/misc/eeprom/at24.c > > index 926408b41270..7a6f01ace78a 100644 > > --- a/drivers/misc/eeprom/at24.c > > +++ b/drivers/misc/eeprom/at24.c > > @@ -763,7 +763,8 @@ static int at24_probe(struct i2c_client *client) > > at24->nvmem = devm_nvmem_register(dev, &nvmem_config); > > if (IS_ERR(at24->nvmem)) { > > pm_runtime_disable(dev); > > - regulator_disable(at24->vcc_reg); > > + if (!pm_runtime_status_suspended(dev)) > > + regulator_disable(at24->vcc_reg); > > return PTR_ERR(at24->nvmem); > > } > > > > @@ -774,7 +775,8 @@ static int at24_probe(struct i2c_client *client) > > err = at24_read(at24, 0, &test_byte, 1); > > if (err) { > > pm_runtime_disable(dev); > > - regulator_disable(at24->vcc_reg); > > + if (!pm_runtime_status_suspended(dev)) > > + regulator_disable(at24->vcc_reg); > > return -ENODEV; > > } > > > > -- > > 2.31.1.295.g9ea45b61b8-goog > > > > Acked-by: Bartosz Golaszewski From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CEE7DC433ED for ; Tue, 20 Apr 2021 13:36:42 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 227B361026 for ; Tue, 20 Apr 2021 13:36:42 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 227B361026 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From:In-Reply-To: References:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=Mwl8SR4TgYTAYgz30phpdmwXnk6qEF07Zwo2x6L09p8=; b=SYF3Gwib6qIvv2Fx47XYSAoVQ R4h2GdcD1VYBmd6AqOBqc+zmJJQ6Wz99z3tnaRi5VcSFmeAGGIGiMJEUwkMTVdtsjoMZMiLJyVx/w lNOoN8057D26RNGP+Jw+XQZnZw/54rZa1weV+BrmJRPX7byOTS2n3sbgZwlgL05GC/OE97vwl9gTA 97WWStDrPQz8OVWFHUYxpc6qGza9yKakK5NX2FAWcjqrZOwz78IMdF8ytbOD0CeU6LFyfMvVUqMSG EX10OIOScheT+W7yLtY8um+itGtBmZzSuag3OTIlqZZ9u9k1j2sNYndgVCvFUkSiJ55pLiaiFXkdh 96WAcCtvg==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lYqVu-00CEZ4-4Y; Tue, 20 Apr 2021 13:34:02 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lYqVr-00CEYR-Lm for linux-arm-kernel@desiato.infradead.org; Tue, 20 Apr 2021 13:33:59 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Type:Cc:To:Subject:Message-ID :Date:From:In-Reply-To:References:MIME-Version:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=Xgfc7mO4E1wXWUmekqC8sEt5bIbUy15Zn+YoHQva8NI=; b=TBk0949S0khkT8s6CcYsMMOHh/ bwJd2EQimJIO/6FPyHwZPFVhCxQ2Q0r0lmBJZogQmFO8KnnE6sK9iYvZ91s2vlqZJ8MxcEQgbFMKX UgLdeZL0KywZ+9QMX5mBjWzMHSS82wAng+woyNJipF5TukwyT8exBcaodftNWVwVqwbjJGkcCRb/w kf2ltOHVbUF6AW3lr/GSjSLlBgxP0Sn5cIDFzZ7nfShRUr8/P1ssdM8cVCt8rZqYFNUefxT/PkM0N TdikOAeeWu7W4jtYWS/mrnnxh/o9u2OKHQImejwIRqgNzlZ3g4J8sXQ6Fo4UBzc2kVAeOFYy8xrtX ArHAvCdg==; Received: from mail-il1-x12d.google.com ([2607:f8b0:4864:20::12d]) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lYqVm-00C9Vn-Ng for linux-arm-kernel@lists.infradead.org; Tue, 20 Apr 2021 13:33:58 +0000 Received: by mail-il1-x12d.google.com with SMTP id c3so25904299ils.5 for ; Tue, 20 Apr 2021 06:33:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Xgfc7mO4E1wXWUmekqC8sEt5bIbUy15Zn+YoHQva8NI=; b=PYyvqtFzdzRakpUOqbunR4I7/Lj/8HDyE7lqd9tAm0PNx6Uh1yOIHCDmuaqBR1ViP4 mmStHq4YHDIb9iNLpswctc4T/0gjz0QMypKb9sh/woNGTQHvzByI8qY89af1f2aYk6+S wieFezmrOmmKh35TaWQ/tU2N5mVDzf8HRzVYk= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Xgfc7mO4E1wXWUmekqC8sEt5bIbUy15Zn+YoHQva8NI=; b=mcQ69DWN1UR9qowJrr7IdVey8LJ7KF6/tAjAdF/b9BNy2mFkB86xVln44t8XJL8rCU 5K6EYW6ViL1Y6//MKxOFP5ZSxUQUuB7aePyLnk2O0tLA+vEtUZPEXYLsmKdrdBHzZdpq WBAvvnAt1dsg6BZcUQaYJMjRt9plxV7mAKOOK/nyCDrq1xxNm2JJLGQPx2poZDvZ5OJS WU3Wi5NxN/4qE8A93HZW0z7ZSuy7HjJxgXegXpBxF0OWgFJFgFs9/s5b0HcgSmTJZtpV hA51OBJ9tPNL2DKeIkKddlPKvNfFIgYXIQoB/1ZLiIv5GNTY9EF9jGuaDP62xB9Cy2X3 bvZQ== X-Gm-Message-State: AOAM5329dQSkDjIBs//f6filTxRyVDmOuAJp1wS5NX4cB2SKagPeEkBy 1L3xAFnj+TUWNlw+2zMuJg3Q6YHCkzrEBmvt+/NaRw== X-Google-Smtp-Source: ABdhPJy6RgMFJUk30o3Bp+6VqEWzChzCOkzvaHDVug4JPECZShpDcemglkoDMMwZ/VXKrU9wV09fLSo20xOiZ0XVnHs= X-Received: by 2002:a92:d684:: with SMTP id p4mr22468413iln.150.1618925632435; Tue, 20 Apr 2021 06:33:52 -0700 (PDT) MIME-Version: 1.0 References: <20210414172916.2689361-1-hsinyi@chromium.org> <20210414172916.2689361-5-hsinyi@chromium.org> In-Reply-To: From: Hsin-Yi Wang Date: Tue, 20 Apr 2021 21:33:25 +0800 Message-ID: Subject: Re: [PATCH v19 4/6] misc: eeprom: at24: check suspend status before disable regulator To: Bartosz Golaszewski Cc: Wolfram Sang , Matthias Brugger , Rob Herring , linux-i2c , Qii Wang , linux-devicetree , arm-soc , "moderated list:ARM/Mediatek SoC..." , LKML , Greg Kroah-Hartman , Mark Brown , Marek Szyprowski , Bibby Hsieh , Arnd Bergmann , Jani Nikula , Joonas Lahtinen , intel-gfx@lists.freedesktop.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210420_063354_792382_1C061B14 X-CRM114-Status: GOOD ( 22.54 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Apr 16, 2021 at 10:09 PM Bartosz Golaszewski wrote: > > On Wed, Apr 14, 2021 at 7:29 PM Hsin-Yi Wang wrote: > > > > cd5676db0574 ("misc: eeprom: at24: support pm_runtime control") disables > > regulator in runtime suspend. If runtime suspend is called before > > regulator disable, it will results in regulator unbalanced disabling. > > > > Signed-off-by: Hsin-Yi Wang > > Please add the Fixes tag. > Hi, I resend the patch with the fix tag separately since other patches in this series are not changed. https://patchwork.ozlabs.org/project/linux-i2c/patch/20210420133050.377209-1-hsinyi@chromium.org/ Thanks > > --- > > drivers/misc/eeprom/at24.c | 6 ++++-- > > 1 file changed, 4 insertions(+), 2 deletions(-) > > > > diff --git a/drivers/misc/eeprom/at24.c b/drivers/misc/eeprom/at24.c > > index 926408b41270..7a6f01ace78a 100644 > > --- a/drivers/misc/eeprom/at24.c > > +++ b/drivers/misc/eeprom/at24.c > > @@ -763,7 +763,8 @@ static int at24_probe(struct i2c_client *client) > > at24->nvmem = devm_nvmem_register(dev, &nvmem_config); > > if (IS_ERR(at24->nvmem)) { > > pm_runtime_disable(dev); > > - regulator_disable(at24->vcc_reg); > > + if (!pm_runtime_status_suspended(dev)) > > + regulator_disable(at24->vcc_reg); > > return PTR_ERR(at24->nvmem); > > } > > > > @@ -774,7 +775,8 @@ static int at24_probe(struct i2c_client *client) > > err = at24_read(at24, 0, &test_byte, 1); > > if (err) { > > pm_runtime_disable(dev); > > - regulator_disable(at24->vcc_reg); > > + if (!pm_runtime_status_suspended(dev)) > > + regulator_disable(at24->vcc_reg); > > return -ENODEV; > > } > > > > -- > > 2.31.1.295.g9ea45b61b8-goog > > > > Acked-by: Bartosz Golaszewski _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel