From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9431014E2F5; Fri, 12 Apr 2024 18:11:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712945467; cv=none; b=YnpE69NsX9r8nEjUKhK2Rmh6Wmtl/zegruSKEw4GgH19yEoU+mQnX2TZPuT/80L4kEcaJgHA6G8y7PDJVAFDagYv3QDMlOozMqVK6yE8I52yYAh11POeqQob9gt6PbfSfMkgn2B6ovLaQFpzLR6ZBPRq7l6p5piEnL3POhsCbWc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712945467; c=relaxed/simple; bh=w0Rj2BE2ik1TfBrDf8LZJAbgRfaaZayTzrNsUAR3K2o=; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject: To:Cc:Content-Type; b=m2+0aM1WOg8qSEgCt+S1ol1dY1/smwWMpQx84KUUPXoX69mLjS0c7oBr2HKtV8FuEr2TjAtQvR9KsPADQb0a3IbspfkkQsPcVgBsBhRActwNqkb7n8N6JhVz8i/5UD1zlot0dNJ7+exkX4bOEV9xH35Qugrq1F5ULaiW5WL1u1k= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=KDoa0lyh; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="KDoa0lyh" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 39808C32781; Fri, 12 Apr 2024 18:11:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1712945467; bh=w0Rj2BE2ik1TfBrDf8LZJAbgRfaaZayTzrNsUAR3K2o=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=KDoa0lyhtKdtCX/st2OM4yzUUFYH/wZdlPwfOk+/h8yG51SmuMko1dILZUaYH2o1m zQI3FRfCn/Hn+EN8T9pDEMxHFseYAmF9CSISfO9ZwiJPDeXtTPKj+rDaNAyokflBfS GTG4Dx+gn0cE091MRS9iZmeAxI2qMgvpwdGeEeY42wYLjOTm9feo+Mz2e9S5ZyQb5b ABCjuloula+NpOC95mrh3iqQfkSHIVDusunVEqmZXpMlqjaFIBvcMQ27MtXFcDHNrK +ik/LaCgimMKWnS1KZWhL+Rjs0uyr+OKK5KwxK9aOia+mvN/lXBmGyhG+Ieuo/kg0F rjoNjC118QESA== Received: by mail-oa1-f43.google.com with SMTP id 586e51a60fabf-22f211d761bso40762fac.0; Fri, 12 Apr 2024 11:11:07 -0700 (PDT) X-Forwarded-Encrypted: i=1; AJvYcCUa5gwbFpCROVoXBIOhp7dDWVTuEmSRd30XnVa3QIqDSso9wuOx0NimMocTricRCBb+vsKq+1LKmZKXoZz5w0KyDjn1O61avkdJcv/QyVaxcvUNmH2VJ1MPpo3KixI07liz3D8o+d6Uts/NzQJEB2kKLOjZu0fdh3q6ocpjRRSUo6HXlYE= X-Gm-Message-State: AOJu0YxH6jNr7KHK4CaSEDVuvj4JLWU6ag4HGZHbLiSvvCfVsql6OAU0 uF91aWe74GGaWcEg5eeGXFy4qnCzWguTtn/NjdxXjB+WqWhIYIKHBuxpM+OZLm2Bq7a1dasrnOL baHMjPsveyo9VSDt/Xl4zw6oDKZc= X-Google-Smtp-Source: AGHT+IGKtcKlSO2lFAIq6OKvn2JNPJn0Ga+grmKCMWsQcAXz9raUofNuscAxbTpGInOFPwn5aIKNB4YKf2Ez0fmcZl8= X-Received: by 2002:a05:6870:9a97:b0:22e:6e96:ed41 with SMTP id hp23-20020a0568709a9700b0022e6e96ed41mr3822217oab.2.1712945466524; Fri, 12 Apr 2024 11:11:06 -0700 (PDT) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <20240412143719.11398-1-Jonathan.Cameron@huawei.com> <20240412143719.11398-3-Jonathan.Cameron@huawei.com> In-Reply-To: <20240412143719.11398-3-Jonathan.Cameron@huawei.com> From: "Rafael J. Wysocki" Date: Fri, 12 Apr 2024 20:10:54 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v5 02/18] ACPI: processor: Set the ACPI_COMPANION for the struct cpu instance To: Jonathan Cameron Cc: linux-pm@vger.kernel.org, loongarch@lists.linux.dev, linux-acpi@vger.kernel.org, linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev, x86@kernel.org, Russell King , "Rafael J . Wysocki" , Miguel Luis , James Morse , Salil Mehta , Jean-Philippe Brucker , Catalin Marinas , Will Deacon , linuxarm@huawei.com, justin.he@arm.com, jianyong.wu@arm.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Fri, Apr 12, 2024 at 4:38=E2=80=AFPM Jonathan Cameron wrote: > > The arm64 specific arch_register_cpu() needs to access the _STA > method of the DSDT object so make it available by assigning the > appropriate handle to the struct cpu instance. > > Signed-off-by: Jonathan Cameron > --- > drivers/acpi/acpi_processor.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/acpi/acpi_processor.c b/drivers/acpi/acpi_processor.= c > index 7a0dd35d62c9..93e029403d05 100644 > --- a/drivers/acpi/acpi_processor.c > +++ b/drivers/acpi/acpi_processor.c > @@ -235,6 +235,7 @@ static int acpi_processor_get_info(struct acpi_device= *device) > union acpi_object object =3D { 0 }; > struct acpi_buffer buffer =3D { sizeof(union acpi_object), &objec= t }; > struct acpi_processor *pr =3D acpi_driver_data(device); > + struct cpu *c; > int device_declaration =3D 0; > acpi_status status =3D AE_OK; > static int cpu0_initialized; > @@ -314,6 +315,8 @@ static int acpi_processor_get_info(struct acpi_device= *device) > cpufreq_add_device("acpi-cpufreq"); > } > > + c =3D &per_cpu(cpu_devices, pr->id); > + ACPI_COMPANION_SET(&c->dev, device); This is also set for per_cpu(cpu_sys_devices, pr->id) in acpi_processor_add(), via acpi_bind_one(). Moreover, there is some pr->id validation in acpi_processor_add(), so it seems premature to use it here this way. I think that ACPI_COMPANION_SET() should be called from here on per_cpu(cpu_sys_devices, pr->id) after validating pr->id (so the pr->id validation should all be done here) and then NULL can be passed as acpi_dev to acpi_bind_one() in acpi_processor_add(). Then, there will be one physical device corresponding to the processor ACPI device and no confusion. > /* > * Extra Processor objects may be enumerated on MP systems with > * less than the max # of CPUs. They should be ignored _iff > -- > 2.39.2 > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9B9C3C00A94 for ; Fri, 12 Apr 2024 18:11:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=yCTrlb5xoFDlrODaRAnU1Se+sKLxN3/HOVj34G1pTi4=; b=EjLz4k0/a4rlwr 85WixZL/lR6bHmStCaKhpvJPOybW8inPQBupGt2qlPNfWGNiy5UF0y4j2HUlIu1IjypQGoeIG6RVp DzHE+eJnCDTmAbwTKfwNSdVyzk8JZ7QGiUs1cc3FjWq8eiyYWY8hnYiuALxUblqHjIDDe5k0VQUTL XVFNC3H0p8BkNrt+MtNO4R2rwJOYqQddGDtev6TjpqInGnJxfISHqUrGYWnLBqBnIC+Mb0Qivxkjr mckkHv5FrtSI9kShQGt9YPGNwk7IEASob4swz3W8AWH9j3B3+ALmLddz5ONdMp74OK1otSnOVasJQ DZDK/UKPw9b9to2DGXgQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rvLMl-00000000nmq-1nz4; Fri, 12 Apr 2024 18:11:11 +0000 Received: from dfw.source.kernel.org ([139.178.84.217]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rvLMi-00000000nlE-2FZJ for linux-arm-kernel@lists.infradead.org; Fri, 12 Apr 2024 18:11:09 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 9EF4261455 for ; Fri, 12 Apr 2024 18:11:07 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 43BEDC4AF07 for ; Fri, 12 Apr 2024 18:11:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1712945467; bh=w0Rj2BE2ik1TfBrDf8LZJAbgRfaaZayTzrNsUAR3K2o=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=KDoa0lyhtKdtCX/st2OM4yzUUFYH/wZdlPwfOk+/h8yG51SmuMko1dILZUaYH2o1m zQI3FRfCn/Hn+EN8T9pDEMxHFseYAmF9CSISfO9ZwiJPDeXtTPKj+rDaNAyokflBfS GTG4Dx+gn0cE091MRS9iZmeAxI2qMgvpwdGeEeY42wYLjOTm9feo+Mz2e9S5ZyQb5b ABCjuloula+NpOC95mrh3iqQfkSHIVDusunVEqmZXpMlqjaFIBvcMQ27MtXFcDHNrK +ik/LaCgimMKWnS1KZWhL+Rjs0uyr+OKK5KwxK9aOia+mvN/lXBmGyhG+Ieuo/kg0F rjoNjC118QESA== Received: by mail-oa1-f48.google.com with SMTP id 586e51a60fabf-22f211d761bso40764fac.0 for ; Fri, 12 Apr 2024 11:11:07 -0700 (PDT) X-Forwarded-Encrypted: i=1; AJvYcCWFMnDYlbh8eBLeNcGkjTgjKUnuFcruN+qUkz/cHTVD2427M5+jSTIjirJ3Ird4vEbh9h/2ThhOAJZd5WCwT3WnkB381bcwrY9GUGJtDBICYG5Sp3c= X-Gm-Message-State: AOJu0YyqCH8El10AInh5C5TndaxeP8s/3CzXumgaD10LYYfSbvEN9les 3RgXE9z59qkiv7e+EhML8o4lLm0HJm9Ua3DvL8cCWor8I4WnWUQYqIqbWDqCFWusV8g0+TvIIR3 KemufV2kI6K6L4WfvnEutKSPukKg= X-Google-Smtp-Source: AGHT+IGKtcKlSO2lFAIq6OKvn2JNPJn0Ga+grmKCMWsQcAXz9raUofNuscAxbTpGInOFPwn5aIKNB4YKf2Ez0fmcZl8= X-Received: by 2002:a05:6870:9a97:b0:22e:6e96:ed41 with SMTP id hp23-20020a0568709a9700b0022e6e96ed41mr3822217oab.2.1712945466524; Fri, 12 Apr 2024 11:11:06 -0700 (PDT) MIME-Version: 1.0 References: <20240412143719.11398-1-Jonathan.Cameron@huawei.com> <20240412143719.11398-3-Jonathan.Cameron@huawei.com> In-Reply-To: <20240412143719.11398-3-Jonathan.Cameron@huawei.com> From: "Rafael J. Wysocki" Date: Fri, 12 Apr 2024 20:10:54 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v5 02/18] ACPI: processor: Set the ACPI_COMPANION for the struct cpu instance To: Jonathan Cameron Cc: linux-pm@vger.kernel.org, loongarch@lists.linux.dev, linux-acpi@vger.kernel.org, linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev, x86@kernel.org, Russell King , "Rafael J . Wysocki" , Miguel Luis , James Morse , Salil Mehta , Jean-Philippe Brucker , Catalin Marinas , Will Deacon , linuxarm@huawei.com, justin.he@arm.com, jianyong.wu@arm.com X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240412_111108_692381_2F4424E9 X-CRM114-Status: GOOD ( 20.82 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gRnJpLCBBcHIgMTIsIDIwMjQgYXQgNDozOOKAr1BNIEpvbmF0aGFuIENhbWVyb24KPEpvbmF0 aGFuLkNhbWVyb25AaHVhd2VpLmNvbT4gd3JvdGU6Cj4KPiBUaGUgYXJtNjQgc3BlY2lmaWMgYXJj aF9yZWdpc3Rlcl9jcHUoKSBuZWVkcyB0byBhY2Nlc3MgdGhlIF9TVEEKPiBtZXRob2Qgb2YgdGhl IERTRFQgb2JqZWN0IHNvIG1ha2UgaXQgYXZhaWxhYmxlIGJ5IGFzc2lnbmluZyB0aGUKPiBhcHBy b3ByaWF0ZSBoYW5kbGUgdG8gdGhlIHN0cnVjdCBjcHUgaW5zdGFuY2UuCj4KPiBTaWduZWQtb2Zm LWJ5OiBKb25hdGhhbiBDYW1lcm9uIDxKb25hdGhhbi5DYW1lcm9uQGh1YXdlaS5jb20+Cj4gLS0t Cj4gIGRyaXZlcnMvYWNwaS9hY3BpX3Byb2Nlc3Nvci5jIHwgMyArKysKPiAgMSBmaWxlIGNoYW5n ZWQsIDMgaW5zZXJ0aW9ucygrKQo+Cj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvYWNwaS9hY3BpX3By b2Nlc3Nvci5jIGIvZHJpdmVycy9hY3BpL2FjcGlfcHJvY2Vzc29yLmMKPiBpbmRleCA3YTBkZDM1 ZDYyYzkuLjkzZTAyOTQwM2QwNSAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2FjcGkvYWNwaV9wcm9j ZXNzb3IuYwo+ICsrKyBiL2RyaXZlcnMvYWNwaS9hY3BpX3Byb2Nlc3Nvci5jCj4gQEAgLTIzNSw2 ICsyMzUsNyBAQCBzdGF0aWMgaW50IGFjcGlfcHJvY2Vzc29yX2dldF9pbmZvKHN0cnVjdCBhY3Bp X2RldmljZSAqZGV2aWNlKQo+ICAgICAgICAgdW5pb24gYWNwaV9vYmplY3Qgb2JqZWN0ID0geyAw IH07Cj4gICAgICAgICBzdHJ1Y3QgYWNwaV9idWZmZXIgYnVmZmVyID0geyBzaXplb2YodW5pb24g YWNwaV9vYmplY3QpLCAmb2JqZWN0IH07Cj4gICAgICAgICBzdHJ1Y3QgYWNwaV9wcm9jZXNzb3Ig KnByID0gYWNwaV9kcml2ZXJfZGF0YShkZXZpY2UpOwo+ICsgICAgICAgc3RydWN0IGNwdSAqYzsK PiAgICAgICAgIGludCBkZXZpY2VfZGVjbGFyYXRpb24gPSAwOwo+ICAgICAgICAgYWNwaV9zdGF0 dXMgc3RhdHVzID0gQUVfT0s7Cj4gICAgICAgICBzdGF0aWMgaW50IGNwdTBfaW5pdGlhbGl6ZWQ7 Cj4gQEAgLTMxNCw2ICszMTUsOCBAQCBzdGF0aWMgaW50IGFjcGlfcHJvY2Vzc29yX2dldF9pbmZv KHN0cnVjdCBhY3BpX2RldmljZSAqZGV2aWNlKQo+ICAgICAgICAgICAgICAgICAgICAgICAgIGNw dWZyZXFfYWRkX2RldmljZSgiYWNwaS1jcHVmcmVxIik7Cj4gICAgICAgICB9Cj4KPiArICAgICAg IGMgPSAmcGVyX2NwdShjcHVfZGV2aWNlcywgcHItPmlkKTsKPiArICAgICAgIEFDUElfQ09NUEFO SU9OX1NFVCgmYy0+ZGV2LCBkZXZpY2UpOwoKVGhpcyBpcyBhbHNvIHNldCBmb3IgcGVyX2NwdShj cHVfc3lzX2RldmljZXMsIHByLT5pZCkgaW4KYWNwaV9wcm9jZXNzb3JfYWRkKCksIHZpYSBhY3Bp X2JpbmRfb25lKCkuCgpNb3Jlb3ZlciwgdGhlcmUgaXMgc29tZSBwci0+aWQgdmFsaWRhdGlvbiBp biBhY3BpX3Byb2Nlc3Nvcl9hZGQoKSwgc28KaXQgc2VlbXMgcHJlbWF0dXJlIHRvIHVzZSBpdCBo ZXJlIHRoaXMgd2F5LgoKSSB0aGluayB0aGF0IEFDUElfQ09NUEFOSU9OX1NFVCgpIHNob3VsZCBi ZSBjYWxsZWQgZnJvbSBoZXJlIG9uCnBlcl9jcHUoY3B1X3N5c19kZXZpY2VzLCBwci0+aWQpIGFm dGVyIHZhbGlkYXRpbmcgcHItPmlkIChzbyB0aGUKcHItPmlkIHZhbGlkYXRpb24gc2hvdWxkIGFs bCBiZSBkb25lIGhlcmUpIGFuZCB0aGVuIE5VTEwgY2FuIGJlIHBhc3NlZAphcyBhY3BpX2RldiB0 byBhY3BpX2JpbmRfb25lKCkgaW4gYWNwaV9wcm9jZXNzb3JfYWRkKCkuICBUaGVuLCB0aGVyZQp3 aWxsIGJlIG9uZSBwaHlzaWNhbCBkZXZpY2UgY29ycmVzcG9uZGluZyB0byB0aGUgcHJvY2Vzc29y IEFDUEkgZGV2aWNlCmFuZCBubyBjb25mdXNpb24uCgo+ICAgICAgICAgLyoKPiAgICAgICAgICAq ICBFeHRyYSBQcm9jZXNzb3Igb2JqZWN0cyBtYXkgYmUgZW51bWVyYXRlZCBvbiBNUCBzeXN0ZW1z IHdpdGgKPiAgICAgICAgICAqICBsZXNzIHRoYW4gdGhlIG1heCAjIG9mIENQVXMuIFRoZXkgc2hv dWxkIGJlIGlnbm9yZWQgX2lmZgo+IC0tCj4gMi4zOS4yCj4KCl9fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fCmxpbnV4LWFybS1rZXJuZWwgbWFpbGluZyBsaXN0 CmxpbnV4LWFybS1rZXJuZWxAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFk ZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LWFybS1rZXJuZWwK