From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.0 required=3.0 tests=BAYES_00,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2994EC4338F for ; Tue, 24 Aug 2021 22:21:38 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 01A6C613A7 for ; Tue, 24 Aug 2021 22:21:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237124AbhHXWWV (ORCPT ); Tue, 24 Aug 2021 18:22:21 -0400 Received: from mail-ed1-f44.google.com ([209.85.208.44]:34680 "EHLO mail-ed1-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235429AbhHXWWU (ORCPT ); Tue, 24 Aug 2021 18:22:20 -0400 Received: by mail-ed1-f44.google.com with SMTP id i6so33948763edu.1 for ; Tue, 24 Aug 2021 15:21:35 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=FLwSD+gDmLT1RphYbTsuKoaMUozofhn069mfJRCz5Xs=; b=G16s96oL45n2iBHnrUctqcsx2N5yjPakOqa19dTnb7KA00pdh+xLgWFVOZncHl97LO wkwjbYMkr3ThJ3Qzd2fQ+d0WSlssqdEx4n7fGO3dKglMJSLS0ZDDXixUrfOHoh06nn8h yFghrLbqI9vL5BzSVZpwA0e0RdC/vSJmoZJTJDK3jw3OI+1WWx+PoE3ytWX8fbsdc2au WD5BKzIEklLYWlzzqt489O7fIE93gv2MwLEepEaIiGfNOx8L9rE+u9o2JhccLDoe/zmS 5htGjzHFYm64GiCrAJwQDrM8nEMKZm7isQk51RKClMvaAQ5T1FsfPGAhdRYPbwMEFFhD yyXQ== X-Gm-Message-State: AOAM533IZcawjN1fnlm2ciBoK9qLxnW0AnledWsZOyWtNdMzvZjmBbHn QBayu5Hm+NbFjtOxQTCgjUshHMK5inrbHwz73HL62JKa45k= X-Google-Smtp-Source: ABdhPJxrPeDOIXMIcDR6MXSFL4BV4V58OMGyz/+6rcgwUwKhzqvQIe2GNoamOnQpjF8wDkWGHRwmKvYTpMoXkeM2HV8= X-Received: by 2002:a05:6402:27c6:: with SMTP id c6mr14872830ede.111.1629843694867; Tue, 24 Aug 2021 15:21:34 -0700 (PDT) MIME-Version: 1.0 References: <20210730145957.7927-1-chang.seok.bae@intel.com> <20210730145957.7927-13-chang.seok.bae@intel.com> In-Reply-To: From: Len Brown Date: Tue, 24 Aug 2021 18:21:23 -0400 Message-ID: Subject: Re: [PATCH v9 12/26] x86/fpu/xstate: Use feature disable (XFD) to protect dynamic user state To: Borislav Petkov Cc: "Chang S. Bae" , Andy Lutomirski , Thomas Gleixner , Ingo Molnar , X86 ML , "Brown, Len" , Dave Hansen , thiago.macieira@intel.com, "Liu, Jing2" , "Ravi V. Shankar" , Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Aug 18, 2021 at 12:24 PM Borislav Petkov wrote: > > diff --git a/arch/x86/include/asm/msr-index.h b/arch/x86/include/asm/msr-index.h > > index a7c413432b33..eac0cfd9210b 100644 > > --- a/arch/x86/include/asm/msr-index.h > > +++ b/arch/x86/include/asm/msr-index.h > > @@ -626,6 +626,8 @@ > > #define MSR_IA32_BNDCFGS_RSVD 0x00000ffc > > > > #define MSR_IA32_XSS 0x00000da0 > > +#define MSR_IA32_XFD 0x000001c4 > > +#define MSR_IA32_XFD_ERR 0x000001c5 > > At least try to keep those numerically sorted, at least among the > architectural MSR_IA32_ ones. agreed > That is, provided those XFD things are architectural... Yes. MSR_IA32_XFD and MSR_IA32_XFD_ERR are architectural. (which is why they follow the convention of having an "IA32" in their name) https://software.intel.com/content/www/us/en/develop/download/intel-architecture-instruction-set-extensions-programming-reference.html Len Brown, Intel Open Source Technology Center