From: Lance Yang <ioworker0@gmail.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Matthew Wilcox <willy@infradead.org>,
maskray@google.com, ziy@nvidia.com, ryan.roberts@arm.com,
david@redhat.com, 21cnbao@gmail.com, mhocko@suse.com,
fengwei.yin@intel.com, zokeefe@google.com, shy828301@gmail.com,
xiehuan09@gmail.com, wangkefeng.wang@huawei.com,
songmuchun@bytedance.com, peterx@redhat.com, minchan@kernel.org,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/1] mm/vmscan: avoid split PMD-mapped THP during shrink_folio_list()
Date: Thu, 25 Apr 2024 12:19:45 +0800 [thread overview]
Message-ID: <CAK1f24m2fR5EynwBN64Nuhcgctbd2RLXjLx7W_H+uywKLLO+cQ@mail.gmail.com> (raw)
In-Reply-To: <20240424142009.149eb988cca33822ce0fd0f1@linux-foundation.org>
On Thu, Apr 25, 2024 at 5:20 AM Andrew Morton <akpm@linux-foundation.org> wrote:
>
> On Wed, 24 Apr 2024 23:46:59 +0800 Lance Yang <ioworker0@gmail.com> wrote:
>
> > On Wed, Apr 24, 2024 at 12:15 PM Matthew Wilcox <willy@infradead.org> wrote:
> > >
> > > On Mon, Apr 22, 2024 at 01:52:13PM +0800, Lance Yang wrote:
> > > > When the user no longer requires the pages, they would use
> > > > madvise(MADV_FREE) to mark the pages as lazy free. IMO, they would not
> > > > typically rewrite to the given range.
> > > >
> > > > At present, PMD-mapped THPs that are marked as lazyfree during
> > > > shrink_folio_list() are unconditionally split, which may be unnecessary.
> > > > If the THP is clean, its PMD is also clean, and there are no unexpected
> >
> > "If the THP is clean, its PMD is also clean" can be confusing - sorry. It should
> > be modified to "If the THP and its PMD are both marked as clean".
>
> I made that changelog edit.
Thanks for updating, Andrew!
Lance
prev parent reply other threads:[~2024-04-25 4:19 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-22 5:52 [PATCH v2 1/1] mm/vmscan: avoid split PMD-mapped THP during shrink_folio_list() Lance Yang
2024-04-24 4:15 ` Matthew Wilcox
2024-04-24 7:17 ` David Hildenbrand
2024-04-24 15:57 ` Zi Yan
2024-04-24 15:58 ` David Hildenbrand
2024-04-25 4:17 ` Lance Yang
2024-04-25 8:50 ` Lance Yang
2024-04-25 9:01 ` David Hildenbrand
2024-04-25 9:21 ` Lance Yang
2024-04-25 9:25 ` David Hildenbrand
2024-04-25 12:00 ` Lance Yang
2024-04-24 15:46 ` Lance Yang
2024-04-24 21:20 ` Andrew Morton
2024-04-25 4:19 ` Lance Yang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAK1f24m2fR5EynwBN64Nuhcgctbd2RLXjLx7W_H+uywKLLO+cQ@mail.gmail.com \
--to=ioworker0@gmail.com \
--cc=21cnbao@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=david@redhat.com \
--cc=fengwei.yin@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=maskray@google.com \
--cc=mhocko@suse.com \
--cc=minchan@kernel.org \
--cc=peterx@redhat.com \
--cc=ryan.roberts@arm.com \
--cc=shy828301@gmail.com \
--cc=songmuchun@bytedance.com \
--cc=wangkefeng.wang@huawei.com \
--cc=willy@infradead.org \
--cc=xiehuan09@gmail.com \
--cc=ziy@nvidia.com \
--cc=zokeefe@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.