From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7D8D8C4707A for ; Fri, 21 May 2021 18:31:41 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 43CE561163 for ; Fri, 21 May 2021 18:31:41 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 43CE561163 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ffwll.ch Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=intel-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 3B97D6F8D3; Fri, 21 May 2021 18:31:36 +0000 (UTC) Received: from mail-ot1-x331.google.com (mail-ot1-x331.google.com [IPv6:2607:f8b0:4864:20::331]) by gabe.freedesktop.org (Postfix) with ESMTPS id 1B1806F8CF for ; Fri, 21 May 2021 18:31:30 +0000 (UTC) Received: by mail-ot1-x331.google.com with SMTP id t10-20020a05683022eab0290304ed8bc759so18847281otc.12 for ; Fri, 21 May 2021 11:31:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ffwll.ch; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=ssQbWaPKNXku5OPbuQHoPwspEJ/tPkBoh9sAADSrhpE=; b=Uu9hQaJ8bKy4+fr0LTNS3umKVdn2pBLHZTC89+aOZqisuEDloE2AHdKVFw/L4GscOe 7QcjqpKQBCMOwKXyjfLKRblL5u2LxNv4W3W0bb2NsOkl6qO+W61qzrL2bwCO/GtDdLKF V9Z8g06gg5IAQ1e9Fy1CG3HrP7gBiT27yp15o= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=ssQbWaPKNXku5OPbuQHoPwspEJ/tPkBoh9sAADSrhpE=; b=B2tJR4nxNPlWKPjtyamjmPJfyNwNI56RinZTOFwTp83M8Uu5p3FeApjal19zGpG41M 2GpIfAQ04UHVpV+ZaIKaiT/3nhLpLlw/jTrTiX7poQvSyA73n6N9Et7ZPiyhPsN/LSba Ym2xp+HAZ4kpuA7XAfUJIMcmaVtPanKjPK9V8XbGx6awWJOF7pFI1EmqlhYUuZW2mbv/ Hk+TwpGPqLANA8kfDA9Dv++3K6EbDLvhNT2VMHULSnBxBgErT+ywmWrdZlkDq0pfaXZb IxD942p+YVqW7m9+yivVDkAB7bmP8XsQ01FmuR58hPat1koRcRNKBcZzgBBDDQsSwyfz nyKA== X-Gm-Message-State: AOAM530DB8IynFr0gtcf/3uOkz2sotABZTPB3TtwS9xAyYDB9YQv4AsU GrIMoa3JV4X412DFFOz+y1PWytHj0+u/JPWZ4wXskg== X-Google-Smtp-Source: ABdhPJzhfhr27C49nXr2j3YFwIcmfU6rMWfQl0gg9HCxKinGNWcpaTBpO3xe8YnDGQ5ZqRzBbnoGYtfER8u6/HY6jLY= X-Received: by 2002:a9d:8ce:: with SMTP id 72mr9332384otf.188.1621621889460; Fri, 21 May 2021 11:31:29 -0700 (PDT) MIME-Version: 1.0 References: <20210521090959.1663703-1-daniel.vetter@ffwll.ch> <31467363-e936-879b-8b0d-5a2a92644221@gmail.com> In-Reply-To: <31467363-e936-879b-8b0d-5a2a92644221@gmail.com> From: Daniel Vetter Date: Fri, 21 May 2021 20:31:18 +0200 Message-ID: To: =?UTF-8?Q?Christian_K=C3=B6nig?= Subject: Re: [Intel-gfx] [Mesa-dev] [PATCH 01/11] drm/amdgpu: Comply with implicit fencing rules X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Rob Clark , Daniel Stone , =?UTF-8?Q?Michel_D=C3=A4nzer?= , Intel Graphics Development , Kevin Wang , DRI Development , Sumit Semwal , "moderated list:DMA BUFFER SHARING FRAMEWORK" , Luben Tuikov , "Kristian H . Kristensen" , Chen Li , Bas Nieuwenhuizen , Alex Deucher , Daniel Vetter , mesa-dev , =?UTF-8?Q?Christian_K=C3=B6nig?= , Dennis Li , Deepak R Varma Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" T24gRnJpLCBNYXkgMjEsIDIwMjEgYXQgODowOCBQTSBDaHJpc3RpYW4gS8O2bmlnCjxja29lbmln LmxlaWNodHp1bWVya2VuQGdtYWlsLmNvbT4gd3JvdGU6Cj4KPiBBbSAyMS4wNS4yMSB1bSAxNzox NiBzY2hyaWViIERhbmllbCBWZXR0ZXI6Cj4gPiBPbiBGcmksIE1heSAyMSwgMjAyMSBhdCAwNTow MDo0NlBNICswMjAwLCBCYXMgTmlldXdlbmh1aXplbiB3cm90ZToKPiA+PiBPbiBGcmksIE1heSAy MSwgMjAyMSBhdCA0OjM3IFBNIERhbmllbCBWZXR0ZXIgPGRhbmllbEBmZndsbC5jaD4gd3JvdGU6 Cj4gPj4+IE9uIEZyaSwgTWF5IDIxLCAyMDIxIGF0IDExOjQ2OjIzQU0gKzAyMDAsIEJhcyBOaWV1 d2VuaHVpemVuIHdyb3RlOgo+ID4+Pj4gT24gRnJpLCBNYXkgMjEsIDIwMjEgYXQgMTE6MTAgQU0g RGFuaWVsIFZldHRlciA8ZGFuaWVsLnZldHRlckBmZndsbC5jaD4gd3JvdGU6Cj4gPj4+Pj4gLS0t Cj4gPj4+Pj4gICBkcml2ZXJzL2dwdS9kcm0vYW1kL2FtZGdwdS9hbWRncHVfY3MuYyB8IDQgKyst LQo+ID4+Pj4+ICAgMSBmaWxlIGNoYW5nZWQsIDIgaW5zZXJ0aW9ucygrKSwgMiBkZWxldGlvbnMo LSkKPiA+Pj4+Pgo+ID4+Pj4+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vYW1kL2FtZGdw dS9hbWRncHVfY3MuYyBiL2RyaXZlcnMvZ3B1L2RybS9hbWQvYW1kZ3B1L2FtZGdwdV9jcy5jCj4g Pj4+Pj4gaW5kZXggODhhMjRhMGI1NjkxLi5jYzg0MjZlMWU4YTggMTAwNjQ0Cj4gPj4+Pj4gLS0t IGEvZHJpdmVycy9ncHUvZHJtL2FtZC9hbWRncHUvYW1kZ3B1X2NzLmMKPiA+Pj4+PiArKysgYi9k cml2ZXJzL2dwdS9kcm0vYW1kL2FtZGdwdS9hbWRncHVfY3MuYwo+ID4+Pj4+IEBAIC02MTcsOCAr NjE3LDggQEAgc3RhdGljIGludCBhbWRncHVfY3NfcGFyc2VyX2JvcyhzdHJ1Y3QgYW1kZ3B1X2Nz X3BhcnNlciAqcCwKPiA+Pj4+PiAgICAgICAgICBhbWRncHVfYm9fbGlzdF9mb3JfZWFjaF9lbnRy eShlLCBwLT5ib19saXN0KSB7Cj4gPj4+Pj4gICAgICAgICAgICAgICAgICBzdHJ1Y3QgYW1kZ3B1 X2JvICpibyA9IHR0bV90b19hbWRncHVfYm8oZS0+dHYuYm8pOwo+ID4+Pj4+Cj4gPj4+Pj4gLSAg ICAgICAgICAgICAgIC8qIE1ha2Ugc3VyZSB3ZSB1c2UgdGhlIGV4Y2x1c2l2ZSBzbG90IGZvciBz aGFyZWQgQk9zICovCj4gPj4+Pj4gLSAgICAgICAgICAgICAgIGlmIChiby0+cHJpbWVfc2hhcmVk X2NvdW50KQo+ID4+Pj4+ICsgICAgICAgICAgICAgICAvKiBNYWtlIHN1cmUgd2UgdXNlIHRoZSBl eGNsdXNpdmUgc2xvdCBmb3IgYWxsIHBvdGVudGlhbGx5IHNoYXJlZCBCT3MgKi8KPiA+Pj4+PiAr ICAgICAgICAgICAgICAgaWYgKCEoYm8tPmZsYWdzICYgQU1ER1BVX0dFTV9DUkVBVEVfVk1fQUxX QVlTX1ZBTElEKSkKPiA+Pj4+PiAgICAgICAgICAgICAgICAgICAgICAgICAgZS0+dHYubnVtX3No YXJlZCA9IDA7Cj4gPj4+PiBJIHRoaW5rIGl0IGFsc28gbWFrZXMgc2Vuc2UgdG8gc2tpcCB0aGlz IHdpdGgKPiA+Pj4+IEFNREdQVV9HRU1fQ1JFQVRFX0VYUExJQ0lUX1NZTkM/IEl0IGNhbiBiZSBz aGFyZWQgYnV0IEkgZG9uJ3QgdGhpbmsKPiA+Pj4+IGFueW9uZSBleHBlY3RzIGltcGxpY2l0IHN5 bmMgdG8gaGFwcGVuIHdpdGggdGhvc2UuCj4gPj4+IEFoIHllcywgSSBtaXNzZWQgdGhpcyBlbnRp cmVseS4gU28gdGhlICJubyBpbXBsaWNpdCBmbGFnIiBpcyBhbHJlYWR5Cj4gPj4+IHRoZXJlLCBh bmQgdGhlIF9vbmx5XyB0aGluZyB0aGF0J3MgbWlzc2luZyByZWFsbHkgaXMgYSB3YXkgdG8gZmlz aCBvdXQgdGhlCj4gPj4+IGltcGxpY2l0IGZlbmNlcywgYW5kIHNldCB0aGVtLgo+ID4+Pgo+ID4+ PiBodHRwczovL2xvcmUua2VybmVsLm9yZy9kcmktZGV2ZWwvMjAyMTA1MjAxOTAwMDcuNTM0MDQ2 LTEtamFzb25Aamxla3N0cmFuZC5uZXQvCj4gPj4+Cj4gPj4+IFNvIEkgdGhpbmsgYWxsIHRoYXQn cyByZWFsbHkgbmVlZGVkIGluIHJhZHYgaXMgbm90IHNldHRpbmcKPiA+Pj4gUkFERU9OX0ZMQUdf SU1QTElDSVRfU1lOQyBmb3Igd2luc3lzIGJ1ZmZlcnMgd2hlbiBKYXNvbidzIGRtYS1idWYgaW9j dGwKPiA+Pj4gYXJlIHByZXNlbnQgKG1lYW5zIHlvdSBuZWVkIHRvIGRvIHNvbWUgaW1wb3J0L2V4 cG9ydCBhbmQga2VlcCB0aGUgZmQKPiA+Pj4gYXJvdW5kIGZvciB3aW5zeXMgYnVmZmVycywgYnV0 IHNob3VsZG4ndCBiZSB0b28gYmFkKSwgYW5kIHRoZW4gY29udHJvbCB0aGUKPiA+Pj4gaW1wbGlj aXQgZmVuY2VzIGVudGlyZWx5IGV4cGxpY2l0bHkgbGlrZSB2ayBleHBlY3RzLgo+ID4+IFRoYXQg aXMgdGhlIHBhcnQgSSdtIGxlc3Mgc3VyZSBhYm91dC4gVGhpcyBpcyBhIEJPIHdpZGUgZmxhZyBz byB3ZSBhcmUKPiA+PiBhbHNvIGRpc2FibGluZyBpbXBsaWNpdCBzeW5jIGluIHRoZSBjb21wb3Np dG9yLiBJZiB0aGUgY29tcG9zaXRvciBkb2VzCj4gPj4gb25seSBkbyByZWFkIHN0dWZmIHRoYXQg aXMgb2ssIGFzIHRoZSBpbnNlcnRlZCBleGNsdXNpdmUgZmVuY2Ugd2lsbAo+ID4+IHdvcmsgZm9y IHRoYXQuIEJ1dCBhcyBJIGxlYXJuZWQgcmVjZW50bHkgdGhlIGFwcCBwcm92aWRlZCBidWZmZXIg bWF5Cj4gPj4gZW5kIHVwIGJlaW5nIHdyaXR0ZW4gdG8gYnkgdGhlIFggc2VydmVyIHdoaWNoIG9w ZW4gYSB3aG9sZSBjYW4gb2YKPiA+PiBwb3RlbnRpYWwgcHJvYmxlbXMgaWYgaW1wbGljaXQgc3lu YyBnZXRzIGRpc2FibGVkIGJldHdlZW4gWHNlcnZlcgo+ID4+IG9wZXJhdGlvbnMgb24gdGhlIGFw cCBwcm92aWRlZCBidWZmZXIuIEhlbmNlIHNldHRpbmcgdGhhdCBvbiB0aGUgV1NJCj4gPj4gYnVm ZmVyIGlzIGEgd2hvbGUgbmV3IGNhbiBvZiBwb3RlbnRpYWwgcHJvYmxlbXMgYW5kIGhlbmNlIEkn dmUgc2FpZCBhCj4gPj4gc3VibWlzc2lvbiBiYXNlZCBmbGFnIHdvdWxkIGJlIHByZWZlcnJlZC4K PiA+Pgo+ID4+IEkgY2FuIGNlcnRhaW5seSB0cnkgaXQgb3V0IHRob3VnaC4KPiA+IEhtIHllYWgg dGhhdCdzIHRoZSB3cm9uZyBmbGFnLiBXZSBuZWVkIGEgZmxhZyBvbiB0aGUgZHJtX2ZpbGUgd2hp Y2ggdGhlCj4gPiBleHBsaWNpdCB1c2Vyc3BhY2Ugc2V0cy4gQW5kIHdoaWNoIGlzIHZhbGlkIG9u bHkgZm9yIGl0c2VsZi4KPiA+Cj4gPiBUaGVyZSdzIGEgbmljZSBmbGFncyBmaWVsZCB3aGVuIGNy ZWF0aW5nIGEgY3R4LCBidXQgaXQncyBub3QgdmFsaWRhdGVkIGFuZAo+ID4gdGhlcmUncyBhbHJl YWR5IGEgY29tbWVudCB0aGF0IHdlIGhhdmUgdG8gZmlsdGVyIG91dCBnYXJiYWdlIHByaW9yaXR5 LCBzbwo+ID4gdGhhdCdzIG5vdCB1c2UuIEknbGwgd2hpcCB1cCBzb21ldGhpbmcgZW50aXJlbHkg dW50ZXN0ZWQganVzdCBhcyBhIGRyYWZ0Lgo+Cj4gV2UgY291bGQgcHJvdmlkZSBhbiBJT0NUTCBm b3IgdGhlIEJPIHRvIGNoYW5nZSB0aGUgZmxhZy4KClRoYXQncyBub3QgdGhlIHNlbWFudGljcyB3 ZSBuZWVkLgoKPiBCdXQgY291bGQgd2UgZmlyc3QgZmlndXJlIG91dCB0aGUgc2VtYW50aWNzIHdl IHdhbnQgdG8gdXNlIGhlcmU/Cj4KPiBDYXVzZSBJJ20gcHJldHR5IHN1cmUgd2UgZG9uJ3QgYWN0 dWFsbHkgbmVlZCB0aG9zZSBjaGFuZ2VzIGF0IGFsbCBhbmQgYXMKPiBzYWlkIGJlZm9yZSBJJ20g Y2VydGFpbmx5IE5BS2luZyB0aGluZ3Mgd2hpY2ggYnJlYWsgZXhpc3RpbmcgdXNlIGNhc2VzLgoK UGxlYXNlIHJlYWQgaG93IG90aGVyIGRyaXZlcnMgZG8gdGhpcyBhbmQgYXQgbGVhc3QgX3RyeV8g dG8gdW5kZXJzdGFuZAppdC4gSSdtIHJlYWxseSBsb29zaW5nIG15IHBhdGllbmNlIGhlcmUgd2l0 aCB5b3UgTkFLaW5nIHBhdGNoZXMgeW91J3JlCm5vdCBldmVuIHVuZGVyc3RhbmRpbmcgKG9yIGRp ZCB5b3UgYWN0dWFsbHkgcmVhZCBhbmQgZnVsbHkgdW5kZXJzdGFuZAp0aGUgZW50aXJlIHN0b3J5 IEkgdHlwZWQgdXAgaGVyZSwgYW5kIHlvdXIgTkFLIGlzIG9uIHRoZSBlbnRpcmUKdGhpbmc/KS4g VGhlcmUncyBub3QgbXVjaCB1c2VmdWwgY29udmVyc2F0aW9uIHRvIGJlIGhhZCB3aXRoIHRoYXQK YXBwcm9hY2guIEFuZCB3aXRoIGRyaXZlcnMgSSBtZWFuIGtlcm5lbCArIHVzZXJzcGFjZSBoZXJl LgoKVGhhdCdzIHRoZSBvdGhlciBmcnVzdHJhdGlvbiBwYXJ0OiBZb3UncmUgdHJ5aW5nIHRvIGZp eCB0aGlzIHB1cmVseSBpbgp0aGUga2VybmVsLiBUaGlzIGlzIGV4YWN0bHkgb25lIG9mIHRoZXNl IGlzc3VlcyB3aHkgd2UgcmVxdWlyZSBvcGVuCnNvdXJjZSB1c2Vyc3BhY2UsIHNvIHRoYXQgd2Ug Y2FuIGZpeCB0aGUgaXNzdWVzIGNvcnJlY3RseSBhY3Jvc3MgdGhlCmVudGlyZSBzdGFjay4gQW5k IG1lYW53aGlsZSB5b3UncmUgc3RlYWRmYXN0aWx5IHJlZnVzaW5nIHRvIGV2ZW4gbG9vawphdCB0 aGF0IHRoZSB1c2Vyc3BhY2Ugc2lkZSBvZiB0aGUgcGljdHVyZS4KCkFsc28gSSB0aG91Z2h0IHRo cm91Z2ggeW91ciB0bGIgaXNzdWUsIHdoeSBhcmUgeW91IGV2ZW4gcHV0dGluZyB0aGVzZQp0bGIg Zmx1c2ggZmVuY2VzIGludG8gdGhlIHNoYXJkIGRtYV9yZXN2IHNsb3RzPyBJZiB5b3Ugc3RvcmUg dGhlbQpzb21ld2hlcmUgZWxzZSBpbiB0aGUgYW1kZ3B1IHByaXZhdGUgcGFydCwgdGhlIG92ZXJz eW5jIGlzc3VlcyBnb2VzCmF3YXkKLSBpbiB5b3VyIHR0bSBibyBtb3ZlIGNhbGxiYWNrLCB5b3Ug Y2FuIGp1c3QgbWFrZSB5b3VyIGJvIGNvcHkgam9iCmRlcGVuZCBvbiB0aGVtIHRvbyAoeW91IGhh dmUgdG8gYW55d2F5KQotIGV2ZW4gZm9yIHAycCB0aGVyZSdzIG5vdCBhbiBpc3N1ZSBoZXJlLCBi ZWNhdXNlIHlvdSBoYXZlIHRoZQotPm1vdmVfbm90aWZ5IGNhbGxiYWNrLCBhbmQgY2FuIHRoZW4g bGlmdCB0aGUgdGxiIGZsdXNoIGZlbmNlcyBmcm9tCnlvdXIgcHJpdmF0ZSBwbGFjZSB0byB0aGUg c2hhcmVkIHNsb3RzIHNvIHRoZSBleHBvcnRlciBjYW4gc2VlIHRoZW0uCgpUaGUga2VybmVsIG1v dmUgZmVuY2VzIG90b2ggYXJlIGEgYml0IG1vcmUgbmFzdHkgdG8gd3JpbmcgdGhyb3VnaCB0aGUK cDJwIGRtYS1idWYgaW50ZXJmYWNlLiBUaGF0IG9uZSBwcm9iYWJseSBuZWVkcyBzb21ldGhpbmcg bmV3LgotRGFuaWVsCgo+Cj4gUmVnYXJkcywKPiBDaHJpc3RpYW4uCj4KPiA+IC1EYW5pZWwKPiA+ Cj4gPgo+ID4KPiA+Pj4gQXJlIHlvdSBib3JlZCBlbm91Z2ggdG8gdHlwZSB0aGlzIHVwIGZvciBy YWR2PyBJJ2xsIGdpdmUgSmFzb24ncyBrZXJuZWwKPiA+Pj4gc3R1ZmYgYW5vdGhlciByZXZpZXcg bWVhbndoaWxlLgo+ID4+PiAtRGFuaWVsCj4gPj4+Cj4gPj4+Pj4gICAgICAgICAgICAgICAgICBl LT5ib192YSA9IGFtZGdwdV92bV9ib19maW5kKHZtLCBibyk7Cj4gPj4+Pj4gICAgICAgICAgfQo+ ID4+Pj4+IC0tCj4gPj4+Pj4gMi4zMS4wCj4gPj4+Pj4KPiA+Pj4gLS0KPiA+Pj4gRGFuaWVsIFZl dHRlcgo+ID4+PiBTb2Z0d2FyZSBFbmdpbmVlciwgSW50ZWwgQ29ycG9yYXRpb24KPiA+Pj4gaHR0 cDovL2Jsb2cuZmZ3bGwuY2gKPgoKCi0tIApEYW5pZWwgVmV0dGVyClNvZnR3YXJlIEVuZ2luZWVy LCBJbnRlbCBDb3Jwb3JhdGlvbgpodHRwOi8vYmxvZy5mZndsbC5jaApfX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpJbnRlbC1nZnggbWFpbGluZyBsaXN0Cklu dGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5v cmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E2497C47076 for ; Fri, 21 May 2021 18:31:39 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7A8DC61163 for ; Fri, 21 May 2021 18:31:39 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7A8DC61163 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ffwll.ch Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 10E216F8D2; Fri, 21 May 2021 18:31:36 +0000 (UTC) Received: from mail-ot1-x32e.google.com (mail-ot1-x32e.google.com [IPv6:2607:f8b0:4864:20::32e]) by gabe.freedesktop.org (Postfix) with ESMTPS id 1AA4B6F8CE for ; Fri, 21 May 2021 18:31:30 +0000 (UTC) Received: by mail-ot1-x32e.google.com with SMTP id i14-20020a9d624e0000b029033683c71999so7693046otk.5 for ; Fri, 21 May 2021 11:31:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ffwll.ch; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=ssQbWaPKNXku5OPbuQHoPwspEJ/tPkBoh9sAADSrhpE=; b=Uu9hQaJ8bKy4+fr0LTNS3umKVdn2pBLHZTC89+aOZqisuEDloE2AHdKVFw/L4GscOe 7QcjqpKQBCMOwKXyjfLKRblL5u2LxNv4W3W0bb2NsOkl6qO+W61qzrL2bwCO/GtDdLKF V9Z8g06gg5IAQ1e9Fy1CG3HrP7gBiT27yp15o= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=ssQbWaPKNXku5OPbuQHoPwspEJ/tPkBoh9sAADSrhpE=; b=pPjpBkmwTiU254DiKDHM6qamUfzuTjZlN1pxVQSBbCcjG/huJsZT9B3tEQ3hwOTACv aayXmDaMc4FsR8ZSg5at5gFL3M28Fvq2CSLxOWxS4qAgB0JSvpphBIPjTXdQo1uLEc9C qbPHcOxOB1wWjhECdAxN1pPtmOJY8mX2Rld1eACT/HZzDtsd1KY0V7gCHCHbe+kkS1xE ZFel1o6vQXJvLpdZzNznm+uoNdORw/HQwPZf0jC2PvFgWedQs3De33MS7vs6hsIVK0ts Q3LIvADyCGAhtlTk92pWRn7NL3wzk5fDzDc1Lr9ZECgsVD/6/FAZoRf+xt5J9P6YF6HZ ltXw== X-Gm-Message-State: AOAM530rBM6PTFSLwEvYU82O6ihgaWpCxZQNQvZpe+L2U55sOzh5+6Ql QS7gXWlJZzP8TBPfb83ez++TNho6B3b6LoaFKQAJSA== X-Google-Smtp-Source: ABdhPJzhfhr27C49nXr2j3YFwIcmfU6rMWfQl0gg9HCxKinGNWcpaTBpO3xe8YnDGQ5ZqRzBbnoGYtfER8u6/HY6jLY= X-Received: by 2002:a9d:8ce:: with SMTP id 72mr9332384otf.188.1621621889460; Fri, 21 May 2021 11:31:29 -0700 (PDT) MIME-Version: 1.0 References: <20210521090959.1663703-1-daniel.vetter@ffwll.ch> <31467363-e936-879b-8b0d-5a2a92644221@gmail.com> In-Reply-To: <31467363-e936-879b-8b0d-5a2a92644221@gmail.com> From: Daniel Vetter Date: Fri, 21 May 2021 20:31:18 +0200 Message-ID: Subject: Re: [Mesa-dev] [PATCH 01/11] drm/amdgpu: Comply with implicit fencing rules To: =?UTF-8?Q?Christian_K=C3=B6nig?= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Rob Clark , Daniel Stone , =?UTF-8?Q?Michel_D=C3=A4nzer?= , Intel Graphics Development , Kevin Wang , DRI Development , "moderated list:DMA BUFFER SHARING FRAMEWORK" , Luben Tuikov , "Kristian H . Kristensen" , Chen Li , Alex Deucher , Daniel Vetter , mesa-dev , =?UTF-8?Q?Christian_K=C3=B6nig?= , Dennis Li , Deepak R Varma Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Fri, May 21, 2021 at 8:08 PM Christian K=C3=B6nig wrote: > > Am 21.05.21 um 17:16 schrieb Daniel Vetter: > > On Fri, May 21, 2021 at 05:00:46PM +0200, Bas Nieuwenhuizen wrote: > >> On Fri, May 21, 2021 at 4:37 PM Daniel Vetter wrote: > >>> On Fri, May 21, 2021 at 11:46:23AM +0200, Bas Nieuwenhuizen wrote: > >>>> On Fri, May 21, 2021 at 11:10 AM Daniel Vetter wrote: > >>>>> --- > >>>>> drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c | 4 ++-- > >>>>> 1 file changed, 2 insertions(+), 2 deletions(-) > >>>>> > >>>>> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c b/drivers/gpu/d= rm/amd/amdgpu/amdgpu_cs.c > >>>>> index 88a24a0b5691..cc8426e1e8a8 100644 > >>>>> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c > >>>>> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c > >>>>> @@ -617,8 +617,8 @@ static int amdgpu_cs_parser_bos(struct amdgpu_c= s_parser *p, > >>>>> amdgpu_bo_list_for_each_entry(e, p->bo_list) { > >>>>> struct amdgpu_bo *bo =3D ttm_to_amdgpu_bo(e->tv.bo= ); > >>>>> > >>>>> - /* Make sure we use the exclusive slot for shared B= Os */ > >>>>> - if (bo->prime_shared_count) > >>>>> + /* Make sure we use the exclusive slot for all pote= ntially shared BOs */ > >>>>> + if (!(bo->flags & AMDGPU_GEM_CREATE_VM_ALWAYS_VALID= )) > >>>>> e->tv.num_shared =3D 0; > >>>> I think it also makes sense to skip this with > >>>> AMDGPU_GEM_CREATE_EXPLICIT_SYNC? It can be shared but I don't think > >>>> anyone expects implicit sync to happen with those. > >>> Ah yes, I missed this entirely. So the "no implicit flag" is already > >>> there, and the _only_ thing that's missing really is a way to fish ou= t the > >>> implicit fences, and set them. > >>> > >>> https://lore.kernel.org/dri-devel/20210520190007.534046-1-jason@jleks= trand.net/ > >>> > >>> So I think all that's really needed in radv is not setting > >>> RADEON_FLAG_IMPLICIT_SYNC for winsys buffers when Jason's dma-buf ioc= tl > >>> are present (means you need to do some import/export and keep the fd > >>> around for winsys buffers, but shouldn't be too bad), and then contro= l the > >>> implicit fences entirely explicitly like vk expects. > >> That is the part I'm less sure about. This is a BO wide flag so we are > >> also disabling implicit sync in the compositor. If the compositor does > >> only do read stuff that is ok, as the inserted exclusive fence will > >> work for that. But as I learned recently the app provided buffer may > >> end up being written to by the X server which open a whole can of > >> potential problems if implicit sync gets disabled between Xserver > >> operations on the app provided buffer. Hence setting that on the WSI > >> buffer is a whole new can of potential problems and hence I've said a > >> submission based flag would be preferred. > >> > >> I can certainly try it out though. > > Hm yeah that's the wrong flag. We need a flag on the drm_file which the > > explicit userspace sets. And which is valid only for itself. > > > > There's a nice flags field when creating a ctx, but it's not validated = and > > there's already a comment that we have to filter out garbage priority, = so > > that's not use. I'll whip up something entirely untested just as a draf= t. > > We could provide an IOCTL for the BO to change the flag. That's not the semantics we need. > But could we first figure out the semantics we want to use here? > > Cause I'm pretty sure we don't actually need those changes at all and as > said before I'm certainly NAKing things which break existing use cases. Please read how other drivers do this and at least _try_ to understand it. I'm really loosing my patience here with you NAKing patches you're not even understanding (or did you actually read and fully understand the entire story I typed up here, and your NAK is on the entire thing?). There's not much useful conversation to be had with that approach. And with drivers I mean kernel + userspace here. That's the other frustration part: You're trying to fix this purely in the kernel. This is exactly one of these issues why we require open source userspace, so that we can fix the issues correctly across the entire stack. And meanwhile you're steadfastily refusing to even look at that the userspace side of the picture. Also I thought through your tlb issue, why are you even putting these tlb flush fences into the shard dma_resv slots? If you store them somewhere else in the amdgpu private part, the oversync issues goes away - in your ttm bo move callback, you can just make your bo copy job depend on them too (you have to anyway) - even for p2p there's not an issue here, because you have the ->move_notify callback, and can then lift the tlb flush fences from your private place to the shared slots so the exporter can see them. The kernel move fences otoh are a bit more nasty to wring through the p2p dma-buf interface. That one probably needs something new. -Daniel > > Regards, > Christian. > > > -Daniel > > > > > > > >>> Are you bored enough to type this up for radv? I'll give Jason's kern= el > >>> stuff another review meanwhile. > >>> -Daniel > >>> > >>>>> e->bo_va =3D amdgpu_vm_bo_find(vm, bo); > >>>>> } > >>>>> -- > >>>>> 2.31.0 > >>>>> > >>> -- > >>> Daniel Vetter > >>> Software Engineer, Intel Corporation > >>> http://blog.ffwll.ch > --=20 Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch