From: Alexander Duyck <alexander.duyck@gmail.com>
To: Michael Chan <michael.chan@broadcom.com>
Cc: David Miller <davem@davemloft.net>,
Netdev <netdev@vger.kernel.org>, Jakub Kicinski <kuba@kernel.org>,
Andy Gospodarek <gospo@broadcom.com>
Subject: Re: [PATCH net v3] bnxt_en: Fix and improve .ndo_features_check().
Date: Tue, 11 May 2021 17:39:58 -0700 [thread overview]
Message-ID: <CAKgT0UdN+wLGEe0By+2ZiyncXj+nhey-JcproHo5YyXSQBM8XQ@mail.gmail.com> (raw)
In-Reply-To: <1620774650-4464-1-git-send-email-michael.chan@broadcom.com>
On Tue, May 11, 2021 at 4:10 PM Michael Chan <michael.chan@broadcom.com> wrote:
>
> Jakub Kicinski pointed out that we need to handle ipv6 extension headers
> and to explicitly check for supported tunnel types in
> .ndo_features_check().
>
> For ipv6 extension headers, the hardware supports up to 2 ext. headers
> and each must be <= 64 bytes. For tunneled packets, the supported
> packets are UDP with supported VXLAN and Geneve ports, GRE, and IPIP.
>
> v3: More improvements based on Alexander Duyck's valuable feedback -
> Remove the jump lable in bnxt_features_check() and restructure it
> so that the TCP/UDP is check is consolidated in bnxt_exthdr_check().
>
> v2: Add missing step to check inner ipv6 header for UDP and GRE tunnels.
> Check TCP/UDP next header after skipping ipv6 ext headers for
> non-tunneled packets and for inner ipv6.
> (Both feedback from Alexander Duyck)
>
> Reviewed-by: Edwin Peer <edwin.peer@broadcom.com>
> Reviewed-by: Pavan Chebbi <pavan.chebbi@broadcom.com>
> Fixes: 1698d600b361 ("bnxt_en: Implement .ndo_features_check().")
> Signed-off-by: Michael Chan <michael.chan@broadcom.com>
This addresses the concerns I had.
Reviewed-by: Alexander Duyck <alexanderduyck@fb.com>
prev parent reply other threads:[~2021-05-12 0:40 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-11 23:10 [PATCH net v3] bnxt_en: Fix and improve .ndo_features_check() Michael Chan
2021-05-12 0:39 ` Alexander Duyck [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAKgT0UdN+wLGEe0By+2ZiyncXj+nhey-JcproHo5YyXSQBM8XQ@mail.gmail.com \
--to=alexander.duyck@gmail.com \
--cc=davem@davemloft.net \
--cc=gospo@broadcom.com \
--cc=kuba@kernel.org \
--cc=michael.chan@broadcom.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.