From mboxrd@z Thu Jan 1 00:00:00 1970 From: Viresh Kumar Subject: Re: [PATCH V7 3/3] OPP: Add binding for 'opp-suspend' Date: Tue, 16 Jun 2015 06:01:58 +0530 Message-ID: References: Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Return-path: In-Reply-To: Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Rob Herring Cc: Rafael Wysocki , "linaro-kernel-cunTk1MwBs8s++Sfvej+rw@public.gmane.org" , "linux-pm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , Arnd Bergmann , Nishanth Menon , Mark Brown , Mike Turquette , Stephen Boyd , Grant Likely , Olof Johansson , Sudeep Holla , "devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , Viswanath Puttagunta , Lucas Stach , Thomas Petazzoni , "linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org" , Thomas Abraham , Abhilash Kesavan , Kevin Hilman , Santosh List-Id: devicetree@vger.kernel.org On 16 June 2015 at 05:05, Rob Herring wrote: >> +- opp-suspend: Phandle of the OPP to set while device is suspended. >> + > > I would just do a bool property in the OPP you want. I will do that if you want, no big deal. But I would like to explain why I did it this way. Nishanth asked the same thing earlier and now he looks convinced :) There can only be one OPP that can be selected during suspend. Allowing more than one OPP to select this property doesn't look like the right thing to me. In that case we have to make a rule that the first OPP in the table will be selected or error out in that case. And I thought that this is property of the table, instead of each OPP. For example, in code this will waste lots of space if we choose such a field in individual OPPs, and we will always keep it in the OPP-table thing.. But then this is DT :) I will wait for your reply Rob on this, and then will send an update. Thanks. -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 From: viresh.kumar@linaro.org (Viresh Kumar) Date: Tue, 16 Jun 2015 06:01:58 +0530 Subject: [PATCH V7 3/3] OPP: Add binding for 'opp-suspend' In-Reply-To: References: Message-ID: To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 16 June 2015 at 05:05, Rob Herring wrote: >> +- opp-suspend: Phandle of the OPP to set while device is suspended. >> + > > I would just do a bool property in the OPP you want. I will do that if you want, no big deal. But I would like to explain why I did it this way. Nishanth asked the same thing earlier and now he looks convinced :) There can only be one OPP that can be selected during suspend. Allowing more than one OPP to select this property doesn't look like the right thing to me. In that case we have to make a rule that the first OPP in the table will be selected or error out in that case. And I thought that this is property of the table, instead of each OPP. For example, in code this will waste lots of space if we choose such a field in individual OPPs, and we will always keep it in the OPP-table thing.. But then this is DT :) I will wait for your reply Rob on this, and then will send an update. Thanks.