From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-23.3 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3314EC4338F for ; Fri, 30 Jul 2021 20:24:23 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 193EB60F36 for ; Fri, 30 Jul 2021 20:24:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231702AbhG3UY1 (ORCPT ); Fri, 30 Jul 2021 16:24:27 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48390 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230310AbhG3UYZ (ORCPT ); Fri, 30 Jul 2021 16:24:25 -0400 Received: from mail-lf1-x129.google.com (mail-lf1-x129.google.com [IPv6:2a00:1450:4864:20::129]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 85224C06175F for ; Fri, 30 Jul 2021 13:24:20 -0700 (PDT) Received: by mail-lf1-x129.google.com with SMTP id a26so20173967lfr.11 for ; Fri, 30 Jul 2021 13:24:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=MhW1Jw1DENMC35TDbXRVr3UzXIX691dUHdyLHQqhvKg=; b=pMsQbhstAXAmYIm7x/KJo8DsaFh27rjlna5EJEi5Y2LEKQo42VBLqMQ7F3uoL7aqDc 7KalHMpeGGtNBwzzAW90LiJeFK5gdUYVoi4oWOAQVO+GksnGO+4p5CHgTDB6dH6HgEDm wagLS0ulkCrycuUroE+gCiHrmv36u0gyNEvcaASPoqxxzELVoSydDSKq5wjTfSCA0lSm SbhwYnI5joFdBdRkLRNwgRcYwmJ8wcf5TtfGUG+R4n31ZlWrsWPXL9b77Mgk1QDwz1yI KYpmqQ8zwiS3F8w42QipdXmgdZ8yqVcnjq0j1g80SwotApygxBDwp0GOdSCwvxJ8QMVe X2iA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=MhW1Jw1DENMC35TDbXRVr3UzXIX691dUHdyLHQqhvKg=; b=myRUdrnaWyLopjBw+d/twigt+DVuRfkDAnuqCJskSZZUa7z4ILak9gr7GX+ZJPsWF9 GEgjHAdlq3Mo3EQepNHESEXLuZVhvgV7bvcoX9oh8SjwmZsbJ7nwbOOLGayE12c7n8en hTX48zVluh3XT6asvAxsMdGxn/TezeZtwyc5qvpw1Ia92M002Xxpph4cgZ7b57CQm/U5 hCmLhwOecYxrbyVzn6v2fEsVPqV3e6f8ytng1GpxUrEsGS6JkbBP8bmk41dMuXUDm4wE tYtYWWXO8M1t6tYKzy3atX3Up5yo7S0RtwLhEuushXro7QIUKiuCS1+mFr66dT6XvJVb 90Dg== X-Gm-Message-State: AOAM5310lkL9kZ1VxkLpxU8LLmiTdWjRH3Mt3S/ODV5Gy5lpRJHIDAU2 KY0FlQZYtGsMkPHZUpwJaTAF+B8d+PfhJOrzuuLI/A== X-Google-Smtp-Source: ABdhPJyvSrq0KR6B0tuKx+NyIXbuYTNdLjAlogrdD/CfP9mB+76d2GTI/v6xgCFbE43Y6mY1Rj19njas82jQmJyHaAE= X-Received: by 2002:a05:6512:32aa:: with SMTP id q10mr3148115lfe.368.1627676658562; Fri, 30 Jul 2021 13:24:18 -0700 (PDT) MIME-Version: 1.0 References: <20210729141937.445051-1-masahiroy@kernel.org> <20210729141937.445051-2-masahiroy@kernel.org> In-Reply-To: <20210729141937.445051-2-masahiroy@kernel.org> From: Nick Desaulniers Date: Fri, 30 Jul 2021 13:24:07 -0700 Message-ID: Subject: Re: [PATCH 2/3] powerpc: make the install target not depend on any build artifact To: Masahiro Yamada Cc: Michael Ellerman , Benjamin Herrenschmidt , Paul Mackerras , linuxppc-dev@lists.ozlabs.org, Nicholas Piggin , linux-kernel@vger.kernel.org, Jordan Niethe , "Gustavo A. R. Silva" , Bill Wendling , Joel Stanley Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jul 29, 2021 at 7:22 AM Masahiro Yamada wrote: > > The install target should not depend on any build artifact. > > The reason is explained in commit 19514fc665ff ("arm, kbuild: make > "make install" not depend on vmlinux"). > > Change the PowerPC installation code in a similar way. > > Signed-off-by: Masahiro Yamada Reviewed-by: Nick Desaulniers > --- > > arch/powerpc/boot/Makefile | 2 +- > arch/powerpc/boot/install.sh | 14 ++++++++++++++ > 2 files changed, 15 insertions(+), 1 deletion(-) > > diff --git a/arch/powerpc/boot/Makefile b/arch/powerpc/boot/Makefile > index a702f9d1ec0d..0d165bd98b61 100644 > --- a/arch/powerpc/boot/Makefile > +++ b/arch/powerpc/boot/Makefile > @@ -445,7 +445,7 @@ $(obj)/zImage.initrd: $(addprefix $(obj)/, $(initrd-y)) > $(Q)rm -f $@; ln $< $@ > > # Only install the vmlinux > -install: $(CONFIGURE) $(addprefix $(obj)/, $(image-y)) > +install: > sh -x $(srctree)/$(src)/install.sh "$(KERNELRELEASE)" vmlinux System.map "$(INSTALL_PATH)" > > PHONY += install > diff --git a/arch/powerpc/boot/install.sh b/arch/powerpc/boot/install.sh > index 658c93ca7437..14473150ddb4 100644 > --- a/arch/powerpc/boot/install.sh > +++ b/arch/powerpc/boot/install.sh > @@ -20,6 +20,20 @@ > # Bail with error code if anything goes wrong > set -e > > +verify () { > + if [ ! -f "$1" ]; then > + echo "" 1>&2 > + echo " *** Missing file: $1" 1>&2 > + echo ' *** You need to run "make" before "make install".' 1>&2 > + echo "" 1>&2 > + exit 1 > + fi > +} > + > +# Make sure the files actually exist > +verify "$2" > +verify "$3" > + > # User may have a custom install script > > if [ -x ~/bin/${INSTALLKERNEL} ]; then exec ~/bin/${INSTALLKERNEL} "$@"; fi > -- > 2.27.0 > -- Thanks, ~Nick Desaulniers From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.6 required=3.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED,DKIM_INVALID,DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0B31EC4338F for ; Fri, 30 Jul 2021 20:24:50 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9905E60E09 for ; Fri, 30 Jul 2021 20:24:49 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 9905E60E09 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.ozlabs.org Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4GbzQl6xMZz3d8F for ; Sat, 31 Jul 2021 06:24:47 +1000 (AEST) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=google.com header.i=@google.com header.a=rsa-sha256 header.s=20161025 header.b=pMsQbhst; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=google.com (client-ip=2a00:1450:4864:20::129; helo=mail-lf1-x129.google.com; envelope-from=ndesaulniers@google.com; receiver=) Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=google.com header.i=@google.com header.a=rsa-sha256 header.s=20161025 header.b=pMsQbhst; dkim-atps=neutral Received: from mail-lf1-x129.google.com (mail-lf1-x129.google.com [IPv6:2a00:1450:4864:20::129]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4GbzQH4nrTz2xtr for ; Sat, 31 Jul 2021 06:24:23 +1000 (AEST) Received: by mail-lf1-x129.google.com with SMTP id h2so20271531lfu.4 for ; Fri, 30 Jul 2021 13:24:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=MhW1Jw1DENMC35TDbXRVr3UzXIX691dUHdyLHQqhvKg=; b=pMsQbhstAXAmYIm7x/KJo8DsaFh27rjlna5EJEi5Y2LEKQo42VBLqMQ7F3uoL7aqDc 7KalHMpeGGtNBwzzAW90LiJeFK5gdUYVoi4oWOAQVO+GksnGO+4p5CHgTDB6dH6HgEDm wagLS0ulkCrycuUroE+gCiHrmv36u0gyNEvcaASPoqxxzELVoSydDSKq5wjTfSCA0lSm SbhwYnI5joFdBdRkLRNwgRcYwmJ8wcf5TtfGUG+R4n31ZlWrsWPXL9b77Mgk1QDwz1yI KYpmqQ8zwiS3F8w42QipdXmgdZ8yqVcnjq0j1g80SwotApygxBDwp0GOdSCwvxJ8QMVe X2iA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=MhW1Jw1DENMC35TDbXRVr3UzXIX691dUHdyLHQqhvKg=; b=FnsW1Qa0txvcKF4dzvY7UkN80Hcal4a4T81qLkMSsRf/f2IV4x7KKpnyC8ZykiIKlI s4Tq4aPd2WyzMTM/SJzbqfpQ3It58UQXkbYBfJxt76eJlxYnZUh28c/4QQq6RW7gpmeL V2DV5o2zn8drNZnOvlAKCB5Muy6g68wiYTLchFapWmIbcBubDXp+lUlb3DTj5bSaWg6s zMjEr78JgjkAfmH/n6PD02nDHVSJ4+50FxnnOFDUPUkRaK25Xf+WByZGJfv1M+g5tGsU F0CxSjYCzcGJRjwCvMLJwvHwUNAr686cqKkKRXD9IepaCVrWlUgrjsgZbVJBWVMqV4aC 4HYQ== X-Gm-Message-State: AOAM531/+A8exJNhC+isMLftol24P8SaSwJkU997WOP7hnMAWbMTKyC6 PtoeKA5qlDRjlusEbraQu/08Aj4pIkPdjsT/b46DKg== X-Google-Smtp-Source: ABdhPJyvSrq0KR6B0tuKx+NyIXbuYTNdLjAlogrdD/CfP9mB+76d2GTI/v6xgCFbE43Y6mY1Rj19njas82jQmJyHaAE= X-Received: by 2002:a05:6512:32aa:: with SMTP id q10mr3148115lfe.368.1627676658562; Fri, 30 Jul 2021 13:24:18 -0700 (PDT) MIME-Version: 1.0 References: <20210729141937.445051-1-masahiroy@kernel.org> <20210729141937.445051-2-masahiroy@kernel.org> In-Reply-To: <20210729141937.445051-2-masahiroy@kernel.org> From: Nick Desaulniers Date: Fri, 30 Jul 2021 13:24:07 -0700 Message-ID: Subject: Re: [PATCH 2/3] powerpc: make the install target not depend on any build artifact To: Masahiro Yamada Content-Type: text/plain; charset="UTF-8" X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-kernel@vger.kernel.org, Nicholas Piggin , "Gustavo A. R. Silva" , Jordan Niethe , Paul Mackerras , Bill Wendling , linuxppc-dev@lists.ozlabs.org, Joel Stanley Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On Thu, Jul 29, 2021 at 7:22 AM Masahiro Yamada wrote: > > The install target should not depend on any build artifact. > > The reason is explained in commit 19514fc665ff ("arm, kbuild: make > "make install" not depend on vmlinux"). > > Change the PowerPC installation code in a similar way. > > Signed-off-by: Masahiro Yamada Reviewed-by: Nick Desaulniers > --- > > arch/powerpc/boot/Makefile | 2 +- > arch/powerpc/boot/install.sh | 14 ++++++++++++++ > 2 files changed, 15 insertions(+), 1 deletion(-) > > diff --git a/arch/powerpc/boot/Makefile b/arch/powerpc/boot/Makefile > index a702f9d1ec0d..0d165bd98b61 100644 > --- a/arch/powerpc/boot/Makefile > +++ b/arch/powerpc/boot/Makefile > @@ -445,7 +445,7 @@ $(obj)/zImage.initrd: $(addprefix $(obj)/, $(initrd-y)) > $(Q)rm -f $@; ln $< $@ > > # Only install the vmlinux > -install: $(CONFIGURE) $(addprefix $(obj)/, $(image-y)) > +install: > sh -x $(srctree)/$(src)/install.sh "$(KERNELRELEASE)" vmlinux System.map "$(INSTALL_PATH)" > > PHONY += install > diff --git a/arch/powerpc/boot/install.sh b/arch/powerpc/boot/install.sh > index 658c93ca7437..14473150ddb4 100644 > --- a/arch/powerpc/boot/install.sh > +++ b/arch/powerpc/boot/install.sh > @@ -20,6 +20,20 @@ > # Bail with error code if anything goes wrong > set -e > > +verify () { > + if [ ! -f "$1" ]; then > + echo "" 1>&2 > + echo " *** Missing file: $1" 1>&2 > + echo ' *** You need to run "make" before "make install".' 1>&2 > + echo "" 1>&2 > + exit 1 > + fi > +} > + > +# Make sure the files actually exist > +verify "$2" > +verify "$3" > + > # User may have a custom install script > > if [ -x ~/bin/${INSTALLKERNEL} ]; then exec ~/bin/${INSTALLKERNEL} "$@"; fi > -- > 2.27.0 > -- Thanks, ~Nick Desaulniers