From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rob Herring Subject: Re: [PATCH V7 3/3] OPP: Add binding for 'opp-suspend' Date: Tue, 16 Jun 2015 14:23:23 -0500 Message-ID: References: <20150616025425.GB26592@linux> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Return-path: In-Reply-To: <20150616025425.GB26592@linux> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Viresh Kumar Cc: Rafael Wysocki , "linaro-kernel-cunTk1MwBs8s++Sfvej+rw@public.gmane.org" , "linux-pm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , Arnd Bergmann , Nishanth Menon , Mark Brown , Mike Turquette , Stephen Boyd , Grant Likely , Olof Johansson , Sudeep Holla , "devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , Viswanath Puttagunta , Lucas Stach , Thomas Petazzoni , "linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org" , Thomas Abraham , Abhilash Kesavan , Kevin Hilman , Santosh List-Id: devicetree@vger.kernel.org On Mon, Jun 15, 2015 at 9:54 PM, Viresh Kumar wrote: > On 16-06-15, 06:01, Viresh Kumar wrote: >> On 16 June 2015 at 05:05, Rob Herring wrote: >> >> +- opp-suspend: Phandle of the OPP to set while device is suspended. >> >> + >> > >> > I would just do a bool property in the OPP you want. >> >> I will do that if you want, no big deal. > > In order to not waste any time, here is the change you suggested. Ack > the one (original change or this one) you like :) > > ------------------8<---------------------- > > From: Viresh Kumar > Date: Wed, 20 May 2015 08:27:49 +0530 > Subject: [PATCH V8] OPP: Add binding for 'opp-suspend' > > On few platforms, for power efficiency, we want the device to be > configured for a specific OPP while we put the device in suspend state. > > Add an optional property in operating-points-v2 bindings for that. > > Acked-by: Nishanth Menon > Suggested-by: Nishanth Menon > Signed-off-by: Viresh Kumar > --- > V7->V8: > - opp-suspend is moved to OPPs instead of the table, and is bool now. Acked-by: Rob Herring > Documentation/devicetree/bindings/power/opp.txt | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/Documentation/devicetree/bindings/power/opp.txt b/Documentation/devicetree/bindings/power/opp.txt > index 2938c52dbf84..2d4291127003 100644 > --- a/Documentation/devicetree/bindings/power/opp.txt > +++ b/Documentation/devicetree/bindings/power/opp.txt > @@ -113,6 +113,9 @@ properties. > frequency for a short duration of time limited by the device's power, current > and thermal limits. > > +- opp-suspend: Marks the OPP to be used during device suspend. Only one OPP in > + the table should have this. > + > - status: Marks the node enabled/disabled. > > Example 1: Single cluster Dual-core ARM cortex A9, switch DVFS states together. > @@ -152,6 +155,7 @@ Example 1: Single cluster Dual-core ARM cortex A9, switch DVFS states together. > opp-microvolt = <970000 975000 985000>; > opp-microamp = <70000>; > clock-latency-ns = <300000>; > + opp-suspend; > }; > opp01 { > opp-hz = <1100000000>; > @@ -230,6 +234,7 @@ independently. > opp-microvolt = <970000 975000 985000>; > opp-microamp = <70000>; > clock-latency-ns = <300000>; > + opp-suspend; > }; > opp01 { > opp-hz = <1100000000>; > @@ -305,6 +310,7 @@ DVFS state together. > opp-microvolt = <970000 975000 985000>; > opp-microamp = <70000>; > clock-latency-ns = <300000>; > + opp-suspend; > }; > opp01 { > opp-hz = <1100000000>; > @@ -330,6 +336,7 @@ DVFS state together. > opp-microvolt = <1045000 1050000 1055000>; > opp-microamp = <95000>; > clock-latency-ns = <400000>; > + opp-suspend; > }; > opp11 { > opp-hz = <1400000000>; > -- > 2.4.0 > -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 From: robherring2@gmail.com (Rob Herring) Date: Tue, 16 Jun 2015 14:23:23 -0500 Subject: [PATCH V7 3/3] OPP: Add binding for 'opp-suspend' In-Reply-To: <20150616025425.GB26592@linux> References: <20150616025425.GB26592@linux> Message-ID: To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Mon, Jun 15, 2015 at 9:54 PM, Viresh Kumar wrote: > On 16-06-15, 06:01, Viresh Kumar wrote: >> On 16 June 2015 at 05:05, Rob Herring wrote: >> >> +- opp-suspend: Phandle of the OPP to set while device is suspended. >> >> + >> > >> > I would just do a bool property in the OPP you want. >> >> I will do that if you want, no big deal. > > In order to not waste any time, here is the change you suggested. Ack > the one (original change or this one) you like :) > > ------------------8<---------------------- > > From: Viresh Kumar > Date: Wed, 20 May 2015 08:27:49 +0530 > Subject: [PATCH V8] OPP: Add binding for 'opp-suspend' > > On few platforms, for power efficiency, we want the device to be > configured for a specific OPP while we put the device in suspend state. > > Add an optional property in operating-points-v2 bindings for that. > > Acked-by: Nishanth Menon > Suggested-by: Nishanth Menon > Signed-off-by: Viresh Kumar > --- > V7->V8: > - opp-suspend is moved to OPPs instead of the table, and is bool now. Acked-by: Rob Herring > Documentation/devicetree/bindings/power/opp.txt | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/Documentation/devicetree/bindings/power/opp.txt b/Documentation/devicetree/bindings/power/opp.txt > index 2938c52dbf84..2d4291127003 100644 > --- a/Documentation/devicetree/bindings/power/opp.txt > +++ b/Documentation/devicetree/bindings/power/opp.txt > @@ -113,6 +113,9 @@ properties. > frequency for a short duration of time limited by the device's power, current > and thermal limits. > > +- opp-suspend: Marks the OPP to be used during device suspend. Only one OPP in > + the table should have this. > + > - status: Marks the node enabled/disabled. > > Example 1: Single cluster Dual-core ARM cortex A9, switch DVFS states together. > @@ -152,6 +155,7 @@ Example 1: Single cluster Dual-core ARM cortex A9, switch DVFS states together. > opp-microvolt = <970000 975000 985000>; > opp-microamp = <70000>; > clock-latency-ns = <300000>; > + opp-suspend; > }; > opp01 { > opp-hz = <1100000000>; > @@ -230,6 +234,7 @@ independently. > opp-microvolt = <970000 975000 985000>; > opp-microamp = <70000>; > clock-latency-ns = <300000>; > + opp-suspend; > }; > opp01 { > opp-hz = <1100000000>; > @@ -305,6 +310,7 @@ DVFS state together. > opp-microvolt = <970000 975000 985000>; > opp-microamp = <70000>; > clock-latency-ns = <300000>; > + opp-suspend; > }; > opp01 { > opp-hz = <1100000000>; > @@ -330,6 +336,7 @@ DVFS state together. > opp-microvolt = <1045000 1050000 1055000>; > opp-microamp = <95000>; > clock-latency-ns = <400000>; > + opp-suspend; > }; > opp11 { > opp-hz = <1400000000>; > -- > 2.4.0 >