From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752329AbbGNDbc (ORCPT ); Mon, 13 Jul 2015 23:31:32 -0400 Received: from mail-yk0-f178.google.com ([209.85.160.178]:34445 "EHLO mail-yk0-f178.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751628AbbGNDbb (ORCPT ); Mon, 13 Jul 2015 23:31:31 -0400 MIME-Version: 1.0 In-Reply-To: <1436841447.5489.462.camel@intel.com> References: <1436841447.5489.462.camel@intel.com> From: Rob Herring Date: Mon, 13 Jul 2015 22:31:11 -0500 X-Google-Sender-Auth: _kh7KRtWv4Hn0MNiRPnFO2HQOWY Message-ID: Subject: Re: [lkp] [of] 649e0a77e28: To: Huang Ying Cc: LKML , LKP ML Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jul 13, 2015 at 9:37 PM, Huang Ying wrote: > FYI, we noticed the below changes on > > git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master > commit 649e0a77e28a7796bf62bfda0fe3f2aee094bd58 ("of: make unittest select OF_EARLY_FLATTREE instead of depend on it") > > The following new message in kernel log may make end user confuse. > > [ 2.775617] device-tree: Duplicate name in testcase-data, renamed to "duplicate-name#1" This should probably be after the next line. > [ 2.779463] ### dt-test ### start of unittest - you will see error messages Is "you will see error messages" not clear enough? We could prefix every message to make it clearer. Unit tests often print error messages and typically should not be enabled on production kernels. Rob > [ 2.780294] /testcase-data/phandle-tests/consumer-a: could not get #phandle-cells-missing for /testcase-data/phandle-tests/provider1 > [ 2.781341] /testcase-data/phandle-tests/consumer-a: could not get #phandle-cells-missing for /testcase-data/phandle-tests/provider1 > [ 2.782394] /testcase-data/phandle-tests/consumer-a: could not find phandle > [ 2.783001] /testcase-data/phandle-tests/consumer-a: could not find phandle > [ 2.783622] /testcase-data/phandle-tests/consumer-a: arguments longer than property > [ 2.784333] /testcase-data/phandle-tests/consumer-a: arguments longer than property > > > Thanks, > Ying Huang From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: multipart/mixed; boundary="===============2388947293970263030==" MIME-Version: 1.0 From: Rob Herring To: lkp@lists.01.org Subject: Re: [of] 649e0a77e28: Date: Mon, 13 Jul 2015 22:31:11 -0500 Message-ID: In-Reply-To: <1436841447.5489.462.camel@intel.com> List-Id: --===============2388947293970263030== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable On Mon, Jul 13, 2015 at 9:37 PM, Huang Ying wrote: > FYI, we noticed the below changes on > > git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master > commit 649e0a77e28a7796bf62bfda0fe3f2aee094bd58 ("of: make unittest selec= t OF_EARLY_FLATTREE instead of depend on it") > > The following new message in kernel log may make end user confuse. > > [ 2.775617] device-tree: Duplicate name in testcase-data, renamed to "= duplicate-name#1" This should probably be after the next line. > [ 2.779463] ### dt-test ### start of unittest - you will see error mes= sages Is "you will see error messages" not clear enough? We could prefix every message to make it clearer. Unit tests often print error messages and typically should not be enabled on production kernels. Rob > [ 2.780294] /testcase-data/phandle-tests/consumer-a: could not get #ph= andle-cells-missing for /testcase-data/phandle-tests/provider1 > [ 2.781341] /testcase-data/phandle-tests/consumer-a: could not get #ph= andle-cells-missing for /testcase-data/phandle-tests/provider1 > [ 2.782394] /testcase-data/phandle-tests/consumer-a: could not find ph= andle > [ 2.783001] /testcase-data/phandle-tests/consumer-a: could not find ph= andle > [ 2.783622] /testcase-data/phandle-tests/consumer-a: arguments longer = than property > [ 2.784333] /testcase-data/phandle-tests/consumer-a: arguments longer = than property > > > Thanks, > Ying Huang --===============2388947293970263030==--