From: Tom Herbert <tom@herbertland.com>
To: Thomas Graf <tgraf@suug.ch>
Cc: "David S. Miller" <davem@davemloft.net>,
Linux Kernel Network Developers <netdev@vger.kernel.org>,
Kernel Team <kernel-team@fb.com>,
Herbert Xu <herbert@gondor.apana.org.au>
Subject: Re: [PATCH net-next 2/3] rhashtable: allow lookup function to have compare function agument
Date: Tue, 14 Jul 2015 08:43:52 -0700 [thread overview]
Message-ID: <CALx6S35rcBJtLeUQEnD3yc3nY2HC_KW_3b+pb8RFHt=GTx1Zng@mail.gmail.com> (raw)
In-Reply-To: <20150714094449.GD20597@pox.localdomain>
On Tue, Jul 14, 2015 at 2:44 AM, Thomas Graf <tgraf@suug.ch> wrote:
> On 07/13/15 at 05:39pm, Tom Herbert wrote:
>> Added rhashtable_lookup_fast_cmpfn which does a lookup in an rhash table
>> with the compare function being taken from an argument. This allows
>> different compare functions to be used on the same table.
>>
>> Signed-off-by: Tom Herbert <tom@herbertland.com>
>
> Does this preserve the inlining guarantee? I remember Herbert had
> to write this carefully in order to avoid indirect calls.
It looks like the compare functions are still being properly inlined.
This is gcc 4.4.7.
Thanks,
Tom
next prev parent reply other threads:[~2015-07-14 15:43 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-14 0:39 [PATCH net-next 0/3] rhashtable: Wildcard and scored lookups Tom Herbert
2015-07-14 0:39 ` [PATCH net-next 1/3] rhashtable: Add a function for in order insertion in buckets Tom Herbert
2015-07-14 9:57 ` Herbert Xu
2015-07-14 16:42 ` Tom Herbert
2015-07-14 23:58 ` Herbert Xu
2015-07-15 0:59 ` Tom Herbert
2015-07-15 1:08 ` Herbert Xu
2015-07-14 0:39 ` [PATCH net-next 2/3] rhashtable: allow lookup function to have compare function agument Tom Herbert
2015-07-14 9:44 ` Thomas Graf
2015-07-14 15:43 ` Tom Herbert [this message]
2015-07-14 0:39 ` [PATCH net-next 3/3] rhashtable: Add scored lookups Tom Herbert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CALx6S35rcBJtLeUQEnD3yc3nY2HC_KW_3b+pb8RFHt=GTx1Zng@mail.gmail.com' \
--to=tom@herbertland.com \
--cc=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=kernel-team@fb.com \
--cc=netdev@vger.kernel.org \
--cc=tgraf@suug.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.