From: Vincent MAILHOL <mailhol.vincent@wanadoo.fr>
To: Marc Kleine-Budde <mkl@pengutronix.de>
Cc: linux-can <linux-can@vger.kernel.org>,
Jimmy Assarsson <extja@kvaser.com>,
Masahiro Yamada <masahiroy@kernel.org>,
open list <linux-kernel@vger.kernel.org>,
netdev <netdev@vger.kernel.org>,
Arunachalam Santhanam <arunachalam.santhanam@in.bosch.com>,
Oliver Hartkopp <socketcan@hartkopp.net>
Subject: Re: [PATCH v15 0/3] Introducing ETAS ES58X CAN USB interfaces
Date: Mon, 12 Apr 2021 20:23:06 +0900 [thread overview]
Message-ID: <CAMZ6RqLgLzMymHus5O7qcL_q=AwywXQusNb51CNL1TtHZ0XwcQ@mail.gmail.com> (raw)
In-Reply-To: <20210412092001.7vp7dtbvsb6bgh2t@pengutronix.de>
Hi Marc,
On Mon. 12 Apr 2021 at 18:20, Marc Kleine-Budde <mkl@pengutronix.de> wrote:
> On 10.04.2021 18:59:45, Vincent Mailhol wrote:
> > Here comes the 15th iteration of the patch. This new version addresses
> > the comments received from Marc (thanks again for the review!) and
> > simplify the device probing by using .driver_info.
>
> diff --git a/drivers/net/can/usb/etas_es58x/es58x_core.c b/drivers/net/can/usb/etas_es58x/es58x_core.c
> index 35ba8af89b2e..7222b3b6ca46 100644
> --- a/drivers/net/can/usb/etas_es58x/es58x_core.c
> +++ b/drivers/net/can/usb/etas_es58x/es58x_core.c
> @@ -1096,7 +1096,7 @@ static void es58x_increment_rx_errors(struct es58x_device *es58x_dev)
> * be aligned.
> *
> * Sends the URB command to the device specific function. Manages the
> - * errors throwed back by those functions.
> + * errors thrown back by those functions.
> */
> static void es58x_handle_urb_cmd(struct es58x_device *es58x_dev,
> const union es58x_urb_cmd *urb_cmd)
>
> I have applied to linux-can-next/testing with the above spell fix.
> Thanks for the steady work on this and all the other features.
Thanks to you too! This, together with the other features is my
very first open source contribution. I learned a lot from you,
Oliver and the others from the mailing list. It was a nice
experience.
That said, you will eventually hear from me again on the TDC
netlink interface (and probably other topics as well).
Yours sincerely,
Vincent
prev parent reply other threads:[~2021-04-12 11:23 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-10 9:59 [PATCH v15 0/3] Introducing ETAS ES58X CAN USB interfaces Vincent Mailhol
2021-04-10 9:59 ` [PATCH v15 1/3] can: etas_es58x: add core support for " Vincent Mailhol
2021-04-10 9:59 ` [PATCH v15 2/3] can: etas_es58x: add support for ETAS ES581.4 CAN USB interface Vincent Mailhol
2021-04-10 9:59 ` [PATCH v15 3/3] can: etas_es58x: add support for the ETAS ES58X_FD CAN USB interfaces Vincent Mailhol
2021-04-12 9:20 ` [PATCH v15 0/3] Introducing ETAS ES58X " Marc Kleine-Budde
2021-04-12 11:23 ` Vincent MAILHOL [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAMZ6RqLgLzMymHus5O7qcL_q=AwywXQusNb51CNL1TtHZ0XwcQ@mail.gmail.com' \
--to=mailhol.vincent@wanadoo.fr \
--cc=arunachalam.santhanam@in.bosch.com \
--cc=extja@kvaser.com \
--cc=linux-can@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=masahiroy@kernel.org \
--cc=mkl@pengutronix.de \
--cc=netdev@vger.kernel.org \
--cc=socketcan@hartkopp.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.