* [PATCH -next] usb: cdc-wdm: fix build error when CONFIG_WWAN_CORE is not set
@ 2021-05-20 13:42 Wei Yongjun
2021-05-20 16:00 ` Loic Poulain
0 siblings, 1 reply; 2+ messages in thread
From: Wei Yongjun @ 2021-05-20 13:42 UTC (permalink / raw
To: weiyongjun1, Loic Poulain, Greg Kroah-Hartman, Masahiro Yamada
Cc: linux-usb, kernel-janitors, Hulk Robot
Fix build error when CONFIG_WWAN_CORE is not set:
x86_64-linux-gnu-ld: drivers/usb/class/cdc-wdm.o: in function `wdm_disconnect':
cdc-wdm.c:(.text+0xb2a): undefined reference to `wwan_remove_port'
x86_64-linux-gnu-ld: drivers/usb/class/cdc-wdm.o: in function `wdm_in_callback':
cdc-wdm.c:(.text+0xf23): undefined reference to `wwan_port_rx'
x86_64-linux-gnu-ld: drivers/usb/class/cdc-wdm.o: in function `wdm_wwan_port_stop':
cdc-wdm.c:(.text+0x127d): undefined reference to `wwan_port_get_drvdata'
x86_64-linux-gnu-ld: drivers/usb/class/cdc-wdm.o: in function `wdm_wwan_port_tx':
cdc-wdm.c:(.text+0x12d9): undefined reference to `wwan_port_get_drvdata'
x86_64-linux-gnu-ld: cdc-wdm.c:(.text+0x13c1): undefined reference to `wwan_port_txoff'
x86_64-linux-gnu-ld: drivers/usb/class/cdc-wdm.o: in function `wdm_wwan_port_start':
cdc-wdm.c:(.text+0x13e0): undefined reference to `wwan_port_get_drvdata'
x86_64-linux-gnu-ld: cdc-wdm.c:(.text+0x1431): undefined reference to `wwan_port_txon'
x86_64-linux-gnu-ld: drivers/usb/class/cdc-wdm.o: in function `wdm_wwan_port_tx_complete':
cdc-wdm.c:(.text+0x14a4): undefined reference to `wwan_port_txon'
x86_64-linux-gnu-ld: drivers/usb/class/cdc-wdm.o: in function `wdm_create.cold':
cdc-wdm.c:(.text.unlikely+0x209): undefined reference to `wwan_create_port'
Fixes: cac6fb015f71 ("usb: class: cdc-wdm: WWAN framework integration")
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
---
drivers/usb/class/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/usb/class/Kconfig b/drivers/usb/class/Kconfig
index d3f5162bd67e..7e502c046031 100644
--- a/drivers/usb/class/Kconfig
+++ b/drivers/usb/class/Kconfig
@@ -30,6 +30,7 @@ config USB_PRINTER
config USB_WDM
tristate "USB Wireless Device Management support"
+ depends on WWAN_CORE
help
This driver supports the WMC Device Management functionality
of cell phones compliant to the CDC WMC specification. You can use
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH -next] usb: cdc-wdm: fix build error when CONFIG_WWAN_CORE is not set
2021-05-20 13:42 [PATCH -next] usb: cdc-wdm: fix build error when CONFIG_WWAN_CORE is not set Wei Yongjun
@ 2021-05-20 16:00 ` Loic Poulain
0 siblings, 0 replies; 2+ messages in thread
From: Loic Poulain @ 2021-05-20 16:00 UTC (permalink / raw
To: Wei Yongjun
Cc: Greg Kroah-Hartman, Masahiro Yamada, USB, kernel-janitors,
Hulk Robot
Hi Wei,
On Thu, 20 May 2021 at 15:32, Wei Yongjun <weiyongjun1@huawei.com> wrote:
>
> Fix build error when CONFIG_WWAN_CORE is not set:
>
> x86_64-linux-gnu-ld: drivers/usb/class/cdc-wdm.o: in function `wdm_disconnect':
> cdc-wdm.c:(.text+0xb2a): undefined reference to `wwan_remove_port'
> x86_64-linux-gnu-ld: drivers/usb/class/cdc-wdm.o: in function `wdm_in_callback':
> cdc-wdm.c:(.text+0xf23): undefined reference to `wwan_port_rx'
> x86_64-linux-gnu-ld: drivers/usb/class/cdc-wdm.o: in function `wdm_wwan_port_stop':
> cdc-wdm.c:(.text+0x127d): undefined reference to `wwan_port_get_drvdata'
> x86_64-linux-gnu-ld: drivers/usb/class/cdc-wdm.o: in function `wdm_wwan_port_tx':
> cdc-wdm.c:(.text+0x12d9): undefined reference to `wwan_port_get_drvdata'
> x86_64-linux-gnu-ld: cdc-wdm.c:(.text+0x13c1): undefined reference to `wwan_port_txoff'
> x86_64-linux-gnu-ld: drivers/usb/class/cdc-wdm.o: in function `wdm_wwan_port_start':
> cdc-wdm.c:(.text+0x13e0): undefined reference to `wwan_port_get_drvdata'
> x86_64-linux-gnu-ld: cdc-wdm.c:(.text+0x1431): undefined reference to `wwan_port_txon'
> x86_64-linux-gnu-ld: drivers/usb/class/cdc-wdm.o: in function `wdm_wwan_port_tx_complete':
> cdc-wdm.c:(.text+0x14a4): undefined reference to `wwan_port_txon'
> x86_64-linux-gnu-ld: drivers/usb/class/cdc-wdm.o: in function `wdm_create.cold':
> cdc-wdm.c:(.text.unlikely+0x209): undefined reference to `wwan_create_port'
>
> Fixes: cac6fb015f71 ("usb: class: cdc-wdm: WWAN framework integration")
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
> ---
> drivers/usb/class/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/usb/class/Kconfig b/drivers/usb/class/Kconfig
> index d3f5162bd67e..7e502c046031 100644
> --- a/drivers/usb/class/Kconfig
> +++ b/drivers/usb/class/Kconfig
> @@ -30,6 +30,7 @@ config USB_PRINTER
>
> config USB_WDM
> tristate "USB Wireless Device Management support"
> + depends on WWAN_CORE
> help
> This driver supports the WMC Device Management functionality
> of cell phones compliant to the CDC WMC specification. You can use
Thanks for fixing this. Some *optional* code in cdc-wdm.c is flagged
with CONFIG_WWAN instead of CONFIG_WWAN_CORE. would it be possible to
change that flags in the code instead of adding a dependency?
Regards,
Loic
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-05-20 15:52 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-05-20 13:42 [PATCH -next] usb: cdc-wdm: fix build error when CONFIG_WWAN_CORE is not set Wei Yongjun
2021-05-20 16:00 ` Loic Poulain
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.