From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B4EB0C432BE for ; Fri, 30 Jul 2021 12:11:05 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8BE8E60BD3 for ; Fri, 30 Jul 2021 12:11:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238698AbhG3MLJ (ORCPT ); Fri, 30 Jul 2021 08:11:09 -0400 Received: from mail-ua1-f43.google.com ([209.85.222.43]:35396 "EHLO mail-ua1-f43.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230355AbhG3MLJ (ORCPT ); Fri, 30 Jul 2021 08:11:09 -0400 Received: by mail-ua1-f43.google.com with SMTP id d6so3902651uav.2; Fri, 30 Jul 2021 05:11:03 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=d1AP8LPdt5gLRcNBYwMWgjeQ1bzCQMAmgWKrYpeBe5c=; b=UfxTxMXQK7WuExWzdCOv+fELfr0/9t5//TG9O4L25q+0zV+nWOqtlro0jWy11IJZ5A VruVnie8oYKnb68TBpsil+kH38ZzHHWw+WCpdxh55AFY32DCHq4z21xZC7cXC+CeJPGl 3txjAqDDcy2MfE770p7nvaNcpNLtpvgQKNI5UDdQGxCQ8dGfbH2C/6XFyJV1AOYVm1Qu lhalp8EhDxXcliVce2DtYjNtRE0ms0YVPEGgRoTZQ9B8Xn/IRgKuhv/U0EFsm0u4W120 nDL/6xaNZ1tffpgmX0dB6eICX3xpFLNu/7aP3BOjawDUvLAPPvf1khFG/Ibo4/0ZNnDZ JAxg== X-Gm-Message-State: AOAM5334GB2EcI3HrTFEfYCHXUG0nJR1IUNHP6eGpcQ1b49Jn2RzQqpZ bZc9FHyBgpzYCKxe5UhZJ039R9T57RYkpCmgNxM= X-Google-Smtp-Source: ABdhPJyJIDGhorRsiTqEzT0ML14O7jJqLNtZ9KfHFwW349DtL2Ol7UsTGiP4f+Vce5YzoGm5XXEPffA4L4axFg+WdnE= X-Received: by 2002:ab0:6710:: with SMTP id q16mr1321715uam.106.1627647063191; Fri, 30 Jul 2021 05:11:03 -0700 (PDT) MIME-Version: 1.0 References: <20210728153736.15240-1-laurent.pinchart+renesas@ideasonboard.com> <20210728153736.15240-4-laurent.pinchart+renesas@ideasonboard.com> In-Reply-To: <20210728153736.15240-4-laurent.pinchart+renesas@ideasonboard.com> From: Geert Uytterhoeven Date: Fri, 30 Jul 2021 14:10:52 +0200 Message-ID: Subject: Re: [PATCH 3/7] drm/imx/dcss: Enable COMPILE_TEST on all ARM64 platforms To: Laurent Pinchart Cc: DRI Development , Linux-Renesas , linux-tegra , Laurentiu Palcu , Lucas Stach , Philipp Zabel , Shawn Guo , Sascha Hauer , Fabio Estevam , NXP Linux Team , Tomi Valkeinen , Thierry Reding , Jonathan Hunter , Jyri Sarha Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-renesas-soc@vger.kernel.org Hi Laurent, On Wed, Jul 28, 2021 at 5:37 PM Laurent Pinchart wrote: > To extend test coverage, relax the dependency on ARCH_MXC to also enable > compilation when COMPILE_TEST is selected. > > Signed-off-by: Laurent Pinchart Thanks for your patch! > --- a/drivers/gpu/drm/imx/dcss/Kconfig > +++ b/drivers/gpu/drm/imx/dcss/Kconfig > @@ -3,7 +3,8 @@ config DRM_IMX_DCSS > select IMX_IRQSTEER > select DRM_KMS_CMA_HELPER > select VIDEOMODE_HELPERS > - depends on DRM && ARCH_MXC && ARM64 > + depends on DRM > + depends on ARM64 && (ARCH_MXC || COMPILE_TEST) As you now have two depends statements, I think this would be easier to read by maintaining a strict separation between "hard" and "soft" dependencies: depends on DRM && ARM64 depends on ARCH_MXC || COMPILE_TEST Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7BFF9C4320A for ; Fri, 30 Jul 2021 12:11:06 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4253760C41 for ; Fri, 30 Jul 2021 12:11:06 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 4253760C41 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linux-m68k.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 6C9EB6E303; Fri, 30 Jul 2021 12:11:05 +0000 (UTC) Received: from mail-ua1-f50.google.com (mail-ua1-f50.google.com [209.85.222.50]) by gabe.freedesktop.org (Postfix) with ESMTPS id E42306E303 for ; Fri, 30 Jul 2021 12:11:04 +0000 (UTC) Received: by mail-ua1-f50.google.com with SMTP id j15so3897350uaa.5 for ; Fri, 30 Jul 2021 05:11:04 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=d1AP8LPdt5gLRcNBYwMWgjeQ1bzCQMAmgWKrYpeBe5c=; b=tSykqA2aAyJJDqP7Ijt4zX6yauUoVY6t7gKr83KjMcL8h4wVj4KTiB6CmOqNFGU8hM m1H0v1oFUGOLX9QVmXU9sI0vBbO7LAFjq4kSLvNZB6FTAQ+XJItjQ1b6GjcMJEs0cI8e m/ajJMGmN1iLuREM6dpRAVHVRYTZ7KOegp0Ie9W30Kd0iOOE+ZGl4hoc+6Jh2L52ji0c PKAdynEt7otVaaUvjTOBCMcoGm5cwjI/zKuNB3MpRv/OsB3WniNw1l9zFshwohCkqyXo YsL/4A6jyz/xL/xZnjJ0CcvggV/qDRKMcTmuQXjM3C4L2DtL4fgD+A5SWD8+AMq73VdN xAmg== X-Gm-Message-State: AOAM5304UVUTJOrwvX1lT2+7xNqkHqM2vS50fPSuaY8+xOg1q4sL+qxK PRijcH8YxA27YqXcqr3ZDQ6SKKD7TNUIjK0yg4pm24hiPZM8Eg== X-Google-Smtp-Source: ABdhPJyJIDGhorRsiTqEzT0ML14O7jJqLNtZ9KfHFwW349DtL2Ol7UsTGiP4f+Vce5YzoGm5XXEPffA4L4axFg+WdnE= X-Received: by 2002:ab0:6710:: with SMTP id q16mr1321715uam.106.1627647063191; Fri, 30 Jul 2021 05:11:03 -0700 (PDT) MIME-Version: 1.0 References: <20210728153736.15240-1-laurent.pinchart+renesas@ideasonboard.com> <20210728153736.15240-4-laurent.pinchart+renesas@ideasonboard.com> In-Reply-To: <20210728153736.15240-4-laurent.pinchart+renesas@ideasonboard.com> From: Geert Uytterhoeven Date: Fri, 30 Jul 2021 14:10:52 +0200 Message-ID: Subject: Re: [PATCH 3/7] drm/imx/dcss: Enable COMPILE_TEST on all ARM64 platforms To: Laurent Pinchart Content-Type: text/plain; charset="UTF-8" X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Tomi Valkeinen , Sascha Hauer , Jyri Sarha , DRI Development , Jonathan Hunter , Linux-Renesas , Thierry Reding , NXP Linux Team , Laurentiu Palcu , linux-tegra , Shawn Guo Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Hi Laurent, On Wed, Jul 28, 2021 at 5:37 PM Laurent Pinchart wrote: > To extend test coverage, relax the dependency on ARCH_MXC to also enable > compilation when COMPILE_TEST is selected. > > Signed-off-by: Laurent Pinchart Thanks for your patch! > --- a/drivers/gpu/drm/imx/dcss/Kconfig > +++ b/drivers/gpu/drm/imx/dcss/Kconfig > @@ -3,7 +3,8 @@ config DRM_IMX_DCSS > select IMX_IRQSTEER > select DRM_KMS_CMA_HELPER > select VIDEOMODE_HELPERS > - depends on DRM && ARCH_MXC && ARM64 > + depends on DRM > + depends on ARM64 && (ARCH_MXC || COMPILE_TEST) As you now have two depends statements, I think this would be easier to read by maintaining a strict separation between "hard" and "soft" dependencies: depends on DRM && ARM64 depends on ARCH_MXC || COMPILE_TEST Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds