From: Vadim Kochan <vadim4j@gmail.com>
To: Scott Moser <smoser@ubuntu.com>
Cc: Karel Zak <kzak@redhat.com>, util-linux@vger.kernel.org
Subject: Re: GPT writing of unknown partition uuids
Date: Wed, 15 Jul 2015 18:12:31 +0300 [thread overview]
Message-ID: <CAMw6YJJVpeRSkPM-9CtajNX+T0i2U18H0Mdeq4XAJHK=z9FLpA@mail.gmail.com> (raw)
In-Reply-To: <20150715150949.GA28525@angus-think.wlc.globallogic.com>
oops wrong place ...
On Wed, Jul 15, 2015 at 6:09 PM, Vadim Kochan <vadim4j@gmail.com> wrote:
> On Wed, Jul 15, 2015 at 10:56:48AM -0400, Scott Moser wrote:
>> On Wed, 15 Jul 2015, Karel Zak wrote:
>>
>> > On Tue, Jul 14, 2015 at 04:16:56PM -0400, Scott Moser wrote:
>> > > It seems like if the user provided you with a GUID, sfdisk should trust
>> > > them, or at very least exit failure if it refuses to use the provided
>> > > GUID.
>> > >
>> > > Thoughts?
>> >
>> > It's bug, the "unknown" partition type is expected. Fixed in git tree:
>> >
>> > # sfdisk -ql /dev/sdc
>> > Device Start End Sectors Size Type
>> > /dev/sdc1 2048 1023966 1021919 499M Linux filesystem
>> >
>> >
>> > # sfdisk --part-type /dev/sdc 1 $(uuidgen)
>> > ...
>> >
>> >
>> > # sfdisk -ql /dev/sdc
>> > Device Start End Sectors Size Type
>> > /dev/sdc1 2048 1023966 1021919 499M unknown
>> >
>> >
>> > Thanks for your report!
>> Thanks for the quick fix.
>>
>> Is it sane for me to assume this is fixed in any version of
>> util-linux > 2.26.2 ?
>> --
>> To unsubscribe from this list: send the line "unsubscribe util-linux" in
>> the body of a message to majordomo@vger.kernel.org
>> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Would you please test a following fix ?
>
> diff --git a/misc/ss.c b/misc/ss.c
> index 03f92fa..3a826e4 100644
> --- a/misc/ss.c
> +++ b/misc/ss.c
> @@ -683,8 +683,8 @@ static inline void sock_addr_set_str(inet_prefix *prefix, char **ptr)
>
> static inline char *sock_addr_get_str(const inet_prefix *prefix)
> {
> - char *tmp ;
> - memcpy(&tmp, prefix->data, sizeof(char *));
> + char *tmp;
> + memcpy(&tmp, &prefix->data[0], sizeof(char *));
> return tmp;
> }
>
prev parent reply other threads:[~2015-07-15 15:12 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-14 20:16 GPT writing of unknown partition uuids Scott Moser
2015-07-15 0:37 ` Dale R. Worley
2015-07-15 13:28 ` Scott Moser
2015-07-15 13:42 ` Karel Zak
2015-07-15 14:56 ` Scott Moser
2015-07-15 15:02 ` Karel Zak
2015-07-15 15:09 ` Vadim Kochan
2015-07-15 15:12 ` Vadim Kochan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAMw6YJJVpeRSkPM-9CtajNX+T0i2U18H0Mdeq4XAJHK=z9FLpA@mail.gmail.com' \
--to=vadim4j@gmail.com \
--cc=kzak@redhat.com \
--cc=smoser@ubuntu.com \
--cc=util-linux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.