From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9A081C43334 for ; Tue, 12 Jul 2022 15:11:14 +0000 (UTC) Received: from localhost ([::1]:48162 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oBHXd-0001a8-Jv for qemu-devel@archiver.kernel.org; Tue, 12 Jul 2022 11:11:13 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:37904) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oBHVc-0000DZ-In for qemu-devel@nongnu.org; Tue, 12 Jul 2022 11:09:08 -0400 Received: from mail-vk1-xa2c.google.com ([2607:f8b0:4864:20::a2c]:40580) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oBHVa-0001fG-NI for qemu-devel@nongnu.org; Tue, 12 Jul 2022 11:09:08 -0400 Received: by mail-vk1-xa2c.google.com with SMTP id u204so3887639vkb.7 for ; Tue, 12 Jul 2022 08:09:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20210112.gappssmtp.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=a1sJGfUSMx4pE+6cQe+TBcBQaHB3mgJcCgnR28Hct30=; b=1PspVX8CsTcxY/O7P71MpPcwpCqWT4oS4HwmfI/8R7gg6CvkoHrfeAjAK8HyFmUyHd IGhHjJIedLCA+bKfffmeDHk0boFL4EpjWI983PiodZK2NnXq8dEGnWgg33bsVFjMB4hK LYcZFBrzysq8zvWCQZR41KtBoU95vNymO2PcF2vnMqwGjJyo3EaikcyXPDbNVD1mPZyL dEnjPVWnOsxrjKeNIB2KCFfw7CTE8P0FR0U54Y2wM3h/mHvFsY7n9GmwSoghjK9Gj0oS RsCGELMgm6yR8IZQv4GHf0+To4hUEERrvFeggZrKVGlcGYXxdqV3KkroWDVrfc2jBcFi fNMA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=a1sJGfUSMx4pE+6cQe+TBcBQaHB3mgJcCgnR28Hct30=; b=xoMAHxEMYZQ+FKiaXd/aU75Xp5QDwI1J2IvHznmXpSjmnRgc+t5n84MdxmyEsDclVa YyXK0TlkelxUGGCiNP0ooSrrf4tadgX/Vszk+7o7ZLrsGg5FH8KhYmbGccc/Stw09qzZ zTD1JE0CasUP5mBJ/iiCTp1QDw/oh6dg8+Xt1/mVSvzKediIEcxHEAsHKNWMGDNsNwgt h6JqS/BVWb3fc/KJhmTi8FAFnXJGhPi2VmB4DWZIwzBmOsTaw0WeqZK8r0OY72H9A2dm zk0euk9mjeFfVmDdYdCWywBe61TCJaj7W5HxtYTvGM+A32DaLXgX78lr7Ao23yBkQ5+8 Z+ow== X-Gm-Message-State: AJIora/m95lVaq+9MMY2PndAsf9EbycQOsC811nTt01f4E576Krjwuge OVHdA51Q8tTQzANcDUYPwUj6a5e6b6L/MLH7YxG1Ow== X-Google-Smtp-Source: AGRyM1th4K49/ZPvA7EKmOHcUhQpogB4eUOWxdUhuEBqBtOJKg8afE2PyoW5bam10fE3xNzO9PS+IqnqOmfU/j0iycM= X-Received: by 2002:a1f:2144:0:b0:374:a271:6313 with SMTP id h65-20020a1f2144000000b00374a2716313mr5012970vkh.23.1657638545246; Tue, 12 Jul 2022 08:09:05 -0700 (PDT) MIME-Version: 1.0 References: <20220712093528.4144184-1-marcandre.lureau@redhat.com> <20220712093528.4144184-9-marcandre.lureau@redhat.com> In-Reply-To: <20220712093528.4144184-9-marcandre.lureau@redhat.com> From: Warner Losh Date: Tue, 12 Jul 2022 09:08:54 -0600 Message-ID: Subject: Re: [PATCH v2 08/15] scripts/qapi: add required system includes to visitor To: =?UTF-8?B?TWFyYy1BbmRyw6kgTHVyZWF1?= Cc: QEMU Developers , Eric Blake , Cleber Rosa , "open list:Block layer core" , Paolo Bonzini , Xie Yongji , Kyle Evans , Peter Maydell , John Snow , Michael Roth , Kevin Wolf , "Dr. David Alan Gilbert" , Markus Armbruster , Vladimir Sementsov-Ogievskiy , Laurent Vivier , Fam Zheng , Hanna Reitz Content-Type: multipart/alternative; boundary="000000000000a7de6705e39d0cd4" Received-SPF: none client-ip=2607:f8b0:4864:20::a2c; envelope-from=wlosh@bsdimp.com; helo=mail-vk1-xa2c.google.com X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_NONE=0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" --000000000000a7de6705e39d0cd4 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Tue, Jul 12, 2022 at 3:36 AM wrote: > From: Marc-Andr=C3=A9 Lureau > > The generated visitor code includes abort() & assert(), we shouldn't > rely on the global "-i" headers to include the necessary system headers. > > Signed-off-by: Marc-Andr=C3=A9 Lureau > --- > scripts/qapi/visit.py | 2 ++ > 1 file changed, 2 insertions(+) > Reviewed-by: Warner Losh > diff --git a/scripts/qapi/visit.py b/scripts/qapi/visit.py > index 1ff464c0360f..4aba5ddd8af4 100644 > --- a/scripts/qapi/visit.py > +++ b/scripts/qapi/visit.py > @@ -342,6 +342,8 @@ def _begin_user_module(self, name: str) -> None: > visit =3D self._module_basename('qapi-visit', name) > self._genc.preamble_add(mcgen(''' > %(include)s > +#include > +#include > > #include "qapi/error.h" > #include "qapi/qmp/qerror.h" > -- > 2.37.0.rc0 > > --000000000000a7de6705e39d0cd4 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


=
On Tue, Jul 12, 2022 at 3:36 AM <<= a href=3D"mailto:marcandre.lureau@redhat.com">marcandre.lureau@redhat.com> wrote:
Fr= om: Marc-Andr=C3=A9 Lureau <marcandre.lureau@redhat.com>

The generated visitor code includes abort() & assert(), we shouldn'= t
rely on the global "-i" headers to include the necessary system h= eaders.

Signed-off-by: Marc-Andr=C3=A9 Lureau <marcandre.lureau@redhat.com>
---
=C2=A0scripts/qapi/visit.py | 2 ++
=C2=A01 file changed, 2 insertions(+)

R= eviewed-by: Warner Losh <imp@bsdimp.co= m>
=C2=A0
diff --git a/scripts/qapi/visit.py b/scripts/qapi/visit.py
index 1ff464c0360f..4aba5ddd8af4 100644
--- a/scripts/qapi/visit.py
+++ b/scripts/qapi/visit.py
@@ -342,6 +342,8 @@ def _begin_user_module(self, name: str) -> None:
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0visit =3D self._module_basename('qapi= -visit', name)
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0self._genc.preamble_add(mcgen(''&= #39;
=C2=A0%(include)s
+#include <assert.h>
+#include <stdlib.h>

=C2=A0#include "qapi/error.h"
=C2=A0#include "qapi/qmp/qerror.h"
--
2.37.0.rc0

--000000000000a7de6705e39d0cd4--