* [GIT PULL] auxdisplay for v5.1-rc2
@ 2019-03-23 17:13 Miguel Ojeda
2019-03-24 18:40 ` pr-tracker-bot
2019-03-24 21:10 ` Linus Torvalds
0 siblings, 2 replies; 4+ messages in thread
From: Miguel Ojeda @ 2019-03-23 17:13 UTC (permalink / raw
To: Linus Torvalds
Cc: Andy Shevchenko, Mans Rullgard, Geert Uytterhoeven,
Ksenija Stanojevic, Randy Dunlap, Miguel Ojeda, linux-kernel
Hi Linus,
Please pull these fixes and improvements for auxdisplay.
Cheers,
Miguel
The following changes since commit 1c163f4c7b3f621efff9b28a47abb36f7378d783:
Linux 5.0 (2019-03-03 15:21:29 -0800)
are available in the Git repository at:
https://github.com/ojeda/linux.git tags/auxdisplay-for-linus-v5.1-rc2
for you to fetch changes up to cc5d04d840d62d7c75e268c51da7cd0be2ee03c0:
auxdisplay: charlcd: make backlight initial state configurable (2019-03-17 08:48:45 +0100)
----------------------------------------------------------------
A few fixes and improvements for auxdisplay:
- Series to fix a memory leak in hd44780
while introducing charlcd_free().
From Andy Shevchenko
- Series to clean up the Kconfig menus and
a couple of improvements for charlcd.
From Mans Rullgard
----------------------------------------------------------------
Andy Shevchenko (5):
auxdisplay: hd44780: Fix memory leak on ->remove()
auxdisplay: charlcd: Move to_priv() to charlcd namespace
auxdisplay: charlcd: Introduce charlcd_free() helper
auxdisplay: panel: Convert to use charlcd_free()
auxdisplay: hd44780: Convert to use charlcd_free()
Mans Rullgard (3):
auxdisplay: deconfuse configuration
auxdisplay: charlcd: simplify init message display
auxdisplay: charlcd: make backlight initial state configurable
drivers/auxdisplay/Kconfig | 38 ++++++++++++++++++++++++++----
drivers/auxdisplay/Makefile | 2 +-
drivers/auxdisplay/charlcd.c | 55 ++++++++++++++++++++++++++++----------------
drivers/auxdisplay/hd44780.c | 4 +++-
drivers/auxdisplay/panel.c | 4 ++--
include/misc/charlcd.h | 1 +
6 files changed, 75 insertions(+), 29 deletions(-)
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [GIT PULL] auxdisplay for v5.1-rc2
2019-03-23 17:13 [GIT PULL] auxdisplay for v5.1-rc2 Miguel Ojeda
@ 2019-03-24 18:40 ` pr-tracker-bot
2019-03-24 21:10 ` Linus Torvalds
1 sibling, 0 replies; 4+ messages in thread
From: pr-tracker-bot @ 2019-03-24 18:40 UTC (permalink / raw
To: Miguel Ojeda
Cc: Linus Torvalds, Andy Shevchenko, Mans Rullgard,
Geert Uytterhoeven, Ksenija Stanojevic, Randy Dunlap,
Miguel Ojeda, linux-kernel
The pull request you sent on Sat, 23 Mar 2019 18:13:43 +0100:
> https://github.com/ojeda/linux.git tags/auxdisplay-for-linus-v5.1-rc2
has been merged into torvalds/linux.git:
https://git.kernel.org/torvalds/c/e0046bb302dad1c3e766eb7c171930d01f9439fa
Thank you!
--
Deet-doot-dot, I am a bot.
https://korg.wiki.kernel.org/userdoc/prtracker
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [GIT PULL] auxdisplay for v5.1-rc2
2019-03-23 17:13 [GIT PULL] auxdisplay for v5.1-rc2 Miguel Ojeda
2019-03-24 18:40 ` pr-tracker-bot
@ 2019-03-24 21:10 ` Linus Torvalds
2019-03-24 22:01 ` Miguel Ojeda
1 sibling, 1 reply; 4+ messages in thread
From: Linus Torvalds @ 2019-03-24 21:10 UTC (permalink / raw
To: Miguel Ojeda
Cc: Andy Shevchenko, Mans Rullgard, Geert Uytterhoeven,
Ksenija Stanojevic, Randy Dunlap, Linux List Kernel Mailing
On Sat, Mar 23, 2019 at 10:13 AM Miguel Ojeda
<miguel.ojeda.sandonis@gmail.com> wrote:
>
> - Series to clean up the Kconfig menus and
> a couple of improvements for charlcd.
> From Mans Rullgard
Side note: this is very annoying. As part of the rc release I'm going
through things like this, and I notice that the new Kconfig option has
absolutely no help text.
That might be acceptable if the choice of options made sense and would
be obvious to people, but they aren't obvious. Particularly not when
you come from not having an option at all, it's not at all clear that
what _used_ to happen was that "flash" option.
And yes, the Kconfig source code makes it look like there are help
texts. But a help text on the individual options for a choice isn't
actually shown when you ask for help - it's the help text for the
*choice* that matters. Not that those invisible help texts actually
_help_ anything anyway.
Linus
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [GIT PULL] auxdisplay for v5.1-rc2
2019-03-24 21:10 ` Linus Torvalds
@ 2019-03-24 22:01 ` Miguel Ojeda
0 siblings, 0 replies; 4+ messages in thread
From: Miguel Ojeda @ 2019-03-24 22:01 UTC (permalink / raw
To: Linus Torvalds
Cc: Andy Shevchenko, Mans Rullgard, Geert Uytterhoeven,
Ksenija Stanojevic, Randy Dunlap, Linux List Kernel Mailing
Hi Linus,
On Sun, Mar 24, 2019 at 10:10 PM Linus Torvalds
<torvalds@linux-foundation.org> wrote:
>
> Side note: this is very annoying. As part of the rc release I'm going
> through things like this, and I notice that the new Kconfig option has
> absolutely no help text.
>
> That might be acceptable if the choice of options made sense and would
> be obvious to people, but they aren't obvious. Particularly not when
> you come from not having an option at all, it's not at all clear that
> what _used_ to happen was that "flash" option.
>
> And yes, the Kconfig source code makes it look like there are help
> texts. But a help text on the individual options for a choice isn't
> actually shown when you ask for help - it's the help text for the
> *choice* that matters. Not that those invisible help texts actually
> _help_ anything anyway.
The help on the actual option is a good point; we will add it. Also
the Kconfig in general needs a bit of love, I think.
Thanks a lot for taking a look, by the way!
Cheers,
Miguel
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-03-24 22:01 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-03-23 17:13 [GIT PULL] auxdisplay for v5.1-rc2 Miguel Ojeda
2019-03-24 18:40 ` pr-tracker-bot
2019-03-24 21:10 ` Linus Torvalds
2019-03-24 22:01 ` Miguel Ojeda
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.