From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AD8F2C433ED for ; Tue, 11 May 2021 08:24:09 +0000 (UTC) Received: from smtp2.osuosl.org (smtp2.osuosl.org [140.211.166.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 183336193F for ; Tue, 11 May 2021 08:24:09 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 183336193F Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=daynix.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=virtualization-bounces@lists.linux-foundation.org Received: from localhost (localhost [127.0.0.1]) by smtp2.osuosl.org (Postfix) with ESMTP id 9970E405AF; Tue, 11 May 2021 08:24:08 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp2.osuosl.org ([127.0.0.1]) by localhost (smtp2.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 0fV9KxhDX7uw; Tue, 11 May 2021 08:24:07 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [IPv6:2605:bc80:3010:104::8cd3:938]) by smtp2.osuosl.org (Postfix) with ESMTP id 8FD84405B6; Tue, 11 May 2021 08:24:06 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id 565B1C000D; Tue, 11 May 2021 08:24:06 +0000 (UTC) Received: from smtp3.osuosl.org (smtp3.osuosl.org [IPv6:2605:bc80:3010::136]) by lists.linuxfoundation.org (Postfix) with ESMTP id C7F84C0001 for ; Tue, 11 May 2021 08:24:04 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp3.osuosl.org (Postfix) with ESMTP id A156960703 for ; Tue, 11 May 2021 08:24:04 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Authentication-Results: smtp3.osuosl.org (amavisd-new); dkim=pass (2048-bit key) header.d=daynix-com.20150623.gappssmtp.com Received: from smtp3.osuosl.org ([127.0.0.1]) by localhost (smtp3.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id hEmDy8tf63t5 for ; Tue, 11 May 2021 08:24:04 +0000 (UTC) X-Greylist: whitelisted by SQLgrey-1.8.0 Received: from mail-ot1-x32d.google.com (mail-ot1-x32d.google.com [IPv6:2607:f8b0:4864:20::32d]) by smtp3.osuosl.org (Postfix) with ESMTPS id F2DA16064A for ; Tue, 11 May 2021 08:24:03 +0000 (UTC) Received: by mail-ot1-x32d.google.com with SMTP id d3-20020a9d29030000b029027e8019067fso16792509otb.13 for ; Tue, 11 May 2021 01:24:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=daynix-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=8c3iY9QRs+Fk/AUUgLxZIXmDXwT2HDilLt2LH9nAQ6U=; b=SqBwnwM/kJAFlwEGwiDXj9c7Ma91fjZu8ayYoELqm6GAIraQZAPdhEQs9Hoyl60W7M 9Ce+tx+Gq0OFiKUjBDFbh8nmAsNk3mVX8aqVUZ/0OUYvPd6aP9FxVuD8qcxKLUJqcJFj puE3BNalWBDmjJhF+s/HUDKh2qdbsPyxeVVBrifg/Hfyf/Ctj6UoSwML0EHIFaxkD+QY gm+xTm6+/oSes6XIfdyECwuy1wC3CzjtM0nDX3ec/4ay5/DjTSzzkuiH7noGXBu/Z66t 4Pbpacn7kC8sS5PNmMjh0yzrPmqbjG8KPdHgYw9ca0CNg+In5D9zM8//YMnN6E18QQmV TvGA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=8c3iY9QRs+Fk/AUUgLxZIXmDXwT2HDilLt2LH9nAQ6U=; b=MF9SkfgCLMKEz44BSU5qA1TxYMQKq5nMVNYIat+4b5HEoKRgcep0WANG0w+PAb9oQW rauxKQbEZdJfj0jUwJTHuCm/hBjznYwhywdpNYJL0qXTV3PXewjEXXqvbHKKI3+WzzxS uPjONvTXLHo3qxswVp/IH7tSnOGuMd+Y1ZjVQgkdzlm7QDczpZaMvxBlGxDA1AlHWGV0 uGaVxxl03LJa/kLngZJiVcX+yGLngS2kzSkKAny9jPCO6+1ch/ruQQ9llBbuReZfGzGp EFX6b5G9FgN8rDXL/LJda5m+SKO9fweg8Suw6skETE01w9BiIhXbHVa1zrwvvDZHVZsv R8AA== X-Gm-Message-State: AOAM532cd/ygy7BECLZDDyAxa6wE7oLANDN7xPTZv+WoK7jYBEPN46JN 7dSKJi9EF2+sPPkWX9ViAhN1J+TXHScdhHXHpcI17g== X-Google-Smtp-Source: ABdhPJyzEzyAj7Z5kcPuJk020RtLC8q4XOzVGi2sBCvpkZMkNcD6BbF/QWJXnNothiQ8DxWnWDUczdozPrAwgSSS7bA= X-Received: by 2002:a05:6830:4103:: with SMTP id w3mr20687928ott.27.1620721442871; Tue, 11 May 2021 01:24:02 -0700 (PDT) MIME-Version: 1.0 References: <20210511044253.469034-1-yuri.benditovich@daynix.com> <20210511044253.469034-3-yuri.benditovich@daynix.com> <0e31ea70-f12a-070e-c72b-6e1d337a89bc@redhat.com> In-Reply-To: <0e31ea70-f12a-070e-c72b-6e1d337a89bc@redhat.com> From: Yuri Benditovich Date: Tue, 11 May 2021 11:23:50 +0300 Message-ID: Subject: Re: [PATCH 2/4] virtio-net: add support of UDP segmentation (USO) on the host To: Jason Wang Cc: "Michael S . Tsirkin" , Network Development , LKML , virtualization@lists.linux-foundation.org, Yan Vugenfirer , Jakub Kicinski , "David S. Miller" X-BeenThere: virtualization@lists.linux-foundation.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Linux virtualization List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: virtualization-bounces@lists.linux-foundation.org Sender: "Virtualization" T24gVHVlLCBNYXkgMTEsIDIwMjEgYXQgOTo0NyBBTSBKYXNvbiBXYW5nIDxqYXNvd2FuZ0ByZWRo YXQuY29tPiB3cm90ZToKPgo+Cj4g5ZyoIDIwMjEvNS8xMSDkuIvljYgxMjo0MiwgWXVyaSBCZW5k aXRvdmljaCDlhpnpgZM6Cj4gPiBMYXJnZSBVRFAgcGFja2V0IHByb3ZpZGVkIGJ5IHRoZSBndWVz dCB3aXRoIEdTTyB0eXBlIHNldCB0bwo+ID4gVklSVElPX05FVF9IRFJfR1NPX1VEUF9MNCB3aWxs IGJlIGRpdmlkZWQgdG8gc2V2ZXJhbCBVRFAKPiA+IHBhY2tldHMgYWNjb3JkaW5nIHRvIHRoZSBn c29fc2l6ZSBmaWVsZC4KPiA+Cj4gPiBTaWduZWQtb2ZmLWJ5OiBZdXJpIEJlbmRpdG92aWNoIDx5 dXJpLmJlbmRpdG92aWNoQGRheW5peC5jb20+Cj4gPiAtLS0KPiA+ICAgaW5jbHVkZS9saW51eC92 aXJ0aW9fbmV0LmggfCA1ICsrKysrCj4gPiAgIDEgZmlsZSBjaGFuZ2VkLCA1IGluc2VydGlvbnMo KykKPiA+Cj4gPiBkaWZmIC0tZ2l0IGEvaW5jbHVkZS9saW51eC92aXJ0aW9fbmV0LmggYi9pbmNs dWRlL2xpbnV4L3ZpcnRpb19uZXQuaAo+ID4gaW5kZXggYjQ2NWY4ZjNlNTU0Li40ZWNmOWExY2E5 MTIgMTAwNjQ0Cj4gPiAtLS0gYS9pbmNsdWRlL2xpbnV4L3ZpcnRpb19uZXQuaAo+ID4gKysrIGIv aW5jbHVkZS9saW51eC92aXJ0aW9fbmV0LmgKPiA+IEBAIC01MSw2ICs1MSwxMSBAQCBzdGF0aWMg aW5saW5lIGludCB2aXJ0aW9fbmV0X2hkcl90b19za2Ioc3RydWN0IHNrX2J1ZmYgKnNrYiwKPiA+ ICAgICAgICAgICAgICAgICAgICAgICBpcF9wcm90byA9IElQUFJPVE9fVURQOwo+ID4gICAgICAg ICAgICAgICAgICAgICAgIHRobGVuID0gc2l6ZW9mKHN0cnVjdCB1ZHBoZHIpOwo+ID4gICAgICAg ICAgICAgICAgICAgICAgIGJyZWFrOwo+ID4gKyAgICAgICAgICAgICBjYXNlIFZJUlRJT19ORVRf SERSX0dTT19VRFBfTDQ6Cj4gPiArICAgICAgICAgICAgICAgICAgICAgZ3NvX3R5cGUgPSBTS0Jf R1NPX1VEUF9MNDsKPiA+ICsgICAgICAgICAgICAgICAgICAgICBpcF9wcm90byA9IElQUFJPVE9f VURQOwo+ID4gKyAgICAgICAgICAgICAgICAgICAgIHRobGVuID0gc2l6ZW9mKHN0cnVjdCB1ZHBo ZHIpOwo+ID4gKyAgICAgICAgICAgICAgICAgICAgIGJyZWFrOwo+Cj4KPiBUaGlzIGlzIG9ubHkg Zm9yIHJ4LCBob3cgYWJvdXQgdHg/CgpJbiB0ZXJtcyBvZiB0aGUgZ3Vlc3QgdGhpcyBpcyBvbmx5 IGZvciBUWC4KR3Vlc3QgUlggaXMgYSBkaWZmZXJlbnQgdGhpbmcsIHRoaXMgaXMgYWN0dWFsbHkg Y29hbGVzY2luZyBvZgpzZWdtZW50ZWQgVURQIHBhY2tldHMgaW50byBhIGxhcmdlIG9uZS4KVGhp cyBmZWF0dXJlIGlzIG5vdCBkZWZpbmVkIGluIHRoZSB2aXJ0aW8gc3BlYyB5ZXQgYW5kIHRoZSBz dXBwb3J0IG9mCml0IGZpcnN0IG9mIGFsbCBkZXBlbmRzIG9uIHRoZSBPUy4KRm9yIGV4YW1wbGU6 IFRDUCBMU08gKGd1ZXN0IFRYKSBpcyBzdXBwb3J0ZWQgYWxtb3N0IGJ5IGFsbCB0aGUKdmVyc2lv bnMgb2YgV2luZG93cy4KVENQIFJTQyAoY29hbGVzY2luZyBvZiBUQ1Agc2VnbWVudHMpIGlzIHN1 cHBvcnRlZCBieSBXaW4gOCAvIFNlcnZlciAyMDEyIGFuZCB1cC4KVURQIHNlZ21lbnRhdGlvbiBp cyBzdXBwb3J0ZWQgYnkgV2luZG93cyBrZXJuZWxzIDE5MDMrClVEUCBjb2FsZXNjaW5nIGlzIGRl ZmluZWQgYnkgV2luZG93cyBrZXJuZWxzIDIwMDQrIGFuZCBub3Qgc3VwcG9ydGVkCmJ5IHRoZSBk cml2ZXIgeWV0LgoKPgo+IFRoYW5rcwo+Cj4KPgo+ID4gICAgICAgICAgICAgICBkZWZhdWx0Ogo+ ID4gICAgICAgICAgICAgICAgICAgICAgIHJldHVybiAtRUlOVkFMOwo+ID4gICAgICAgICAgICAg ICB9Cj4KX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KVmly dHVhbGl6YXRpb24gbWFpbGluZyBsaXN0ClZpcnR1YWxpemF0aW9uQGxpc3RzLmxpbnV4LWZvdW5k YXRpb24ub3JnCmh0dHBzOi8vbGlzdHMubGludXhmb3VuZGF0aW9uLm9yZy9tYWlsbWFuL2xpc3Rp bmZvL3ZpcnR1YWxpemF0aW9u From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F3A56C43462 for ; Tue, 11 May 2021 08:26:48 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id BCF74613CF for ; Tue, 11 May 2021 08:26:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230453AbhEKIZL (ORCPT ); Tue, 11 May 2021 04:25:11 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50496 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230157AbhEKIZJ (ORCPT ); Tue, 11 May 2021 04:25:09 -0400 Received: from mail-ot1-x332.google.com (mail-ot1-x332.google.com [IPv6:2607:f8b0:4864:20::332]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 84EB4C06175F for ; Tue, 11 May 2021 01:24:03 -0700 (PDT) Received: by mail-ot1-x332.google.com with SMTP id 36-20020a9d0ba70000b02902e0a0a8fe36so10520309oth.8 for ; Tue, 11 May 2021 01:24:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=daynix-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=8c3iY9QRs+Fk/AUUgLxZIXmDXwT2HDilLt2LH9nAQ6U=; b=SqBwnwM/kJAFlwEGwiDXj9c7Ma91fjZu8ayYoELqm6GAIraQZAPdhEQs9Hoyl60W7M 9Ce+tx+Gq0OFiKUjBDFbh8nmAsNk3mVX8aqVUZ/0OUYvPd6aP9FxVuD8qcxKLUJqcJFj puE3BNalWBDmjJhF+s/HUDKh2qdbsPyxeVVBrifg/Hfyf/Ctj6UoSwML0EHIFaxkD+QY gm+xTm6+/oSes6XIfdyECwuy1wC3CzjtM0nDX3ec/4ay5/DjTSzzkuiH7noGXBu/Z66t 4Pbpacn7kC8sS5PNmMjh0yzrPmqbjG8KPdHgYw9ca0CNg+In5D9zM8//YMnN6E18QQmV TvGA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=8c3iY9QRs+Fk/AUUgLxZIXmDXwT2HDilLt2LH9nAQ6U=; b=CupYGJhN48Wy3Vdwvmq9dyZ4vurKZ7IKvfSGP6JwSmE2MjDZZS872Ra98uI9t7n1zS V97FpmZMYaMZ5fgRATQ+rMD4SbCpeeucL+4prqFCNk0MIkdzw+WiIQ43glg0Qyl7H/Ev z9LtR/S0M5cK0pmsrnTsJCR+QISuO1CqgvhDLqah08cTaHuAFD1Dm0hJu+zhiPDePdeL vXutyL/vrSFAkI4VVnctokszUou4cE1lf8nwoPHU/aLWM6LHvB7/Gh5TEmsMVSMRnrgb xRdCvjVnFb+eLo15p6grv/qAe4MT/qWOGeEi0uFrQHOsYpghqEMTMPoc0e/dO4w6GD63 jaow== X-Gm-Message-State: AOAM5330SgKGG6FKcF3UaY7yTxGMTyhyH0/uL4Ph/i47RPDvpqmpA8tg 6gki9Op6g3yimmO6V5iIGbxZk05Zs2eNLQ2kxlgM8Q== X-Google-Smtp-Source: ABdhPJyzEzyAj7Z5kcPuJk020RtLC8q4XOzVGi2sBCvpkZMkNcD6BbF/QWJXnNothiQ8DxWnWDUczdozPrAwgSSS7bA= X-Received: by 2002:a05:6830:4103:: with SMTP id w3mr20687928ott.27.1620721442871; Tue, 11 May 2021 01:24:02 -0700 (PDT) MIME-Version: 1.0 References: <20210511044253.469034-1-yuri.benditovich@daynix.com> <20210511044253.469034-3-yuri.benditovich@daynix.com> <0e31ea70-f12a-070e-c72b-6e1d337a89bc@redhat.com> In-Reply-To: <0e31ea70-f12a-070e-c72b-6e1d337a89bc@redhat.com> From: Yuri Benditovich Date: Tue, 11 May 2021 11:23:50 +0300 Message-ID: Subject: Re: [PATCH 2/4] virtio-net: add support of UDP segmentation (USO) on the host To: Jason Wang Cc: "David S. Miller" , Jakub Kicinski , "Michael S . Tsirkin" , Network Development , LKML , virtualization@lists.linux-foundation.org, Yan Vugenfirer Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, May 11, 2021 at 9:47 AM Jason Wang wrote: > > > =E5=9C=A8 2021/5/11 =E4=B8=8B=E5=8D=8812:42, Yuri Benditovich =E5=86=99= =E9=81=93: > > Large UDP packet provided by the guest with GSO type set to > > VIRTIO_NET_HDR_GSO_UDP_L4 will be divided to several UDP > > packets according to the gso_size field. > > > > Signed-off-by: Yuri Benditovich > > --- > > include/linux/virtio_net.h | 5 +++++ > > 1 file changed, 5 insertions(+) > > > > diff --git a/include/linux/virtio_net.h b/include/linux/virtio_net.h > > index b465f8f3e554..4ecf9a1ca912 100644 > > --- a/include/linux/virtio_net.h > > +++ b/include/linux/virtio_net.h > > @@ -51,6 +51,11 @@ static inline int virtio_net_hdr_to_skb(struct sk_bu= ff *skb, > > ip_proto =3D IPPROTO_UDP; > > thlen =3D sizeof(struct udphdr); > > break; > > + case VIRTIO_NET_HDR_GSO_UDP_L4: > > + gso_type =3D SKB_GSO_UDP_L4; > > + ip_proto =3D IPPROTO_UDP; > > + thlen =3D sizeof(struct udphdr); > > + break; > > > This is only for rx, how about tx? In terms of the guest this is only for TX. Guest RX is a different thing, this is actually coalescing of segmented UDP packets into a large one. This feature is not defined in the virtio spec yet and the support of it first of all depends on the OS. For example: TCP LSO (guest TX) is supported almost by all the versions of Windows. TCP RSC (coalescing of TCP segments) is supported by Win 8 / Server 2012 an= d up. UDP segmentation is supported by Windows kernels 1903+ UDP coalescing is defined by Windows kernels 2004+ and not supported by the driver yet. > > Thanks > > > > > default: > > return -EINVAL; > > } >