From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <kda@linux-powerpc.org>
Received: from mail-yk0-f180.google.com (mail-yk0-f180.google.com
 [209.85.160.180])
 (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))
 (No client certificate requested)
 by lists.ozlabs.org (Postfix) with ESMTPS id F26EC1A0FE0
 for <linuxppc-dev@lists.ozlabs.org>; Fri,  2 Oct 2015 18:48:58 +1000 (AEST)
Received: by ykdg206 with SMTP id g206so103082754ykd.1
 for <linuxppc-dev@lists.ozlabs.org>; Fri, 02 Oct 2015 01:48:55 -0700 (PDT)
MIME-Version: 1.0
In-Reply-To: <1441684296.14597.2.camel@ellerman.id.au>
References: <1434092231-4155-1-git-send-email-kda@linux-powerpc.org>
 <CAOJe8K0UrsVQraHrxKUptOB9sVr_U9LEB3Ji6j4nMenHKNt2dg@mail.gmail.com>
 <1434676130.3678.124.camel@kernel.crashing.org>
 <CAOJe8K13odLN__uQCc=zXoFYMyjwzEd10eDKG_ZEq5oZf1376A@mail.gmail.com>
 <1441621698.8979.6.camel@ellerman.id.au>
 <CAOJe8K05qVMkC433iZnnBzNBCGD+h5St1rqAvcyCnugMxiGNrA@mail.gmail.com>
 <1441684296.14597.2.camel@ellerman.id.au>
Date: Fri, 2 Oct 2015 11:48:55 +0300
Message-ID: <CAOJe8K2avdaAhtr9vpDkoAEM4FcqO5u7qYF4TRFDKZmsgHEc_g@mail.gmail.com>
Subject: Re: [PATCH] agp/uninorth: fix a memleak in create_gatt_table
From: Denis Kirjanov <kda@linux-powerpc.org>
To: Michael Ellerman <mpe@ellerman.id.au>
Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>,
 linuxppc-dev@lists.ozlabs.org, airlied@gmail.com
Content-Type: text/plain; charset=UTF-8
List-Id: Linux on PowerPC Developers Mail List <linuxppc-dev.lists.ozlabs.org>
List-Unsubscribe: <https://lists.ozlabs.org/options/linuxppc-dev>,
 <mailto:linuxppc-dev-request@lists.ozlabs.org?subject=unsubscribe>
List-Archive: <http://lists.ozlabs.org/pipermail/linuxppc-dev/>
List-Post: <mailto:linuxppc-dev@lists.ozlabs.org>
List-Help: <mailto:linuxppc-dev-request@lists.ozlabs.org?subject=help>
List-Subscribe: <https://lists.ozlabs.org/listinfo/linuxppc-dev>,
 <mailto:linuxppc-dev-request@lists.ozlabs.org?subject=subscribe>

On 9/8/15, Michael Ellerman <mpe@ellerman.id.au> wrote:
> On Mon, 2015-09-07 at 13:39 +0300, Denis Kirjanov wrote:
>> On 9/7/15, Michael Ellerman <mpe@ellerman.id.au> wrote:
>> > On Mon, 2015-09-07 at 10:30 +0300, Denis Kirjanov wrote:
>> >> On 6/19/15, Benjamin Herrenschmidt <benh@kernel.crashing.org> wrote:
>> >> > On Thu, 2015-06-18 at 17:34 +0300, Denis Kirjanov wrote:
>> >> >> On 6/12/15, Denis Kirjanov <kda@linux-powerpc.org> wrote:
>> >> >> > Fix the memory leak in create_gatt_table:
>> >> >> > we've lost a kfree on the exit path for the pages array allocated
>> >> >> > in uninorth_create_gatt_table
>> >> >> >
>> >> >> > Signed-off-by: Denis Kirjanov <kda@linux-powerpc.org>
>> >> >>
>> >> >> Hi Ben, Michael
>> >> >>
>> >> >> Will you take the patch through your trees or do I need to send it
>> >> >> to
>> >> >> Dave Airlie?
>> >> >
>> >> > I haven't had a chance to review yet...
>> >>
>> >> Ping...
>> >
>> > Hi Denis,
>> >
>> > Have you built and/or boot tested this?
>>
>> Hi,
>>
>> yes, sure. Actually I've spotted this through the kmemleak. With the
>> patch applied scanner is happy :)
>
> OK thanks. I'll merge it then, and if Ben ever reviews it and dislikes your
> changes he can send patches to fix it :)

Hi Michael,
could you please apply the patch to fixes branch?

Thanks!
>
> cheers
>
>
>