* [PATCH 135/182] MIPS: alchemy: switch to gpiochip_add_data()
@ 2015-12-09 13:39 Linus Walleij
2015-12-09 13:54 ` Ralf Baechle
2015-12-09 21:44 ` Manuel Lauss
0 siblings, 2 replies; 4+ messages in thread
From: Linus Walleij @ 2015-12-09 13:39 UTC (permalink / raw
To: linux-gpio, Johan Hovold, Alexandre Courbot, Michael Welling,
Markus Pargmann, Ralf Baechle
Cc: Linus Walleij, linux-mips
We're planning to remove the gpiochip_add() function to swith
to gpiochip_add_data() with NULL for data argument.
Cc: Ralf Baechle <ralf@linux-mips.org>
Cc: linux-mips@linux-mips.org
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
---
Ralf: please ACK this so I can take it through the GPIO tree.
BTW: would be nice if the MIPS GPIO drivers could move down
to drivers/gpio in the long run.
---
arch/mips/alchemy/common/gpiolib.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/arch/mips/alchemy/common/gpiolib.c b/arch/mips/alchemy/common/gpiolib.c
index f9bc4f520440..e2606f8eb2fa 100644
--- a/arch/mips/alchemy/common/gpiolib.c
+++ b/arch/mips/alchemy/common/gpiolib.c
@@ -160,14 +160,14 @@ static int __init alchemy_gpiochip_init(void)
switch (alchemy_get_cputype()) {
case ALCHEMY_CPU_AU1000:
- ret = gpiochip_add(&alchemy_gpio_chip[0]);
+ ret = gpiochip_add_data(&alchemy_gpio_chip[0], NULL);
break;
case ALCHEMY_CPU_AU1500...ALCHEMY_CPU_AU1200:
- ret = gpiochip_add(&alchemy_gpio_chip[0]);
- ret |= gpiochip_add(&alchemy_gpio_chip[1]);
+ ret = gpiochip_add_data(&alchemy_gpio_chip[0], NULL);
+ ret |= gpiochip_add_data(&alchemy_gpio_chip[1], NULL);
break;
case ALCHEMY_CPU_AU1300:
- ret = gpiochip_add(&au1300_gpiochip);
+ ret = gpiochip_add_data(&au1300_gpiochip, NULL);
break;
}
return ret;
--
2.4.3
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH 135/182] MIPS: alchemy: switch to gpiochip_add_data()
2015-12-09 13:39 [PATCH 135/182] MIPS: alchemy: switch to gpiochip_add_data() Linus Walleij
@ 2015-12-09 13:54 ` Ralf Baechle
2015-12-09 21:44 ` Manuel Lauss
1 sibling, 0 replies; 4+ messages in thread
From: Ralf Baechle @ 2015-12-09 13:54 UTC (permalink / raw
To: Linus Walleij
Cc: linux-gpio, Johan Hovold, Alexandre Courbot, Michael Welling,
Markus Pargmann, linux-mips
On Wed, Dec 09, 2015 at 02:39:02PM +0100, Linus Walleij wrote:
> We're planning to remove the gpiochip_add() function to swith
> to gpiochip_add_data() with NULL for data argument.
>
> Cc: Ralf Baechle <ralf@linux-mips.org>
> Cc: linux-mips@linux-mips.org
> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
> ---
> Ralf: please ACK this so I can take it through the GPIO tree.
Acked-by: Ralf Baechle <ralf@linux-mips.org>
> BTW: would be nice if the MIPS GPIO drivers could move down
> to drivers/gpio in the long run.
I agree - but for practical reasons this won't happen quickly.
Ralf
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 135/182] MIPS: alchemy: switch to gpiochip_add_data()
2015-12-09 13:39 [PATCH 135/182] MIPS: alchemy: switch to gpiochip_add_data() Linus Walleij
2015-12-09 13:54 ` Ralf Baechle
@ 2015-12-09 21:44 ` Manuel Lauss
2015-12-13 20:25 ` Linus Walleij
1 sibling, 1 reply; 4+ messages in thread
From: Manuel Lauss @ 2015-12-09 21:44 UTC (permalink / raw
To: Linus Walleij
Cc: linux-gpio, Johan Hovold, Alexandre Courbot, Michael Welling,
Markus Pargmann, Ralf Baechle, Linux-MIPS
On Wed, Dec 9, 2015 at 2:39 PM, Linus Walleij <linus.walleij@linaro.org> wrote:
> ---
> Ralf: please ACK this so I can take it through the GPIO tree.
> BTW: would be nice if the MIPS GPIO drivers could move down
> to drivers/gpio in the long run.
Is there a specific reason? I have no objections to moving it, but
on the other hand I also like that (in this case) most/all chip-specific
code is grouped together and not scattered around the tree.
Manuel
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 135/182] MIPS: alchemy: switch to gpiochip_add_data()
2015-12-09 21:44 ` Manuel Lauss
@ 2015-12-13 20:25 ` Linus Walleij
0 siblings, 0 replies; 4+ messages in thread
From: Linus Walleij @ 2015-12-13 20:25 UTC (permalink / raw
To: Manuel Lauss
Cc: linux-gpio@vger.kernel.org, Johan Hovold, Alexandre Courbot,
Michael Welling, Markus Pargmann, Ralf Baechle, Linux-MIPS
On Wed, Dec 9, 2015 at 10:44 PM, Manuel Lauss <manuel.lauss@gmail.com> wrote:
> On Wed, Dec 9, 2015 at 2:39 PM, Linus Walleij <linus.walleij@linaro.org> wrote:
>
>> ---
>> Ralf: please ACK this so I can take it through the GPIO tree.
>> BTW: would be nice if the MIPS GPIO drivers could move down
>> to drivers/gpio in the long run.
>
> Is there a specific reason? I have no objections to moving it, but
> on the other hand I also like that (in this case) most/all chip-specific
> code is grouped together and not scattered around the tree.
Here is a reason. This patch series. If I could just change all that and have
the dependencies inside the GPIO tree, refactoring struggles would be
so much easier.
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2015-12-13 20:25 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-12-09 13:39 [PATCH 135/182] MIPS: alchemy: switch to gpiochip_add_data() Linus Walleij
2015-12-09 13:54 ` Ralf Baechle
2015-12-09 21:44 ` Manuel Lauss
2015-12-13 20:25 ` Linus Walleij
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.