From mboxrd@z Thu Jan  1 00:00:00 1970
From: Michael Trimarchi <michael@amarulasolutions.com>
Date: Fri, 4 Dec 2015 18:06:23 +0100
Subject: [U-Boot] mmc erase fails from U-Boot command line
In-Reply-To: <5661C454.5030706@nelint.com>
References: <5620E3A7.7040909@defengcorp.com> <5624CEC5.8040901@digi.com>
 <CAOMZO5A4jB_xNKbZmcpa8xVy6i12Ww-fEhu5LzJ=HyboXo-eNQ@mail.gmail.com>
 <52F917CEA1B9C64C94833D53889D478C269236@dor-sms-xch01.digi.com>
 <CAOMZO5AxJPJ2D7SHXr5=DzEyyd3LnmL+D6QB3tRbsQS2U9W2iQ@mail.gmail.com>
 <CAOMZO5CiyCiJ0cd20crhzPzT9xBXupvZDSej5Fo_ic5ZugN_Ew@mail.gmail.com>
 <CAOMZO5DoOdh0wU2vv1iyUWt=PAxxV_nugun-bny1Cddes+JHMg@mail.gmail.com>
 <565DEF80.90204@nelint.com>
 <CAOMZO5Bw8fiOOsvD99Qwb-trcNcXN9ysEMy5AoUCFYKtg4tfnw@mail.gmail.com>
 <565F3CD3.1010100@nelint.com>
 <CAOMZO5C5yTV_KtXxD3im6r5-7RZGSS9VActGdO4mDVc7DmdPyg@mail.gmail.com>
 <CAOf5uw=aynOA6MQhStq=JDtfEOCH6N9bNOqFsExB57xaZpo2GQ@mail.gmail.com>
 <CAOMZO5Bro9KN+G2nXvOiK=4ZXZ59CTttPa68MkVORfoFMR=BPw@mail.gmail.com>
 <CAOf5uw=UhCKA3yzFNC6JQvN-OzbZ3mDWS+KSRUab9aef-oeL8w@mail.gmail.com>
 <5661BA7B.8030904@nelint.com> <5661C454.5030706@nelint.com>
Message-ID: <CAOf5uwmkdeZN58V9X-0trJ622=OFdQBNGc4EYx-GvKibhrUnpg@mail.gmail.com>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Hi

On Dec 4, 2015 5:50 PM, "Eric Nelson" <eric@nelint.com> wrote:
>
> Hi all,
>
> On 12/04/2015 09:08 AM, Eric Nelson wrote:
> ...
> >
> > I think you're onto something.
> >
> > According to the i.MX35 reference manual, which I think was the origin
> > of this patch, the low four bits of the SYSCTL register of the SDHC5
> >       3       - SDCLKEN
> >       2       - PEREN
> >       1       - HCKEN
> >       0       - IPGEN
> >
> > See page 603 of
> > http://cache.freescale.com/files/dsp/doc/ref_manual/IMX35RM.pdf
> >
> > But in the i.MX6 reference manual, the low four bits are reserved and
> > say "Always write as 1".
> >
> > See pages 5679-5680 of
> > http://cache.freescale.com/files/32bit/doc/ref_manual/IMX6DQRM.pdf
> >
> > It appears that when this patch was ported from the Freescale version,
> > the test for "is_usdhc" was lost.
> >
> >
http://git.denx.de/?p=u-boot.git;a=commitdiff;h=7a5b80297bc6cef0c10e5f57ac0450678dc7bc5e
> >
> >
>

Happy if you fix down your problem

Michael

> Following up, this code is bugged on i.MX6:
>
>
http://git.denx.de/?p=u-boot.git;a=blob;f=drivers/mmc/fsl_esdhc.c;h=c5054d66bdcda029f0485958c87bd5154ccee591;hb=HEAD#l505
>
> As are a couple of other things in the driver, as seen by
> trying to compile without the constants for the low 4 bits:
>
> diff --git a/include/fsl_esdhc.h b/include/fsl_esdhc.h
> index aa1b4cf..a4b87ce 100644
> --- a/include/fsl_esdhc.h
> +++ b/include/fsl_esdhc.h
> @@ -25,10 +25,12 @@
>  #define SYSCTL_INITA           0x08000000
>  #define SYSCTL_TIMEOUT_MASK    0x000f0000
>  #define SYSCTL_CLOCK_MASK      0x0000fff0
> +#if !defined(CONFIG_MX6)
>  #define SYSCTL_CKEN            0x00000008
>  #define SYSCTL_PEREN           0x00000004
>  #define SYSCTL_HCKEN           0x00000002
>  #define SYSCTL_IPGEN           0x00000001
> +#endif
>  #define SYSCTL_RSTA            0x01000000
>  #define SYSCTL_RSTC            0x02000000
>  #define SYSCTL_RSTD            0x04000000
>