On Wed, 12 May 2021 at 00:34, Denis Kenzior <denkenz@gmail.com> wrote:
> On 5/11/21 4:56 PM, Andrew Zaborowski wrote:
> > On Tue, 11 May 2021 at 18:36, Denis Kenzior <denkenz@gmail.com> wrote:
> >> On 5/10/21 5:12 AM, Andrew Zaborowski wrote:
> >>> Station callbacks expect a reason code (as opposed to status codes) with
> >>> this event type.  This shouldn't matter a lot because
> >>> station_disconnect_event() only actually looks at the value during
> >>
> >> I'm not sure why station is written this way.  I'm pretty sure that calling
> >> station_disconnect_event() for NETDEV_EVENT_DISCONNECT_BY_SME() is the wrong
> >> thing to do.
> >
> > That is currently the only use of that function though.
>
> No, we have DISCONNECT_BY_AP and DISCONNECT_BY_SME.  DISCONNECT_BY_SME should
> pretty much imply station_disassociated() should be called since we should never
> receive this event when we're in the connecting state.

I wouldn't rely on that, if the kernel doesn't pass
NL80211_ATTR_DISCONNECTED_BY_AP it could mean that the AP sent
something that triggered the kernel to disconnect (possibly before
handshake complete).  For us we mainly care that we can't use this BSS
and should try a different one next time.

Best regards