From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AF40CC2B9F7 for ; Mon, 24 May 2021 14:11:06 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8D015610CE for ; Mon, 24 May 2021 14:11:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232932AbhEXOMd (ORCPT ); Mon, 24 May 2021 10:12:33 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56884 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232462AbhEXOMd (ORCPT ); Mon, 24 May 2021 10:12:33 -0400 Received: from mail-vs1-xe33.google.com (mail-vs1-xe33.google.com [IPv6:2607:f8b0:4864:20::e33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9702CC061574 for ; Mon, 24 May 2021 07:11:04 -0700 (PDT) Received: by mail-vs1-xe33.google.com with SMTP id x2so8218027vss.3 for ; Mon, 24 May 2021 07:11:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=nHMt5Ue9zcAFsiS+aG2J53afQMewVgUVGCQ3OcSmIaI=; b=Ryx3qKevd+k6W5Rnks8NZAaKFLqZKWhCzg3LO95PFdvL7plkQSxQSYI8QUCAZ/eV1D IrS5pjnLv0KwovhGAEXepNyntb5RkHFB9Cqha8kBuzeX4H7c9RwltcUTrT0cJtKIeEUJ 2tX0gBs4+Wb5pMNe7dQJyCaNwdqmnBppftQe48v2y6/xAcfYGYtDxBWJm9TWi2gUaiN4 t6waMXogKzFIhF+6+Q7HA7LdPD5IlAK1sA+I/0FwER/k3NNXAhMsCL1eReHOfQj7Lqxx BVYNlnOic2o+abxb9MdxL31D00gWF3lCgFQsS1B7jvAWcBkx9cw4HAkKtcev55AFaEBE UzHg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=nHMt5Ue9zcAFsiS+aG2J53afQMewVgUVGCQ3OcSmIaI=; b=umKLMTYjO4alQGr3o/ntEOMJgum9dmd2SKZOVey0O1vhMOPd4DdYDSyKXk20A4bgKT xlUqjzJvalCQ1dAc0tEtGlOYQ7Kk0M1Aj2dlynHuJKtB51SfkwyOBny8JeCDVTQ3x/XP kdlKzL2PRNXWqcayQFmBjiBfle6hBkk2t3LLj0ZFRIkhh8QR6argq9tx/1yRGzp7EeFa Hm5rXIUDzfS/Q9o3gjoDYvni6ID1mCJlOt2pUh05B8q9rksjB29eIVNhmRlVTz5L2cpa cSUN5OAe1WU0IVv9UHbRQQSAE++lTvvf34GgdeERxBIpJaZ+7n5lhdLiRMrr6NSR46ff LUGg== X-Gm-Message-State: AOAM5323g08DQ0xlR8gCbVFo4wWkSNVlJGI4C6Z0qJn5uAzviGb86r9c vulZobWtoVkqr1v8ywWslFeVaRqG0+7OSLtckpEvTw== X-Google-Smtp-Source: ABdhPJwZWT1murqq4tYSjwsKyhu/eVCjhOyZeUmeeUfmlUNfeNGcgWIUriES6cC+bDh+rWS1u7k+V+I7Cs/PFPRhcm8= X-Received: by 2002:a05:6102:7d5:: with SMTP id y21mr21664208vsg.19.1621865463713; Mon, 24 May 2021 07:11:03 -0700 (PDT) MIME-Version: 1.0 References: <20210510190400.105162-1-l.stach@pengutronix.de> <20210510190400.105162-3-l.stach@pengutronix.de> In-Reply-To: <20210510190400.105162-3-l.stach@pengutronix.de> From: Ulf Hansson Date: Mon, 24 May 2021 16:10:23 +0200 Message-ID: Subject: Re: [PATCH v2 3/3] mmc: core: add support for disabling HS400 mode via DT To: Lucas Stach Cc: Adrian Hunter , Haibo Chen , Rob Herring , NXP Linux Team , Sascha Hauer , linux-mmc , DTML , Linux ARM Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Mon, 10 May 2021 at 21:04, Lucas Stach wrote: > > From: Lucas Stach > > On some boards the data strobe line isn't wired up, rendering HS400 > support broken, even if both the controller and the eMMC claim to > support it. Allow to disable HS400 mode via DT. > > Signed-off-by: Lucas Stach Applied for next, thanks! Kind regards Uffe > --- > v2: > - move to core > - actually disable all HS400 modes > --- > drivers/mmc/core/host.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/mmc/core/host.c b/drivers/mmc/core/host.c > index 9b89a91b6b47..0e066c5f5243 100644 > --- a/drivers/mmc/core/host.c > +++ b/drivers/mmc/core/host.c > @@ -351,6 +351,9 @@ int mmc_of_parse(struct mmc_host *host) > host->caps2 |= MMC_CAP2_NO_SD; > if (device_property_read_bool(dev, "no-mmc")) > host->caps2 |= MMC_CAP2_NO_MMC; > + if (device_property_read_bool(dev, "no-mmc-hs400")) > + host->caps2 &= ~(MMC_CAP2_HS400_1_8V | MMC_CAP2_HS400_1_2V | > + MMC_CAP2_HS400_ES); > > /* Must be after "non-removable" check */ > if (device_property_read_u32(dev, "fixed-emmc-driver-type", &drv_type) == 0) { > -- > 2.31.1 > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 41343C2B9F7 for ; Mon, 24 May 2021 22:44:10 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id F290561400 for ; Mon, 24 May 2021 22:44:09 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org F290561400 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=gu8mKSqpJinfpvbsMgvtH1/HJuPDTYGxHX5khI5ik3s=; b=qtOlMd21kd985Q d2o2Sa+6+KTykAsXN5PsMttVnOicldKYRezySgXs6tjDvuM2yQpBIa4q89BdUXIkOLQFtbOw1gbN5 9QjuJ0LKvQ/hf7EBQZp7TWIiMrh66xTdw2457Qa1S/DDYt7Dhl14wEjjnyaHOu6x/uXWuFko/nE5W jm/G/Sgv+JTmc7wn6CQ2RQswxsL7Wt+XKNdcGQJg8dgMlwIic4OwnlZDdb8VzttUqKgbMIstWcoag ReaDk0yt7cwAgEN0ikv77pxu8H85gnMvvE/lUZmgGOslhJY/c0bqLOi0Hk3EI3oZlU2dHwjcXe7oZ VxjYRxEq/Pjscv1FcVRQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1llJGW-002Ayj-D4; Mon, 24 May 2021 22:41:41 +0000 Received: from mail-vs1-xe2d.google.com ([2607:f8b0:4864:20::e2d]) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1llBIP-000zDV-J0 for linux-arm-kernel@lists.infradead.org; Mon, 24 May 2021 14:11:07 +0000 Received: by mail-vs1-xe2d.google.com with SMTP id x2so8218028vss.3 for ; Mon, 24 May 2021 07:11:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=nHMt5Ue9zcAFsiS+aG2J53afQMewVgUVGCQ3OcSmIaI=; b=Ryx3qKevd+k6W5Rnks8NZAaKFLqZKWhCzg3LO95PFdvL7plkQSxQSYI8QUCAZ/eV1D IrS5pjnLv0KwovhGAEXepNyntb5RkHFB9Cqha8kBuzeX4H7c9RwltcUTrT0cJtKIeEUJ 2tX0gBs4+Wb5pMNe7dQJyCaNwdqmnBppftQe48v2y6/xAcfYGYtDxBWJm9TWi2gUaiN4 t6waMXogKzFIhF+6+Q7HA7LdPD5IlAK1sA+I/0FwER/k3NNXAhMsCL1eReHOfQj7Lqxx BVYNlnOic2o+abxb9MdxL31D00gWF3lCgFQsS1B7jvAWcBkx9cw4HAkKtcev55AFaEBE UzHg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=nHMt5Ue9zcAFsiS+aG2J53afQMewVgUVGCQ3OcSmIaI=; b=nmdq9qPgkaCUUFzLGMhcyUsIkCcex0fdIREhuBaSp7S03oSUrr+uWgTbhWAiOJrO3g reCiioSjWTyFcy+Eakvy/O+Q1tDRQE4vl2FFMqBJMCA6jFdeI7LuG800b7AnIx1bCGiT Um2zS7gpcRyUayjcBvuGjtBGH+apRm+EAVcJhz6pxbKGkVIdt7jl7rAdZDgdtHi6Obnl 6py9fL1cm/Zm9xOM4p78vqo8V6sO5RjGtU2WWGcPErD+Cu9LvEm4EDhGXUAhl6KqWrPU /iLIiG14JyC/AjTuX/sJRXkj1/gSTuyI6HHVzyvAXiiaF5wMk2ND4LSHS+OGmz+cAM0k z3mA== X-Gm-Message-State: AOAM533V1Bsrh+IXMluNc4EQkzHdKXiM7EitUXQOIv6rAiQfVEgd0TRS LtLck2vHPsi7sXBHOpZe7XwcqD8+442hi0wiAHUEzNG+T+W+aw== X-Google-Smtp-Source: ABdhPJwZWT1murqq4tYSjwsKyhu/eVCjhOyZeUmeeUfmlUNfeNGcgWIUriES6cC+bDh+rWS1u7k+V+I7Cs/PFPRhcm8= X-Received: by 2002:a05:6102:7d5:: with SMTP id y21mr21664208vsg.19.1621865463713; Mon, 24 May 2021 07:11:03 -0700 (PDT) MIME-Version: 1.0 References: <20210510190400.105162-1-l.stach@pengutronix.de> <20210510190400.105162-3-l.stach@pengutronix.de> In-Reply-To: <20210510190400.105162-3-l.stach@pengutronix.de> From: Ulf Hansson Date: Mon, 24 May 2021 16:10:23 +0200 Message-ID: Subject: Re: [PATCH v2 3/3] mmc: core: add support for disabling HS400 mode via DT To: Lucas Stach Cc: Adrian Hunter , Haibo Chen , Rob Herring , NXP Linux Team , Sascha Hauer , linux-mmc , DTML , Linux ARM X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210524_071105_661792_B75B332E X-CRM114-Status: GOOD ( 19.35 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, 10 May 2021 at 21:04, Lucas Stach wrote: > > From: Lucas Stach > > On some boards the data strobe line isn't wired up, rendering HS400 > support broken, even if both the controller and the eMMC claim to > support it. Allow to disable HS400 mode via DT. > > Signed-off-by: Lucas Stach Applied for next, thanks! Kind regards Uffe > --- > v2: > - move to core > - actually disable all HS400 modes > --- > drivers/mmc/core/host.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/mmc/core/host.c b/drivers/mmc/core/host.c > index 9b89a91b6b47..0e066c5f5243 100644 > --- a/drivers/mmc/core/host.c > +++ b/drivers/mmc/core/host.c > @@ -351,6 +351,9 @@ int mmc_of_parse(struct mmc_host *host) > host->caps2 |= MMC_CAP2_NO_SD; > if (device_property_read_bool(dev, "no-mmc")) > host->caps2 |= MMC_CAP2_NO_MMC; > + if (device_property_read_bool(dev, "no-mmc-hs400")) > + host->caps2 &= ~(MMC_CAP2_HS400_1_8V | MMC_CAP2_HS400_1_2V | > + MMC_CAP2_HS400_ES); > > /* Must be after "non-removable" check */ > if (device_property_read_u32(dev, "fixed-emmc-driver-type", &drv_type) == 0) { > -- > 2.31.1 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel