From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754658AbbINJaK (ORCPT ); Mon, 14 Sep 2015 05:30:10 -0400 Received: from mail-wi0-f176.google.com ([209.85.212.176]:37771 "EHLO mail-wi0-f176.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753345AbbINJaI (ORCPT ); Mon, 14 Sep 2015 05:30:08 -0400 MIME-Version: 1.0 In-Reply-To: <55E6E0FD.7000806@linaro.org> References: <1441135938-8056-1-git-send-email-vaibhav.hiremath@linaro.org> <1441135938-8056-3-git-send-email-vaibhav.hiremath@linaro.org> <20150902150442.118d3305@xhacker> <55E6B129.1030002@linaro.org> <20150902162627.682cdedf@xhacker> <55E6E0FD.7000806@linaro.org> Date: Mon, 14 Sep 2015 11:30:06 +0200 Message-ID: Subject: Re: [RFC 2/3] mmc: sdhci: add host_ops->voltage_switch callback for all other voltages From: Ulf Hansson To: Vaibhav Hiremath Cc: Jisheng Zhang , linux-mmc , Linus Walleij , "linux-kernel@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org [...] >>>> >>>> Could this be implemented by regulator API? From patch set 3/3, the >>>> pxa1928 >>>> voltage_switch hook is to operate the IO pad registers, this seems not >>>> belong >>>> to the SDHC IP core. >>>> >>> >>> Not quite sure whether regulator would be right fit for this. >> >> >> From the patche[3/3], this can be achieved by abstracting the IO PAD as >> regulators >> then, we may not need to touch the core sdhci.c. But I'm not sure whether >> this >> is the good solution or not. > > > Exactly... > >> sdhci Maintainers and experts may have better >> suggestions. >> > > Thats is the reason I stamped it as a RFC :) > [...] >>From an mmc core perspective it would be preferred if you implement this as a regulator (vqmmc). Especially since we will soon have an API for how to set the I/O voltages - and the intelligence within that API is not something we would like to implement for each and every host driver. https://lkml.org/lkml/2015/8/31/367 Kind regards Uffe From mboxrd@z Thu Jan 1 00:00:00 1970 From: ulf.hansson@linaro.org (Ulf Hansson) Date: Mon, 14 Sep 2015 11:30:06 +0200 Subject: [RFC 2/3] mmc: sdhci: add host_ops->voltage_switch callback for all other voltages In-Reply-To: <55E6E0FD.7000806@linaro.org> References: <1441135938-8056-1-git-send-email-vaibhav.hiremath@linaro.org> <1441135938-8056-3-git-send-email-vaibhav.hiremath@linaro.org> <20150902150442.118d3305@xhacker> <55E6B129.1030002@linaro.org> <20150902162627.682cdedf@xhacker> <55E6E0FD.7000806@linaro.org> Message-ID: To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org [...] >>>> >>>> Could this be implemented by regulator API? From patch set 3/3, the >>>> pxa1928 >>>> voltage_switch hook is to operate the IO pad registers, this seems not >>>> belong >>>> to the SDHC IP core. >>>> >>> >>> Not quite sure whether regulator would be right fit for this. >> >> >> From the patche[3/3], this can be achieved by abstracting the IO PAD as >> regulators >> then, we may not need to touch the core sdhci.c. But I'm not sure whether >> this >> is the good solution or not. > > > Exactly... > >> sdhci Maintainers and experts may have better >> suggestions. >> > > Thats is the reason I stamped it as a RFC :) > [...] >>From an mmc core perspective it would be preferred if you implement this as a regulator (vqmmc). Especially since we will soon have an API for how to set the I/O voltages - and the intelligence within that API is not something we would like to implement for each and every host driver. https://lkml.org/lkml/2015/8/31/367 Kind regards Uffe