From: Ulf Hansson <ulf.hansson@linaro.org>
To: Alex Lemberg <Alex.Lemberg@sandisk.com>
Cc: Avi Shchislowski <Avi.Shchislowski@sandisk.com>,
linux-mmc <linux-mmc@vger.kernel.org>
Subject: Re: [RFC PATCH v3] mmc: sleep notification
Date: Tue, 25 Aug 2015 14:04:58 +0200 [thread overview]
Message-ID: <CAPDyKFryzJH9UHd8QJssejjA=b--_1hjRaO+B9sM5HVHo2eFZQ@mail.gmail.com> (raw)
In-Reply-To: <282CEDFCBC30114F83C499CB8F2ED53343C9F474@SACMBXIP01.sdcorp.global.sandisk.com>
[...]
>> >> > The only case where HPI is used in this patch - is during
>> >> > sleep_notify
>> >> timeout error.
>> >>
>> >> Why?
>> >
>> > In case of timeout error, we would like to handle it by sending HPI - to let
>> device interrupt/stop the prg state.
>>
>> Is that according to the spec? I think it would be better to try a reset
>> sequence to recover, by using CMD0 and so forth, what do you think?
>
> Not must by the spec, but there are several options how to handle timeout error.
> Checking the existing driver, the '-ETIMEDOUT' error is handled by mmc_interrupt_hpi ()
> in case of mmc_wait_for_req_done() function.
> Can we use the same approach?
Currently the logic to recover from errors during system PM suspend,
relies on the request-retry mechanism which is executed far later.
>From the ->suspend() callback we will only propagate the error code
towards the PM core. That means the PM core will bail out and reverse
the actions already done for suspended devices.
In this initial patch, I suggest we stick to that behaviour.
Although, I am open to discuss a more sophisticated error handling,
but let's do that from a separate patch.
[...]
Kind regards
Uffe
prev parent reply other threads:[~2015-08-25 12:05 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-08 6:46 [RFC PATCH v3] mmc: sleep notification Avi Shchislowski
2015-06-08 9:03 ` Ulf Hansson
2015-06-08 13:17 ` Alex Lemberg
2015-06-15 8:23 ` Ulf Hansson
2015-06-18 14:57 ` Alex Lemberg
2015-07-22 14:40 ` Ulf Hansson
2015-08-03 12:44 ` Alex Lemberg
2015-08-25 12:04 ` Ulf Hansson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAPDyKFryzJH9UHd8QJssejjA=b--_1hjRaO+B9sM5HVHo2eFZQ@mail.gmail.com' \
--to=ulf.hansson@linaro.org \
--cc=Alex.Lemberg@sandisk.com \
--cc=Avi.Shchislowski@sandisk.com \
--cc=linux-mmc@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.