From: Dave Airlie <airlied@gmail.com>
To: "Marc-André Lureau" <marcandre.lureau@gmail.com>
Cc: Gerd Hoffmann <kraxel@redhat.com>, QEMU <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] virtio-gpu: cursor update not in sync with resource update
Date: Tue, 15 Sep 2015 07:08:10 +1000 [thread overview]
Message-ID: <CAPM=9twxir5ftpvPOU0aAPatYgHAgyEp10xWn2CM0T9=ExjRug@mail.gmail.com> (raw)
In-Reply-To: <CAJ+F1CJwTfSWQ2AFdNAv8iH3XTzDr_Z9NxkxxKg6yOqBv8aOTQ@mail.gmail.com>
On 15 September 2015 at 01:17, Marc-André Lureau
<marcandre.lureau@gmail.com> wrote:
> Hi
>
> On Mon, Sep 14, 2015 at 4:06 PM, Gerd Hoffmann <kraxel@redhat.com> wrote:
>> The guest can upload different cursors and then switch between them
>> without re-uploading and therefore without ctrl queue updates. Thats
>> why they have an id in the first place ...
>
> Ok, but the cursor id is reused most of the time. So there are at
> least two things to fix: use different cursor ids for different cursor
> data (with some cache management probably), fix kernel to only upload
> new resource id and wait for data to be transfered. Is that correct?
Currently the kernel driver does this:
ret = virtio_gpu_cmd_transfer_to_host_2d(vgdev, qobj->hw_res_handle, 0,
cpu_to_le32(64),
cpu_to_le32(64),
0, 0, &fence);
if (!ret) {
reservation_object_add_excl_fence(qobj->tbo.resv,
&fence->f);
virtio_gpu_object_wait(qobj, false);
}
before moving the cursor, shouldn't that suffice?
Do we fail the transfer sometimes?
Dave.
next prev parent reply other threads:[~2015-09-14 21:08 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-14 12:40 [Qemu-devel] virtio-gpu: cursor update not in sync with resource update Marc-André Lureau
2015-09-14 14:06 ` Gerd Hoffmann
2015-09-14 15:17 ` Marc-André Lureau
2015-09-14 21:08 ` Dave Airlie [this message]
2015-09-14 21:14 ` Marc-André Lureau
2015-09-14 21:18 ` Dave Airlie
2015-09-15 6:20 ` Gerd Hoffmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAPM=9twxir5ftpvPOU0aAPatYgHAgyEp10xWn2CM0T9=ExjRug@mail.gmail.com' \
--to=airlied@gmail.com \
--cc=kraxel@redhat.com \
--cc=marcandre.lureau@gmail.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.