From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:55603) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zbb96-0001aQ-58 for qemu-devel@nongnu.org; Mon, 14 Sep 2015 17:18:40 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Zbb95-0004oO-Ei for qemu-devel@nongnu.org; Mon, 14 Sep 2015 17:18:40 -0400 Received: from mail-la0-x230.google.com ([2a00:1450:4010:c03::230]:33124) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zbb95-0004nP-82 for qemu-devel@nongnu.org; Mon, 14 Sep 2015 17:18:39 -0400 Received: by lamp12 with SMTP id p12so94017578lam.0 for ; Mon, 14 Sep 2015 14:18:38 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: References: <1442239599.13588.5.camel@redhat.com> Date: Tue, 15 Sep 2015 07:18:38 +1000 Message-ID: From: Dave Airlie Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] virtio-gpu: cursor update not in sync with resource update List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?UTF-8?B?TWFyYy1BbmRyw6kgTHVyZWF1?= Cc: Gerd Hoffmann , QEMU On 15 September 2015 at 07:14, Marc-Andr=C3=A9 Lureau wrote: > Hi > > On Mon, Sep 14, 2015 at 11:08 PM, Dave Airlie wrote: >> Currently the kernel driver does this: >> >> ret =3D virtio_gpu_cmd_transfer_to_host_2d(vgdev, qobj->hw_res_h= andle, 0, >> cpu_to_le32(64), >> cpu_to_le32(64), >> 0, 0, &fence); >> if (!ret) { >> reservation_object_add_excl_fence(qobj->tbo.resv, >> &fence->f); >> virtio_gpu_object_wait(qobj, false); >> } >> >> before moving the cursor, shouldn't that suffice? >> >> Do we fail the transfer sometimes? > > > That's apparently not in Gerd tree. Interesting, I'm not sure where this got lost, I had it in my clone of Gerd's tree from a while back. Dave.